From: Stefano Brivio <sbrivio@redhat.com>
To: Laurent Vivier <lvivier@redhat.com>
Cc: passt-dev@passt.top
Subject: Re: [PATCH v7 1/8] tcp: extract buffer management from tcp_send_flag()
Date: Thu, 13 Jun 2024 15:43:09 +0200 [thread overview]
Message-ID: <20240613154309.3a5336e1@elisabeth> (raw)
In-Reply-To: <8d038a70-76fe-4aab-ab6f-81ffa63ff797@redhat.com>
On Thu, 13 Jun 2024 14:58:42 +0200
Laurent Vivier <lvivier@redhat.com> wrote:
> On 13/06/2024 14:36, Laurent Vivier wrote:
> > This commit isolates the internal data structure management used for storing
> > data (e.g., tcp4_l2_flags_iov[], tcp6_l2_flags_iov[], tcp4_flags_ip[],
> > tcp4_flags[], ...) from the tcp_send_flag() function. The extracted
> > functionality is relocated to a new function named tcp_fill_flag_header().
> >
> > tcp_fill_flag_header() is now a generic function that accepts parameters such
> > as struct tcphdr and a data pointer. tcp_send_flag() utilizes this parameter to
> > pass memory pointers from tcp4_l2_flags_iov[] and tcp6_l2_flags_iov[].
> >
> > This separation sets the stage for utilizing tcp_fill_flag_header() to
> > set the memory provided by the guest via vhost-user in future developments.
>
> Forgot to update the comment: s/tcp_fill_flag_header/tcp_prepare_flags/
>
> Could you update on merge?
Sure. Running tests now...
--
Stefano
next prev parent reply other threads:[~2024-06-13 13:43 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-13 12:36 [PATCH v7 0/8] Add vhost-user support to passt (part 2) Laurent Vivier
2024-06-13 12:36 ` [PATCH v7 1/8] tcp: extract buffer management from tcp_send_flag() Laurent Vivier
2024-06-13 12:58 ` Laurent Vivier
2024-06-13 13:43 ` Stefano Brivio [this message]
2024-06-13 12:36 ` [PATCH v7 2/8] tcp: move buffers management functions to their own file Laurent Vivier
2024-06-13 12:36 ` [PATCH v7 3/8] tap: refactor packets handling functions Laurent Vivier
2024-06-13 12:36 ` [PATCH v7 4/8] udp: refactor UDP header update functions Laurent Vivier
2024-06-13 12:36 ` [PATCH v7 5/8] udp: rename udp_sock_handler() to udp_buf_sock_handler() Laurent Vivier
2024-06-13 12:36 ` [PATCH v7 6/8] vhost-user: compare mode MODE_PASTA and not MODE_PASST Laurent Vivier
2024-06-13 12:36 ` [PATCH v7 7/8] iov: remove iov_copy() Laurent Vivier
2024-06-13 12:36 ` [PATCH v7 8/8] tap: use in->buf_size rather than sizeof(pkt_buf) Laurent Vivier
2024-06-13 14:34 ` [PATCH v7 0/8] Add vhost-user support to passt (part 2) Stefano Brivio
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240613154309.3a5336e1@elisabeth \
--to=sbrivio@redhat.com \
--cc=lvivier@redhat.com \
--cc=passt-dev@passt.top \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://passt.top/passt
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for IMAP folder(s).