From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by passt.top (Postfix) with ESMTP id 7F92B5A004E for ; Thu, 13 Jun 2024 15:43:50 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1718286229; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=DceHbpKj3pTzXlc7udA5EHmpp+HgTCJdofT54r88dnc=; b=JTf6PNsLWYRyhbVDE4ogqI19IytbCc+X+e+4Qtm6TRfPbw43MIvfNrXaESkBVoeQwzu1Gr wTqkL8ggw0VZJ4V7w+ZdYgFDK8buwmLkZahqpHBA9/A2mLrwAkBp9P2KJtQrRWUNdhKEHI POh/0AIzXPEEvA37N213VZPW8vvhfWs= Received: from mail-qt1-f200.google.com (mail-qt1-f200.google.com [209.85.160.200]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-180-UoBbJmg-Nges1gANIabN2Q-1; Thu, 13 Jun 2024 09:43:48 -0400 X-MC-Unique: UoBbJmg-Nges1gANIabN2Q-1 Received: by mail-qt1-f200.google.com with SMTP id d75a77b69052e-4411f4617d9so9334941cf.1 for ; Thu, 13 Jun 2024 06:43:48 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1718286227; x=1718891027; h=content-transfer-encoding:mime-version:organization:references :in-reply-to:message-id:subject:cc:to:from:date:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=DceHbpKj3pTzXlc7udA5EHmpp+HgTCJdofT54r88dnc=; b=lyzaXWF/oezJCR982oYuq28Z3LQ5CzphymHZjL3pplRYluZk1bpLXT82Qconu+sOBB JnQHSkL3QBVMGP3RwtJR51zxSrtuvanw5+Pa28Iip1lwC+V0beV0hFQi6QjRO2h+45p4 PehMGZ/A1jBIdthJ10INb2p2LmvoiibBtsoTRofrjgjjUKQ5Sw4gdLG1HXy5U7i9K4Xo tjZUvQbnk5sMQpyW00evYNbiRjIgAv1oZo0ryvsqy5m+kT1tb1DdpOpWbm1+4szbJQqz TeomlEr6Fk4ZPKaeQ0gV5QclxEkLxb1YdlA4a9H5CYFy5RLuBPN0WF/TuWcRmCclHjm1 J5gg== X-Gm-Message-State: AOJu0YzSVoIsLZpQplZGzhL8mdXsB1cJy3dJIPPqxLq1EtN5LvYvS4OX ATxVWCk1aD3glvCAH4M7dsVKMKSx9j6Gx1kRb14z7Z5gbQzUhXURJh795LzOo/BSEVft3yrVtKD iWpmtpySwQrxkmQwXeIzfIRRXmwu5Vnw3rnYIeyXziMmItAljAJY39RJf7r/6vvBgib6Z8/ycQ8 4LUJ38ysc9Psnz7vVGUVFqLq8bvYBmHJ3PGFo= X-Received: by 2002:ac8:7f8e:0:b0:441:431f:1484 with SMTP id d75a77b69052e-4415ac6e7a6mr47208461cf.60.1718286226813; Thu, 13 Jun 2024 06:43:46 -0700 (PDT) X-Google-Smtp-Source: AGHT+IEfrAj6DTBDI0fdJU1GHKj5WDcJJ8IXAWcH4YwPXqok5Jxg31ZnBsneKtDT4p0NyOZEJwfTpw== X-Received: by 2002:ac8:7f8e:0:b0:441:431f:1484 with SMTP id d75a77b69052e-4415ac6e7a6mr47208011cf.60.1718286226108; Thu, 13 Jun 2024 06:43:46 -0700 (PDT) Received: from maya.cloud.tilaa.com (maya.cloud.tilaa.com. [164.138.29.33]) by smtp.gmail.com with ESMTPSA id d75a77b69052e-441ef3d88b7sm6270451cf.13.2024.06.13.06.43.45 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Thu, 13 Jun 2024 06:43:45 -0700 (PDT) Date: Thu, 13 Jun 2024 15:43:09 +0200 From: Stefano Brivio To: Laurent Vivier Subject: Re: [PATCH v7 1/8] tcp: extract buffer management from tcp_send_flag() Message-ID: <20240613154309.3a5336e1@elisabeth> In-Reply-To: <8d038a70-76fe-4aab-ab6f-81ffa63ff797@redhat.com> References: <20240613123655.1362065-1-lvivier@redhat.com> <20240613123655.1362065-2-lvivier@redhat.com> <8d038a70-76fe-4aab-ab6f-81ffa63ff797@redhat.com> Organization: Red Hat X-Mailer: Claws Mail 4.2.0 (GTK 3.24.41; x86_64-pc-linux-gnu) MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Message-ID-Hash: NYICU3FEDHN5COKZYPGSGOJPTEB5Q753 X-Message-ID-Hash: NYICU3FEDHN5COKZYPGSGOJPTEB5Q753 X-MailFrom: sbrivio@redhat.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: passt-dev@passt.top X-Mailman-Version: 3.3.8 Precedence: list List-Id: Development discussion and patches for passt Archived-At: Archived-At: List-Archive: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On Thu, 13 Jun 2024 14:58:42 +0200 Laurent Vivier wrote: > On 13/06/2024 14:36, Laurent Vivier wrote: > > This commit isolates the internal data structure management used for storing > > data (e.g., tcp4_l2_flags_iov[], tcp6_l2_flags_iov[], tcp4_flags_ip[], > > tcp4_flags[], ...) from the tcp_send_flag() function. The extracted > > functionality is relocated to a new function named tcp_fill_flag_header(). > > > > tcp_fill_flag_header() is now a generic function that accepts parameters such > > as struct tcphdr and a data pointer. tcp_send_flag() utilizes this parameter to > > pass memory pointers from tcp4_l2_flags_iov[] and tcp6_l2_flags_iov[]. > > > > This separation sets the stage for utilizing tcp_fill_flag_header() to > > set the memory provided by the guest via vhost-user in future developments. > > Forgot to update the comment: s/tcp_fill_flag_header/tcp_prepare_flags/ > > Could you update on merge? Sure. Running tests now... -- Stefano