From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by passt.top (Postfix) with ESMTP id 07C795A004E for ; Thu, 13 Jun 2024 16:35:23 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1718289323; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=t+SCTytEPMRHOXotKO9UcwNrxqEgVXZ83bEyvXjlaQs=; b=G/MxnPgYtQAnAM9MnjNN8GUeFrsG+7zGu4bJY4TeKX3zFPOJmxBQV3LccprNyx92+nJa8/ Eg+zcfUfXh/Q2GHYkl0j48Da9bJSeSn4icbjZ5Im1jVG3nUmOnjKEVHO4DFbspVxhvxqH7 ixOxep4WB9Yuy/XECOGmXHs5qhJlG8Y= Received: from mail-qt1-f198.google.com (mail-qt1-f198.google.com [209.85.160.198]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-687-USumZ_iGPseqQPqqFvJqjA-1; Thu, 13 Jun 2024 10:35:21 -0400 X-MC-Unique: USumZ_iGPseqQPqqFvJqjA-1 Received: by mail-qt1-f198.google.com with SMTP id d75a77b69052e-43fe401dd5aso8820871cf.0 for ; Thu, 13 Jun 2024 07:35:21 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1718289321; x=1718894121; h=content-transfer-encoding:mime-version:organization:references :in-reply-to:message-id:subject:cc:to:from:date:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=t+SCTytEPMRHOXotKO9UcwNrxqEgVXZ83bEyvXjlaQs=; b=njIvdpBSgJ7jqwHJ9d2+7DhwvycqhC1s/pPZaRVm9ka8slcs8ZKEHLWXx/K4Wz8b8p HnoMRLBycaYvNAtmZVC7l4QEz+XR8la6NhvR7lz0iCBWW/bzRpzSFfQzTpL1JHdnIDho 7bQlzPRJjhL4CnUXth3Saajwb8FExKx7UKgQbv29f4z7LbFvEdc1tM3dYAdTJUX0uKur aD67sSZK/UuuYJr8MqVdGyxinBzuKw6t5/Bqcbv/7wxxputZ4+CsC7fUE2MIo2lPe+Qk X3A4mSzZ61Db9RSOQiO8ghiciqfIdIxVQTpw6iYIVY62h2/T72d65dGi6hqjz4iSfX+B bfJw== X-Gm-Message-State: AOJu0YxXxT7kFY75IcVcl6kYasJKVkQc24xPjUA0XzNi+B3hEezq+8RG nUeQSFCNVFgtQF4xAb8KdzwD4f/6Tq29khTplTu8vTU54F0UGDEZ9jgo7sPuY9PS1DQ+LVWyghL k8GpugubORNSA6ilKRibW0u2AoN8Fip6TjbIBwEc+xkI/cwwRWg== X-Received: by 2002:a05:620a:410b:b0:797:df6:ec7 with SMTP id af79cd13be357-797f6005f6bmr590397285a.12.1718289320864; Thu, 13 Jun 2024 07:35:20 -0700 (PDT) X-Google-Smtp-Source: AGHT+IH0bTvmb5ej30VDPhZZgG5wRvP0E8SVjeuzDQx0n7s8cXc4Duo6WFPdBsra9mAjkRhp7xs2EQ== X-Received: by 2002:a05:620a:410b:b0:797:df6:ec7 with SMTP id af79cd13be357-797f6005f6bmr590393385a.12.1718289320236; Thu, 13 Jun 2024 07:35:20 -0700 (PDT) Received: from maya.cloud.tilaa.com (maya.cloud.tilaa.com. [164.138.29.33]) by smtp.gmail.com with ESMTPSA id af79cd13be357-798aacae1dasm57629785a.25.2024.06.13.07.35.18 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Thu, 13 Jun 2024 07:35:19 -0700 (PDT) Date: Thu, 13 Jun 2024 16:34:42 +0200 From: Stefano Brivio To: Laurent Vivier Subject: Re: [PATCH v7 0/8] Add vhost-user support to passt (part 2) Message-ID: <20240613163442.41ebc88a@elisabeth> In-Reply-To: <20240613123655.1362065-1-lvivier@redhat.com> References: <20240613123655.1362065-1-lvivier@redhat.com> Organization: Red Hat X-Mailer: Claws Mail 4.2.0 (GTK 3.24.41; x86_64-pc-linux-gnu) MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Message-ID-Hash: GNPKRULXXWXPTIWHRDAWPQ67UAKJNPYF X-Message-ID-Hash: GNPKRULXXWXPTIWHRDAWPQ67UAKJNPYF X-MailFrom: sbrivio@redhat.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: passt-dev@passt.top, David Gibson X-Mailman-Version: 3.3.8 Precedence: list List-Id: Development discussion and patches for passt Archived-At: Archived-At: List-Archive: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On Thu, 13 Jun 2024 14:36:47 +0200 Laurent Vivier wrote: > Extract buffers management code from tcp.c and move > it to tcp_buf.c > tcp.c keeps all the generic code and will be also used by > the vhost-user functions. > > Also compare mode to MODE_PASTA, as we will manage vhost-user > mode (MODE_VU) like MODE_PASST. > > v7: > - update comments (tap_flush_pools(), func and line) > - drop "-L4" in tcp_buf.c header > - fix *optlen initializatio > - fix tcp4_flags_used/tcp6_flags_used value on error > - fix seq_to_tap value Applied! -- Stefano