From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by passt.top (Postfix) with ESMTP id 855435A004F for ; Fri, 14 Jun 2024 13:15:08 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1718363707; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=S15jC3sQh+blnJmaiEF2WjDZLNBmAHy1IK67IZJPDjY=; b=RjC/CyHcwRmvsZc0dsNOSgkajfEXaGHvT0ALXZRgZtT9q1J+OlP57FLgItTkPVtF7mQaE4 124zwMSQI4LW8FLzVjo9VYv1Hi/413N8WmiKyreFX/rdBcfgvTKC2QombWho7CgmQp64uW huf83J2cMRBGpl9y69lo/947aEab/ss= Received: from mail-vk1-f199.google.com (mail-vk1-f199.google.com [209.85.221.199]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-665-RyF1SLHAO3eAg54eMva6sA-1; Fri, 14 Jun 2024 07:15:06 -0400 X-MC-Unique: RyF1SLHAO3eAg54eMva6sA-1 Received: by mail-vk1-f199.google.com with SMTP id 71dfb90a1353d-4e1408158c9so848558e0c.0 for ; Fri, 14 Jun 2024 04:15:06 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1718363704; x=1718968504; h=content-transfer-encoding:mime-version:organization:references :in-reply-to:message-id:subject:cc:to:from:date:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=S15jC3sQh+blnJmaiEF2WjDZLNBmAHy1IK67IZJPDjY=; b=nggTPKG71nJucAzZyvWKnjVqjLrbZqRZrQgNaXjX9x1lso4Ybk/rgWeaImstzFDz4t V869yldKmObAn9PlEPVCi5I+/znLq9um1Zl9bw8vRK5w3gPXrECmMtOT+H/mDUW0N1bG dmeTWiraaR3jg4+Tfh3y/ca2OTnm7IBDqvUMqbTC/3Db/pooM4S/vjn5e7uKrTrHLd2v DpLN2K2bG8oI/Zw98UGo55FhdUlcCaU127i2zuq4SPEEA4bSeXsahwOVTST7FfX7rzbr 6wyIDhIL9ZnZ83eNqt+9dGGvpzslKmJGJXJ1kcfHAB3KuTWjolr3hxphJp2p6Rg4TEC/ grHQ== X-Gm-Message-State: AOJu0Yw5bma+LmF9+kSj54d59Z08ljT6098RxKGFjXpjflj5QlMpfUUS REv1mmjeesuE8ZagTFC0jfXFjQen4R9PEuYOv40e7CC14W7sOlRsjc3Znc3qfNs0478bg3osr0w 4andlP4q57OjUW2ifx/awQkkFQkre90my4iBHlZYgrbvhEkpZiIJDK8rXh2UW X-Received: by 2002:a05:6122:310c:b0:4ec:f7e7:7f68 with SMTP id 71dfb90a1353d-4ee3e98a74cmr2679474e0c.4.1718363704025; Fri, 14 Jun 2024 04:15:04 -0700 (PDT) X-Google-Smtp-Source: AGHT+IF0dp8A/osJwKz2yTlFqCHJLqurRIFcq5c5ty+vy+8Y1pc4mCMHi48Dz06deUxNfr28n5zK+w== X-Received: by 2002:a05:6122:310c:b0:4ec:f7e7:7f68 with SMTP id 71dfb90a1353d-4ee3e98a74cmr2679438e0c.4.1718363703420; Fri, 14 Jun 2024 04:15:03 -0700 (PDT) Received: from maya.cloud.tilaa.com (maya.cloud.tilaa.com. [164.138.29.33]) by smtp.gmail.com with ESMTPSA id d75a77b69052e-441ef3d85e8sm15134481cf.2.2024.06.14.04.15.02 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Fri, 14 Jun 2024 04:15:02 -0700 (PDT) Date: Fri, 14 Jun 2024 13:14:27 +0200 From: Stefano Brivio To: David Gibson Subject: Re: [PATCH v2 0/4] Even more flow table preliminaries Message-ID: <20240614131427.494638d0@elisabeth> In-Reply-To: <20240614015108.2761502-1-david@gibson.dropbear.id.au> References: <20240614015108.2761502-1-david@gibson.dropbear.id.au> Organization: Red Hat X-Mailer: Claws Mail 4.2.0 (GTK 3.24.41; x86_64-pc-linux-gnu) MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Message-ID-Hash: KCTXGFYJX4S4JJZECDP5SNDXCCNJNYV2 X-Message-ID-Hash: KCTXGFYJX4S4JJZECDP5SNDXCCNJNYV2 X-MailFrom: sbrivio@redhat.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: passt-dev@passt.top X-Mailman-Version: 3.3.8 Precedence: list List-Id: Development discussion and patches for passt Archived-At: Archived-At: List-Archive: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On Fri, 14 Jun 2024 11:51:04 +1000 David Gibson wrote: > I hoped that the last batch was the last, but I was wrong. Working on > UDP flow has shown up a few more things that make sense to do before > taking the leap into full flow table implementation. Here's what I > have so far, though there could be even more. > > Changes since v1: > * Assorted minor style and comment changes based on Stefano's review. > > David Gibson (4): > util: Split construction of bind socket address from the rest of > sock_l4() > udp: Fold checking of splice flag into udp_mmh_splice_port() > udp: Rework how we divide queued datagrams between sending methods > udp: Move management of udp[46]_localname into udp_splice_send() > > udp.c | 176 +++++++++++++++++++++++++++++++++------------------------ > util.c | 123 +++++++++++++++++++++++----------------- > 2 files changed, 171 insertions(+), 128 deletions(-) Applied. -- Stefano