From mboxrd@z Thu Jan 1 00:00:00 1970 Received: by passt.top (Postfix, from userid 1000) id 300D45A0050; Tue, 18 Jun 2024 09:14:27 +0200 (CEST) From: Stefano Brivio To: passt-dev@passt.top Subject: [PATCH v2 0/6] Fixes for early logging/prints and related cleanups Date: Tue, 18 Jun 2024 09:14:21 +0200 Message-ID: <20240618071427.1544869-1-sbrivio@redhat.com> X-Mailer: git-send-email 2.43.0 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Message-ID-Hash: K3PVW447DD7BCJ4DGVKWBXFYDHFIVCMW X-Message-ID-Hash: K3PVW447DD7BCJ4DGVKWBXFYDHFIVCMW X-MailFrom: sbrivio@passt.top X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: Yalan Zhang , David Gibson X-Mailman-Version: 3.3.8 Precedence: list List-Id: Development discussion and patches for passt Archived-At: Archived-At: List-Archive: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: The most apparent issue fixed by this series is the one from 3/6: with a log file configured, we wouldn't print to standard error anymore, during initialisation, which means that users such as libvirt lost the ability to report meaningful error messages that occurred during initialisation, in that case. v2: - turn flag bitmap into simple, separate boolean flags - move errno description after message in _perror() functions - make some of the old perror() messages more descriptive Stefano Brivio (6): conf, passt: Don't try to log to stderr after we close it conf, log: Instead of abusing log levels, add log_conf_parsed flag log, passt: Always print to stderr before initialisation is complete log: Add _perror() logging function variants treewide: Replace perror() calls with calls to logging functions treewide: Replace strerror() calls arch.c | 10 ++++---- conf.c | 45 ++++++++++++++++++---------------- fwd.c | 2 +- isolation.c | 46 +++++++++++++++-------------------- log.c | 49 +++++++++++++++++++++++++------------ log.h | 25 ++++++++++++++++--- netlink.c | 4 +-- passt.1 | 3 ++- passt.c | 70 +++++++++++++++++++++++------------------------------ pasta.c | 41 +++++++++++++++---------------- pcap.c | 8 +++--- tap.c | 14 +++++------ tcp.c | 24 ++++++------------ util.c | 12 ++++----- 14 files changed, 179 insertions(+), 174 deletions(-) -- 2.43.0