From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by passt.top (Postfix) with ESMTP id 2B4755A004F for ; Tue, 18 Jun 2024 08:03:20 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1718690599; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Rr7swSH8VySRYX3gCjraJ851Msw0TnWyfVal6mhFhx8=; b=QtaQIBNr6aXRXDPjjYGQ7o3ppo8KCxvoPSKqNyMjI4mX6itpC4Z7f7Ig6u5dBn45BRcI5k EiCSij3/RrAJfqt24C0+OmGq71PySjjOuku7o7O48Hrbe/sNYG6b7qP1qBheAJ4YUK3YH2 odX0tUkbz86KkRSDVJm+BzxyUtFwi/g= Received: from mail-qk1-f197.google.com (mail-qk1-f197.google.com [209.85.222.197]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-308-YwmWAdbPN16YTh5Qt2_5-A-1; Tue, 18 Jun 2024 02:03:17 -0400 X-MC-Unique: YwmWAdbPN16YTh5Qt2_5-A-1 Received: by mail-qk1-f197.google.com with SMTP id af79cd13be357-795570c215fso561398685a.2 for ; Mon, 17 Jun 2024 23:03:17 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1718690596; x=1719295396; h=content-transfer-encoding:mime-version:organization:references :in-reply-to:message-id:subject:cc:to:from:date:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=Rr7swSH8VySRYX3gCjraJ851Msw0TnWyfVal6mhFhx8=; b=neseUysmlMeHtqq/LyvD2J6SvxrOpT3aSxjbtsC+T8dBfvqpXwPtAB7D0BttNhzRTx Hj2RV5KX2ZUXP+H4/b2aW4qY89hyq95IeL/zzo769QUva5vJYMPUhNH37FiUp4s4tg5u ZBzQZ5izS9plYb9jP3y+R0e+0S6fqLQo/5ebckRD9Sm7+n8nmFWdqDY8sWRCRUvzwTwK opXq6cm4vvPlZzfMAOTg1HzkFvyn803s7BmO8BMQkaIcjPcnuC2uWKPj15vRfEQXiTUl o0Fv4N1wbDhnt8gTuME/nzPFqJ+NFmWK7uLmuaDWKin2hj1awX1fxD+S/ASggSdRKb05 BLGw== X-Gm-Message-State: AOJu0YwOCYCRif6A5dsV4XT9uu2/yqRSKxjTIs2qXRrTDld+oaICR1Q7 pCxFCaOy3e0aAhLpAcF+659DJXcHLjFvmKVKbBf10Tywo0vufCqOC/UvWIM9iNoHWinxcT9miMf /fiElMwOlOJLiaV7do7d5Uf7/QsqMB4GNTf8rGCCzK2pd8JNJyHjoiiSXVuL5 X-Received: by 2002:a05:620a:2494:b0:797:a96f:72ae with SMTP id af79cd13be357-798d23c51bbmr1436522485a.1.1718690596339; Mon, 17 Jun 2024 23:03:16 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFnjAAV311lMdiE62qhPboQS7A3kLxNrZYtr0t3YaN7wY7KYpJVMRkRvx/7LjgneIEEtbTu0A== X-Received: by 2002:a05:620a:2494:b0:797:a96f:72ae with SMTP id af79cd13be357-798d23c51bbmr1436520785a.1.1718690595876; Mon, 17 Jun 2024 23:03:15 -0700 (PDT) Received: from maya.cloud.tilaa.com (maya.cloud.tilaa.com. [164.138.29.33]) by smtp.gmail.com with ESMTPSA id af79cd13be357-798abe6c57esm486374885a.134.2024.06.17.23.03.14 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Mon, 17 Jun 2024 23:03:14 -0700 (PDT) Date: Tue, 18 Jun 2024 08:02:40 +0200 From: Stefano Brivio To: David Gibson Subject: Re: [PATCH 6/6] treewide: Replace strerror() calls Message-ID: <20240618080240.298b9429@elisabeth> In-Reply-To: References: <20240617120319.1206857-1-sbrivio@redhat.com> <20240617120319.1206857-7-sbrivio@redhat.com> Organization: Red Hat X-Mailer: Claws Mail 4.2.0 (GTK 3.24.41; x86_64-pc-linux-gnu) MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Message-ID-Hash: BLI75TCRPNQMSZOIYYE42EWQWY2UTEMS X-Message-ID-Hash: BLI75TCRPNQMSZOIYYE42EWQWY2UTEMS X-MailFrom: sbrivio@redhat.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: passt-dev@passt.top, Yalan Zhang X-Mailman-Version: 3.3.8 Precedence: list List-Id: Development discussion and patches for passt Archived-At: Archived-At: List-Archive: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On Tue, 18 Jun 2024 10:51:49 +1000 David Gibson wrote: > On Mon, Jun 17, 2024 at 02:03:19PM +0200, Stefano Brivio wrote: > > Now that we have logging functions embedding perror() functionality, > > we can make _some_ calls more terse by using them. In many places, > > the strerror() calls are still more convenient because, for example, > > they are used in flow debugging functions, or because the return code > > variable of interest is not 'errno'. > > > > Signed-off-by: Stefano Brivio > > Hrm, this also changes > What we were doing: > into > : What we were doing > > which I think is a weirder convention. Oops, that was not intended, I forgot to switch it back in 4/6 after some experiments. I'll fix this in 4/6. -- Stefano