public inbox for passt-dev@passt.top
 help / color / mirror / code / Atom feed
* [PATCH] siphash: Remove stale prototypes
@ 2024-06-19  2:59 David Gibson
  2024-06-19 14:03 ` Stefano Brivio
  0 siblings, 1 reply; 2+ messages in thread
From: David Gibson @ 2024-06-19  2:59 UTC (permalink / raw)
  To: Stefano Brivio, passt-dev; +Cc: David Gibson

In fc8f0f8c ("siphash: Use incremental rather than all-at-once siphash
functions") we removed the older interface to the SipHash implementation,
which took fixed sized blocks of data.  However, we forgot to remove the
prototypes for those functions, so do that now.

Fixes: fc8f0f8c ("siphash: Use incremental rather than all-at-once"...)

Signed-off-by: David Gibson <david@gibson.dropbear.id.au>
---
 siphash.h | 6 ------
 1 file changed, 6 deletions(-)

diff --git a/siphash.h b/siphash.h
index f966cdb0..a2ca2a99 100644
--- a/siphash.h
+++ b/siphash.h
@@ -115,10 +115,4 @@ static inline uint64_t siphash_final(struct siphash_state *state,
 	return state->v[0] ^ state->v[1] ^ state->v[2] ^ state->v[3];
 }
 
-uint64_t siphash_8b(const uint8_t *in, const uint64_t *k);
-uint64_t siphash_12b(const uint8_t *in, const uint64_t *k);
-uint64_t siphash_20b(const uint8_t *in, const uint64_t *k);
-uint64_t siphash_32b(const uint8_t *in, const uint64_t *k);
-uint64_t siphash_36b(const uint8_t *in, const uint64_t *k);
-
 #endif /* SIPHASH_H */
-- 
@@ -115,10 +115,4 @@ static inline uint64_t siphash_final(struct siphash_state *state,
 	return state->v[0] ^ state->v[1] ^ state->v[2] ^ state->v[3];
 }
 
-uint64_t siphash_8b(const uint8_t *in, const uint64_t *k);
-uint64_t siphash_12b(const uint8_t *in, const uint64_t *k);
-uint64_t siphash_20b(const uint8_t *in, const uint64_t *k);
-uint64_t siphash_32b(const uint8_t *in, const uint64_t *k);
-uint64_t siphash_36b(const uint8_t *in, const uint64_t *k);
-
 #endif /* SIPHASH_H */
-- 
2.45.2


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] siphash: Remove stale prototypes
  2024-06-19  2:59 [PATCH] siphash: Remove stale prototypes David Gibson
@ 2024-06-19 14:03 ` Stefano Brivio
  0 siblings, 0 replies; 2+ messages in thread
From: Stefano Brivio @ 2024-06-19 14:03 UTC (permalink / raw)
  To: David Gibson; +Cc: passt-dev

On Wed, 19 Jun 2024 12:59:06 +1000
David Gibson <david@gibson.dropbear.id.au> wrote:

> In fc8f0f8c ("siphash: Use incremental rather than all-at-once siphash
> functions") we removed the older interface to the SipHash implementation,
> which took fixed sized blocks of data.  However, we forgot to remove the
> prototypes for those functions, so do that now.
> 
> Fixes: fc8f0f8c ("siphash: Use incremental rather than all-at-once"...)
> 
> Signed-off-by: David Gibson <david@gibson.dropbear.id.au>

Applied.

-- 
Stefano


^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2024-06-19 14:04 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-06-19  2:59 [PATCH] siphash: Remove stale prototypes David Gibson
2024-06-19 14:03 ` Stefano Brivio

Code repositories for project(s) associated with this public inbox

	https://passt.top/passt

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for IMAP folder(s).