From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by passt.top (Postfix) with ESMTP id EA7075A004E for ; Wed, 19 Jun 2024 10:18:01 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1718785080; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=l9tVM+qPEpoNHMnt1bpYBz8e0FpFThagnDdrHGCIaaU=; b=aAceJRY/wqI7Wrdvnec3mo0vWcYX8RZniyn5tFYU+f3E3jTalqUx/WfT414cNShBeWkib9 JX9ACbqAYJVo92LEsTWuxQ0uSAbuQMuqglLzB15ag4diEWWNG9peaqTGpVCotd8nOCg2VU U3IKWc8VItrlNH+HFrBipY8TH8eRxag= Received: from mail-qk1-f199.google.com (mail-qk1-f199.google.com [209.85.222.199]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-447-9VC_xbdpOpm6UcB01zFYfw-1; Wed, 19 Jun 2024 04:17:59 -0400 X-MC-Unique: 9VC_xbdpOpm6UcB01zFYfw-1 Received: by mail-qk1-f199.google.com with SMTP id af79cd13be357-795589ae41fso950328385a.0 for ; Wed, 19 Jun 2024 01:17:59 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1718785079; x=1719389879; h=content-transfer-encoding:mime-version:organization:references :in-reply-to:message-id:subject:cc:to:from:date:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=l9tVM+qPEpoNHMnt1bpYBz8e0FpFThagnDdrHGCIaaU=; b=PDIyaqChWB7CBUU+XH+mUBzctCLQL79vaAcXUzfTue6VfVKIh+KNELmR+I7tv9XMiI qsDoty8NaD9pSEEeW0m4nEXlyBt1fXoBXCPJjCnmI8G6oeAyo3MLj9HwSHNBsQbCiGyi DAygZPEOsEeMpp42O8gFYO2XKG9mdFCf5+L2axqARIh47WY5q2mni5x6hIxV4rsyqryU fnmwLGdBTxiblNBZ7VfDyv610XbIG4Bavt2fqZML8weL7wVOEwituYZmSIRYMg221bvc ToU3Wr6+BfnRPxMdI4rsenJfR6lGYdSS1JqbTPJCmV/qbvjjvBSVTyJfcLkjz1PY7Oea nMiQ== X-Gm-Message-State: AOJu0YxkOFr2oTJRxYdGcyBLW92ZG7Igr1rxDfbZVhbsULFu2izR9hi7 nflsl1MqzPAKV3BFgpd6h/0oZRqPGvX72S8kpvdj74mHyX03ngZLvg7lsfGUmstmcavu5wowT8H aw4Wb9Kw6YC5xAO2xvVTi/dXXCO3ldjWzsIaAPZF5PtKL+2X0pw== X-Received: by 2002:a05:620a:24d4:b0:795:5f38:7de3 with SMTP id af79cd13be357-79bb3e1a4a2mr221017385a.6.1718785078882; Wed, 19 Jun 2024 01:17:58 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGRZmEYARZTygIam9RPjW+7tInJq0F+QFGm2JEjcJGZL5b8Bx5D8uro4UGfO0GJwgBvFZre3w== X-Received: by 2002:a05:620a:24d4:b0:795:5f38:7de3 with SMTP id af79cd13be357-79bb3e1a4a2mr221015585a.6.1718785078298; Wed, 19 Jun 2024 01:17:58 -0700 (PDT) Received: from maya.cloud.tilaa.com (maya.cloud.tilaa.com. [164.138.29.33]) by smtp.gmail.com with ESMTPSA id af79cd13be357-798abc105cfsm589724185a.81.2024.06.19.01.17.57 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Wed, 19 Jun 2024 01:17:57 -0700 (PDT) Date: Wed, 19 Jun 2024 10:17:21 +0200 From: Stefano Brivio To: David Gibson Subject: Re: [PATCH 3/6] log, passt: Always print to stderr before initialisation is complete Message-ID: <20240619101711.2ce52091@elisabeth> In-Reply-To: References: <20240617120319.1206857-1-sbrivio@redhat.com> <20240617120319.1206857-4-sbrivio@redhat.com> <20240618080131.0fe3d7be@elisabeth> Organization: Red Hat X-Mailer: Claws Mail 4.2.0 (GTK 3.24.41; x86_64-pc-linux-gnu) MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Message-ID-Hash: PVACQJQOTBP7GLAXLS2NLYYT57V7XMNM X-Message-ID-Hash: PVACQJQOTBP7GLAXLS2NLYYT57V7XMNM X-MailFrom: sbrivio@redhat.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: passt-dev@passt.top, Yalan Zhang X-Mailman-Version: 3.3.8 Precedence: list List-Id: Development discussion and patches for passt Archived-At: Archived-At: List-Archive: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On Wed, 19 Jun 2024 12:10:38 +1000 David Gibson wrote: > On Tue, Jun 18, 2024 at 08:01:31AM +0200, Stefano Brivio wrote: > > On Tue, 18 Jun 2024 10:44:20 +1000 > > David Gibson wrote: > > > > > On Mon, Jun 17, 2024 at 02:03:16PM +0200, Stefano Brivio wrote: > > > > After commit 15001b39ef1d ("conf: set the log level much earlier"), we > > > > had a phase during initialisation when messages wouldn't be printed to > > > > standard error anymore. > > > > > > > > Commit f67238aa864d ("passt, log: Call __openlog() earlier, log to > > > > stderr until we detach") fixed that, but only for the case where no > > > > log files are given. > > > > > > > > If a log file is configured, vlogmsg() will not call passt_vsyslog(), > > > > but during initialisation, LOG_PERROR is set, so to avoid duplicated > > > > prints (which would result from passt_vsyslog() printing to stderr), > > > > we don't call fprintf() from vlogmsg() either. > > > > > > > > This is getting a bit too complicated. Instead of abusing LOG_PERROR, > > > > define an internal logging flag that clearly represents that we're not > > > > done with the initialisation phase yet. > > > > > > > > If this flag is not set, make sure we always print to stderr, if the > > > > log mask matches. Then, set LOG_PERROR only as we set this internal > > > > flag, to make sure we don't duplicate messages. > > > > > > > > Reported-by: Yalan Zhang > > > > Signed-off-by: Stefano Brivio > > > > --- > > > > log.c | 4 +++- > > > > log.h | 1 + > > > > passt.1 | 3 ++- > > > > passt.c | 17 ++++++++++------- > > > > 4 files changed, 16 insertions(+), 9 deletions(-) > > > > > > > > diff --git a/log.c b/log.c > > > > index 3b5a1c6..939bb93 100644 > > > > --- a/log.c > > > > +++ b/log.c > > > > @@ -49,6 +49,7 @@ int log_trace; /* --trace mode enabled */ > > > > void vlogmsg(int pri, const char *format, va_list ap) > > > > { > > > > bool debug_print = (log_mask & LOG_MASK(LOG_DEBUG)) && log_file == -1; > > > > + bool before_daemon = !(log_flags & LOG_FLAG_DAEMON_READY); > > > > > > As in 2/6 would just a global bool be simpler than flags. > > > > > > > bool early_print = !(log_flags & LOG_FLAG_CONF_PARSED); > > > > struct timespec tp; > > > > > > > > @@ -71,7 +72,8 @@ void vlogmsg(int pri, const char *format, va_list ap) > > > > va_end(ap2); > > > > } > > > > > > > > - if (debug_print || (early_print && !(log_opt & LOG_PERROR))) { > > > > + if (debug_print || early_print || > > > > + (before_daemon && (log_mask & LOG_MASK(LOG_PRI(pri))))) { > > > > (void)vfprintf(stderr, format, ap); > > > > if (format[strlen(format)] != '\n') > > > > fprintf(stderr, "\n"); > > > > diff --git a/log.h b/log.h > > > > index 6a3224a..680baab 100644 > > > > --- a/log.h > > > > +++ b/log.h > > > > @@ -10,6 +10,7 @@ > > > > #include > > > > > > > > #define LOG_FLAG_CONF_PARSED BIT(0) /* We already parsed logging options */ > > > > +#define LOG_FLAG_DAEMON_READY BIT(1) /* Daemonised, or ready in foreground */ > > > > > > > > #define LOGFILE_SIZE_DEFAULT (1024 * 1024UL) > > > > #define LOGFILE_CUT_RATIO 30 /* When full, cut ~30% size */ > > > > diff --git a/passt.1 b/passt.1 > > > > index 3a23a43..31e528e 100644 > > > > --- a/passt.1 > > > > +++ b/passt.1 > > > > @@ -99,7 +99,8 @@ terminal, and to both system logger and standard error otherwise. > > > > > > > > .TP > > > > .BR \-l ", " \-\-log-file " " \fIPATH\fR > > > > -Log to file \fIPATH\fR, not to standard error, and not to the system logger. > > > > +Log to file \fIPATH\fR, not to standard error (once initialisation is complete), > > > > +and not to the system logger. > > > > > > IIUC when -l is set we'll log to the logfile _as well as_ stderr > > > before we daemonize. The description above doesn't exactly contradict > > > that, but seems to imply something different. > > > > Is that because "(once initialisation is complete)" doesn't clearly > > refer to "not to standard error"? > > Yes, or rather that it's not entirely clear it refers *only* to that > clause and not to the "Log to file" part at the beginning. > > > I could go with something slightly more verbose: > > > > Log to file \fIPATH\fR, not to standard error, and not to the system > > logger. > > > > During initialisation phase, that is, before forking to background, > > or before being ready for communication when running in foreground, > > messages are always printed to standard error as well. > > Hrm... so I want to say: > > Log to file PATH instead of to system logger. > > Which may not be totally accurate for the current behaviour... but > seems like it might be a sensible behaviour. That is, we typically > log to syslog, but -l replaces it with a logfile. Regardless of > which, under some circumstances we'll also log to stderr. No, not really: it's not regardless of that. If the log file is given, we don't want to log to standard error (once we're up and running) -- Stefano