public inbox for passt-dev@passt.top
 help / color / mirror / code / Atom feed
From: Stefano Brivio <sbrivio@redhat.com>
To: passt-dev@passt.top
Cc: Yalan Zhang <yalzhang@redhat.com>,
	David Gibson <david@gibson.dropbear.id.au>
Subject: [PATCH v5 9/9] log: Don't report syslog failures to stderr after initialisation
Date: Thu, 20 Jun 2024 18:15:18 +0200	[thread overview]
Message-ID: <20240620161518.142285-10-sbrivio@redhat.com> (raw)
In-Reply-To: <20240620161518.142285-1-sbrivio@redhat.com>

If we daemonised, we can't use standard error. If we didn't, it's
rather annoying to have all those messages on standard error anyway,
and kind of pointless too, as the messages we wanted to print were
printed to standard error anyway.

Signed-off-by: Stefano Brivio <sbrivio@redhat.com>
---
 log.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/log.c b/log.c
index a72b871..9ed6bc1 100644
--- a/log.c
+++ b/log.c
@@ -191,7 +191,7 @@ void passt_vsyslog(int pri, const char *format, va_list ap)
 	if (format[strlen(format)] != '\n')
 		n += snprintf(buf + n, BUFSIZ - n, "\n");
 
-	if (log_sock >= 0 && send(log_sock, buf, n, 0) != n)
+	if (log_sock >= 0 && send(log_sock, buf, n, 0) != n && !log_runtime)
 		fprintf(stderr, "Failed to send %i bytes to syslog\n", n);
 }
 
-- 
@@ -191,7 +191,7 @@ void passt_vsyslog(int pri, const char *format, va_list ap)
 	if (format[strlen(format)] != '\n')
 		n += snprintf(buf + n, BUFSIZ - n, "\n");
 
-	if (log_sock >= 0 && send(log_sock, buf, n, 0) != n)
+	if (log_sock >= 0 && send(log_sock, buf, n, 0) != n && !log_runtime)
 		fprintf(stderr, "Failed to send %i bytes to syslog\n", n);
 }
 
-- 
2.43.0


  parent reply	other threads:[~2024-06-20 16:15 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-06-20 16:15 [PATCH v5 0/9] Fixes for early logging/prints and related cleanups Stefano Brivio
2024-06-20 16:15 ` [PATCH v5 1/9] conf, passt: Don't try to log to stderr after we close it Stefano Brivio
2024-06-20 16:15 ` [PATCH v5 2/9] conf, passt: Make --stderr do nothing, and deprecate it Stefano Brivio
2024-06-20 16:15 ` [PATCH v5 3/9] conf, log: Instead of abusing log levels, add log_conf_parsed flag Stefano Brivio
2024-06-20 16:15 ` [PATCH v5 4/9] log, passt: Always print to stderr before initialisation is complete Stefano Brivio
2024-06-21  1:13   ` David Gibson
2024-06-20 16:15 ` [PATCH v5 5/9] log: Add _perror() logging function variants Stefano Brivio
2024-06-20 16:15 ` [PATCH v5 6/9] treewide: Replace perror() calls with calls to logging functions Stefano Brivio
2024-06-20 16:15 ` [PATCH v5 7/9] treewide: Replace strerror() calls Stefano Brivio
2024-06-20 16:15 ` [PATCH v5 8/9] conf, passt: Don't call __openlog() if a log file is used Stefano Brivio
2024-06-20 16:15 ` Stefano Brivio [this message]
2024-06-21  1:11   ` [PATCH v5 9/9] log: Don't report syslog failures to stderr after initialisation David Gibson
2024-06-21  1:17 ` [PATCH v5 0/9] Fixes for early logging/prints and related cleanups David Gibson
2024-06-21  9:33   ` Stefano Brivio
2024-06-24  5:32     ` David Gibson
2024-06-24  9:45       ` Stefano Brivio
2024-06-26  1:50         ` David Gibson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240620161518.142285-10-sbrivio@redhat.com \
    --to=sbrivio@redhat.com \
    --cc=david@gibson.dropbear.id.au \
    --cc=passt-dev@passt.top \
    --cc=yalzhang@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://passt.top/passt

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for IMAP folder(s).