From: Stefano Brivio <sbrivio@redhat.com>
To: passt-dev@passt.top
Cc: Yalan Zhang <yalzhang@redhat.com>,
David Gibson <david@gibson.dropbear.id.au>
Subject: [PATCH v5 1/9] conf, passt: Don't try to log to stderr after we close it
Date: Thu, 20 Jun 2024 18:15:10 +0200 [thread overview]
Message-ID: <20240620161518.142285-2-sbrivio@redhat.com> (raw)
In-Reply-To: <20240620161518.142285-1-sbrivio@redhat.com>
If we don't run in foreground, we close standard error as we
daemonise, so it makes no sense to check if the controlling terminal
is an interactive terminal or if --force-stderr was given, to decide
if we want to log to standard error.
Make --force-stderr depend on --foreground.
Signed-off-by: Stefano Brivio <sbrivio@redhat.com>
Reviewed-by: David Gibson <david@gibson.dropbear.id.au>
---
conf.c | 3 +++
passt.c | 2 +-
2 files changed, 4 insertions(+), 1 deletion(-)
diff --git a/conf.c b/conf.c
index 94b3ed6..dbdbb62 100644
--- a/conf.c
+++ b/conf.c
@@ -1693,6 +1693,9 @@ void conf(struct ctx *c, int argc, char **argv)
conf_ugid(runas, &uid, &gid);
+ if (!c->foreground && c->force_stderr)
+ die("Can't log to standard error if not running in foreground");
+
if (logfile) {
logfile_init(c->mode == MODE_PASTA ? "pasta" : "passt",
logfile, logsize);
diff --git a/passt.c b/passt.c
index a5e2c5a..aa9648a 100644
--- a/passt.c
+++ b/passt.c
@@ -302,7 +302,7 @@ int main(int argc, char **argv)
if (isolate_prefork(&c))
die("Failed to sandbox process, exiting");
- if (!c.force_stderr && !isatty(fileno(stderr)))
+ if (!c.foreground || (!c.force_stderr && !isatty(fileno(stderr))))
__openlog(log_name, 0, LOG_DAEMON);
if (!c.foreground)
--
@@ -302,7 +302,7 @@ int main(int argc, char **argv)
if (isolate_prefork(&c))
die("Failed to sandbox process, exiting");
- if (!c.force_stderr && !isatty(fileno(stderr)))
+ if (!c.foreground || (!c.force_stderr && !isatty(fileno(stderr))))
__openlog(log_name, 0, LOG_DAEMON);
if (!c.foreground)
--
2.43.0
next prev parent reply other threads:[~2024-06-20 16:15 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-20 16:15 [PATCH v5 0/9] Fixes for early logging/prints and related cleanups Stefano Brivio
2024-06-20 16:15 ` Stefano Brivio [this message]
2024-06-20 16:15 ` [PATCH v5 2/9] conf, passt: Make --stderr do nothing, and deprecate it Stefano Brivio
2024-06-20 16:15 ` [PATCH v5 3/9] conf, log: Instead of abusing log levels, add log_conf_parsed flag Stefano Brivio
2024-06-20 16:15 ` [PATCH v5 4/9] log, passt: Always print to stderr before initialisation is complete Stefano Brivio
2024-06-21 1:13 ` David Gibson
2024-06-20 16:15 ` [PATCH v5 5/9] log: Add _perror() logging function variants Stefano Brivio
2024-06-20 16:15 ` [PATCH v5 6/9] treewide: Replace perror() calls with calls to logging functions Stefano Brivio
2024-06-20 16:15 ` [PATCH v5 7/9] treewide: Replace strerror() calls Stefano Brivio
2024-06-20 16:15 ` [PATCH v5 8/9] conf, passt: Don't call __openlog() if a log file is used Stefano Brivio
2024-06-20 16:15 ` [PATCH v5 9/9] log: Don't report syslog failures to stderr after initialisation Stefano Brivio
2024-06-21 1:11 ` David Gibson
2024-06-21 1:17 ` [PATCH v5 0/9] Fixes for early logging/prints and related cleanups David Gibson
2024-06-21 9:33 ` Stefano Brivio
2024-06-24 5:32 ` David Gibson
2024-06-24 9:45 ` Stefano Brivio
2024-06-26 1:50 ` David Gibson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240620161518.142285-2-sbrivio@redhat.com \
--to=sbrivio@redhat.com \
--cc=david@gibson.dropbear.id.au \
--cc=passt-dev@passt.top \
--cc=yalzhang@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://passt.top/passt
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for IMAP folder(s).