From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by passt.top (Postfix) with ESMTP id 58E305A004E for ; Fri, 21 Jun 2024 11:56:38 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1718963797; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=lRtKK4EeNm82mKoDfvwFqFvRukFnI58DtuCWmPFF0ZI=; b=A0/fcW4E7y1j8XsnGYYawu+8DgppPm0Ou/i3C03s0Nva1x1Vme+JAeoCYBeiLMmj2iiWmU qvRtntUVotSh2RTXt2/Vq649OdLS5fNxx4DBZZWiU6vN6ZE4cGIUuuqGHL7vwnnsI73ucj 3a8P1oVNqkxrcxoD0Ehl9LcoI0JoLPg= Received: from mail-qk1-f199.google.com (mail-qk1-f199.google.com [209.85.222.199]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-282-Pb8zCYnONAC3RKHgGHEhrw-1; Fri, 21 Jun 2024 05:56:35 -0400 X-MC-Unique: Pb8zCYnONAC3RKHgGHEhrw-1 Received: by mail-qk1-f199.google.com with SMTP id af79cd13be357-795589ae41fso264438785a.0 for ; Fri, 21 Jun 2024 02:56:35 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1718963795; x=1719568595; h=content-transfer-encoding:mime-version:organization:references :in-reply-to:message-id:subject:cc:to:from:date:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=lRtKK4EeNm82mKoDfvwFqFvRukFnI58DtuCWmPFF0ZI=; b=oGJtBL4ZGFtRxJHHZLjmMGhYQuTZLmnbT8AEjd0jkzWit/vx6Ky9kXvqHiIVptL94Z cCFO+uwA3Ctv9S1nChKsKcoo/0/GWB56cOtlw0+TlamuD/+WMTpn1A2PihFxi4twMs7B gB38okQVISLYmOO2jWqsEdU2YnSPfJeJvux49sgK/tdlKFl+A3eLQkgiVLKV9qZii/ni brtv0V/4fBBIN+yQXOkW9JFXtwPrQL2uoeaGXBbAiHo9Q/3cxf3ynmaoFZ1Uc/wwTgiB obUD7gSPg/Prk1fE4Fy9Uawm6q+vbZOwB2jAOuocVAI7e0hngzliPPINPg/Ae7qBLge8 rCJw== X-Gm-Message-State: AOJu0YzSbs0Ud0a1W8Xmoav+tucRMAv3+f0ZWbePSnxBDYPu1tmWaKqs DjCvejDAtUyq3HFCzy0a49NdCaH/HZO/0f3qztGx2VWJYBeNM3O3z6ZbGZCXUqRV9mVkBqPC4wX 5gJHZw9Lu19YVQV3jCarCJBllzhNMFqyaXfO1k9fg+rXMEnt4mg== X-Received: by 2002:a05:620a:17a5:b0:797:5765:b842 with SMTP id af79cd13be357-79bb3ee5ab4mr881060185a.67.1718963794690; Fri, 21 Jun 2024 02:56:34 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGTtb2YzuwOjpRZgf8icP01iSOH++9sbROsvLkoH8EnJxD9YqT+l7ljCgKRlX0z8OV1zrGH6w== X-Received: by 2002:a05:620a:17a5:b0:797:5765:b842 with SMTP id af79cd13be357-79bb3ee5ab4mr881058385a.67.1718963794145; Fri, 21 Jun 2024 02:56:34 -0700 (PDT) Received: from maya.cloud.tilaa.com (maya.cloud.tilaa.com. [164.138.29.33]) by smtp.gmail.com with ESMTPSA id d75a77b69052e-444c2b6bb8fsm9090541cf.33.2024.06.21.02.56.33 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Fri, 21 Jun 2024 02:56:33 -0700 (PDT) Date: Fri, 21 Jun 2024 11:55:57 +0200 From: Stefano Brivio To: Paul Holzinger Subject: Re: [PATCH v3] conf: Accept duplicate and conflicting options, the last one wins Message-ID: <20240621115557.77bc013f@elisabeth> In-Reply-To: <7fb9bd35-9249-4a32-b3d2-bba5f3da475d@redhat.com> References: <20240620171921.179930-1-sbrivio@redhat.com> <7fb9bd35-9249-4a32-b3d2-bba5f3da475d@redhat.com> Organization: Red Hat X-Mailer: Claws Mail 4.2.0 (GTK 3.24.41; x86_64-pc-linux-gnu) MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Message-ID-Hash: PWTHHKKEURZ7YV4VOKQ4QC4DZ72IFFR3 X-Message-ID-Hash: PWTHHKKEURZ7YV4VOKQ4QC4DZ72IFFR3 X-MailFrom: sbrivio@redhat.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: passt-dev@passt.top, David Gibson X-Mailman-Version: 3.3.8 Precedence: list List-Id: Development discussion and patches for passt Archived-At: Archived-At: List-Archive: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On Fri, 21 Jun 2024 11:52:40 +0200 Paul Holzinger wrote: > On 20/06/2024 19:19, Stefano Brivio wrote: > > In multiple occasions, especially when passt(1) and pasta(1) are used > > in integrations such as the one with Podman, the ability to override > > earlier options on the command line with later one would have been > > convenient. > > > > Recently, to debug a number of issues happening with Podman, I would > > have liked to ask users to share a debug log by passing --debug as > > additional option, but pasta refuses --quiet (always passed by Podman) > > and --debug at the same time. > > > > On top of this, Podman lets users specify other pasta options in its > > containers.conf(5) file, as well as on the command line. > > > > The options from the configuration files are appended together with > > the ones from the command line, which makes it impossible for users to > > override options from the configuration file, if duplicated options > > are refused, unless Podman takes care of sorting them, which is > > clearly not sustainable. > > > > For --debug and --trace, somebody took care of this on Podman side at: > > https://github.com/containers/common/pull/2052 > > > > but this doesn't fix the issue with other options, and we'll have > > anyway older versions of Podman around, too. > > > > I think there's some value in telling users about duplicated or > > conflicting options, because that might reveal issues in integrations > > or accidental misconfigurations, but by now I'm fairly convinced that > > the downsides outweigh this. > > > > Drop checks about duplicate options and mutually exclusive ones. In > > some cases, we need to also undo a couple of initialisations caused > > by earlier options, but this looks like a simplification, overall. > > > > Notable exception: --stderr still conflicts with --log-file, because > > users might have the expectation that they don't actually conflict. > > But they do conflict in the existing implementation, so it's safer > > to make sure that the users notice that. > > > > Suggested-by: Paul Holzinger > > Suggested-by: David Gibson > > Signed-off-by: Stefano Brivio > > Tested-by: Paul Holzinger Thanks! > > --- > > v3: > > - override --gateway and --dns-forward with the last given option > > for a given address family, too > assuming you mean --address here as --gateway already worked ...right, no idea why I wrote 'gateway'. :) -- Stefano