From: Stefano Brivio <sbrivio@redhat.com>
To: passt-dev@passt.top
Cc: Laurent Jacquot <jk@lutty.net>,
David Gibson <david@gibson.dropbear.id.au>
Subject: [PATCH 2/2] udp: Reduce scope of rport in udp_invert_portmap()
Date: Fri, 21 Jun 2024 17:53:23 +0200 [thread overview]
Message-ID: <20240621155323.1313483-3-sbrivio@redhat.com> (raw)
In-Reply-To: <20240621155323.1313483-1-sbrivio@redhat.com>
cppcheck 2.14 warns that the scope of the rport variable could be
reduced: do that, as reverted commit c80fa6a6bb44 ("udp: Make rport
calculation more local") did, but keep the temporary variable of
in_port_t type, otherwise the sum gets promoted to int.
Reported-by: David Gibson <david@gibson.dropbear.id.au>
Signed-off-by: Stefano Brivio <sbrivio@redhat.com>
---
udp.c | 6 ++++--
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/udp.c b/udp.c
index 8181900..a854323 100644
--- a/udp.c
+++ b/udp.c
@@ -279,10 +279,12 @@ static void udp_invert_portmap(struct udp_fwd_ports *fwd)
"Forward and reverse delta arrays must have same size");
for (i = 0; i < ARRAY_SIZE(fwd->f.delta); i++) {
in_port_t delta = fwd->f.delta[i];
- in_port_t rport = i + delta;
- if (delta)
+ if (delta) {
+ in_port_t rport = i + delta;
+
fwd->rdelta[rport] = NUM_PORTS - delta;
+ }
}
}
--
@@ -279,10 +279,12 @@ static void udp_invert_portmap(struct udp_fwd_ports *fwd)
"Forward and reverse delta arrays must have same size");
for (i = 0; i < ARRAY_SIZE(fwd->f.delta); i++) {
in_port_t delta = fwd->f.delta[i];
- in_port_t rport = i + delta;
- if (delta)
+ if (delta) {
+ in_port_t rport = i + delta;
+
fwd->rdelta[rport] = NUM_PORTS - delta;
+ }
}
}
--
2.43.0
next prev parent reply other threads:[~2024-06-21 15:53 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-21 15:53 [PATCH 0/2] Fix bug #80 again Stefano Brivio
2024-06-21 15:53 ` [PATCH 1/2] Revert "udp: Make rport calculation more local" Stefano Brivio
2024-06-24 1:20 ` David Gibson
2024-06-24 19:08 ` Stefano Brivio
2024-06-21 15:53 ` Stefano Brivio [this message]
2024-06-24 1:21 ` [PATCH 2/2] udp: Reduce scope of rport in udp_invert_portmap() David Gibson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240621155323.1313483-3-sbrivio@redhat.com \
--to=sbrivio@redhat.com \
--cc=david@gibson.dropbear.id.au \
--cc=jk@lutty.net \
--cc=passt-dev@passt.top \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://passt.top/passt
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for IMAP folder(s).