public inbox for passt-dev@passt.top
 help / color / mirror / code / Atom feed
From: Stefano Brivio <sbrivio@redhat.com>
To: David Gibson <david@gibson.dropbear.id.au>
Cc: passt-dev@passt.top, Yalan Zhang <yalzhang@redhat.com>
Subject: Re: [PATCH v5 0/9] Fixes for early logging/prints and related cleanups
Date: Mon, 24 Jun 2024 11:45:32 +0200	[thread overview]
Message-ID: <20240624114521.45638044@elisabeth> (raw)
In-Reply-To: <ZnkE5HqqvTmDrOyw@zatzit>

On Mon, 24 Jun 2024 15:32:20 +1000
David Gibson <david@gibson.dropbear.id.au> wrote:

> On Fri, Jun 21, 2024 at 11:33:55AM +0200, Stefano Brivio wrote:
> > On Fri, 21 Jun 2024 11:17:34 +1000
> > David Gibson <david@gibson.dropbear.id.au> wrote:
> >   
> > > On Thu, Jun 20, 2024 at 06:15:09PM +0200, Stefano Brivio wrote:  
> > > > The most apparent issue fixed by this series is the one from 4/6: with
> > > > a log file configured, we wouldn't print to standard error anymore,
> > > > during initialisation, which means that users such as libvirt lost
> > > > the ability to report meaningful error messages that occurred during
> > > > initialisation, in that case.
> > > > 
> > > > v5:
> > > > - in 4/8, rename the new flag once more to 'log_runtime': we don't
> > > >   want to log to standard error if we're running in foreground, a
> > > >   log file is given, and initialisation is done, otherwise debugging
> > > >   pasta when it spawns its own shell becomes rather impractical    
> > > 
> > > Ah.. right.  See, I still think the semantics of always printing to
> > > stderr when foreground make more sense, but I guess I do see the point
> > > that having pasta messages appear in your pasta-spawned shell is ugly.
> > > 
> > > My preferred approach for that would to keep the basic semantics that
> > > we always log to stderr when foreground, but when we're spawning a
> > > pasta shell we default to 'quiet' log level.  That way if you really
> > > do want messages to stderr along with your shell/command (which I
> > > sometimes do), you can get that by using --debug or whatever.  
> > 
> > That's already the default, see pasta_start_ns():
> > 
> > 	if (!c->debug)
> > 		c->quiet = 1;
> > 
> > the problem is that if you want to debug something, and use a pasta
> > shell (which is the most indicated way to debug something in most
> > cases, I would say), you would usually pass --debug and a log file.  
> 
> Oh... good point.
> 
> > Before and after this series (v5, but not v4), if you pass a log file,
> > that debug output stays in the log file.
> > 
> > If you don't give a log file, debug information will printed to stderr
> > as usual.  
> 
> I understand the choice in the short term, but this still doesn't feel
> quite right to me.
> 
> I'm wondering if we should treat spawning a a pasta command as though
> we're going into the background.  It's not in the Unix technical
> sense, but it is going to the background in the loose sense that pasta
> is no longer the thing that the user is primarily looking at on this
> terminal.
> 
> But then, it would be nice to have a way to force output to stderr
> even with a pasta command - I find that pretty useful when debugging a
> specific problem, particularly when using a specific command rather
> than a shell.  Maybe we could allow "-l -" or "-l stderr" or something
> with a special meaning?

But that's already the case if you give --debug (or --trace) but no log
file, isn't that enough?

-- 
Stefano


  reply	other threads:[~2024-06-24  9:46 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-06-20 16:15 [PATCH v5 0/9] Fixes for early logging/prints and related cleanups Stefano Brivio
2024-06-20 16:15 ` [PATCH v5 1/9] conf, passt: Don't try to log to stderr after we close it Stefano Brivio
2024-06-20 16:15 ` [PATCH v5 2/9] conf, passt: Make --stderr do nothing, and deprecate it Stefano Brivio
2024-06-20 16:15 ` [PATCH v5 3/9] conf, log: Instead of abusing log levels, add log_conf_parsed flag Stefano Brivio
2024-06-20 16:15 ` [PATCH v5 4/9] log, passt: Always print to stderr before initialisation is complete Stefano Brivio
2024-06-21  1:13   ` David Gibson
2024-06-20 16:15 ` [PATCH v5 5/9] log: Add _perror() logging function variants Stefano Brivio
2024-06-20 16:15 ` [PATCH v5 6/9] treewide: Replace perror() calls with calls to logging functions Stefano Brivio
2024-06-20 16:15 ` [PATCH v5 7/9] treewide: Replace strerror() calls Stefano Brivio
2024-06-20 16:15 ` [PATCH v5 8/9] conf, passt: Don't call __openlog() if a log file is used Stefano Brivio
2024-06-20 16:15 ` [PATCH v5 9/9] log: Don't report syslog failures to stderr after initialisation Stefano Brivio
2024-06-21  1:11   ` David Gibson
2024-06-21  1:17 ` [PATCH v5 0/9] Fixes for early logging/prints and related cleanups David Gibson
2024-06-21  9:33   ` Stefano Brivio
2024-06-24  5:32     ` David Gibson
2024-06-24  9:45       ` Stefano Brivio [this message]
2024-06-26  1:50         ` David Gibson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240624114521.45638044@elisabeth \
    --to=sbrivio@redhat.com \
    --cc=david@gibson.dropbear.id.au \
    --cc=passt-dev@passt.top \
    --cc=yalzhang@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://passt.top/passt

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for IMAP folder(s).