public inbox for passt-dev@passt.top
 help / color / mirror / code / Atom feed
From: Stefano Brivio <sbrivio@redhat.com>
To: David Gibson <david@gibson.dropbear.id.au>
Cc: passt-dev@passt.top, Laurent Jacquot <jk@lutty.net>
Subject: Re: [PATCH 1/2] Revert "udp: Make rport calculation more local"
Date: Mon, 24 Jun 2024 21:08:59 +0200	[thread overview]
Message-ID: <20240624210850.2e9ade21@elisabeth> (raw)
In-Reply-To: <ZnjJ8BBfWJmQbCbE@zatzit>

On Mon, 24 Jun 2024 11:20:48 +1000
David Gibson <david@gibson.dropbear.id.au> wrote:

> On Fri, Jun 21, 2024 at 05:53:22PM +0200, Stefano Brivio wrote:
> > This reverts commit c80fa6a6bb4415ad48f9e11424310875d0d99bc7, as it
> > reintroduces the issue fixed by commit 1e6f92b995a9 ("udp: Fix 16-bit
> > overflow in udp_invert_portmap()").
> > 
> > Reported-by: Laurent Jacquot <jk@lutty.net>
> > Link: https://bugs.passt.top/show_bug.cgi?id=80
> > Signed-off-by: Stefano Brivio <sbrivio@redhat.com>  
> 
> Argh, dammit.  So,
> 
> Reviewed-by: David Gibson <david@gibson.dropbear.id.au>
> 
> .. but I think we really need to put a comment on this, otherwise one
> of us is likely to make the same mistake again, because that
> particular promotion rule is truly arcane.

Pushed with a comment (part of commit for 2/2), I hope it's clear
enough now.

-- 
Stefano


  reply	other threads:[~2024-06-24 19:09 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-06-21 15:53 [PATCH 0/2] Fix bug #80 again Stefano Brivio
2024-06-21 15:53 ` [PATCH 1/2] Revert "udp: Make rport calculation more local" Stefano Brivio
2024-06-24  1:20   ` David Gibson
2024-06-24 19:08     ` Stefano Brivio [this message]
2024-06-21 15:53 ` [PATCH 2/2] udp: Reduce scope of rport in udp_invert_portmap() Stefano Brivio
2024-06-24  1:21   ` David Gibson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240624210850.2e9ade21@elisabeth \
    --to=sbrivio@redhat.com \
    --cc=david@gibson.dropbear.id.au \
    --cc=jk@lutty.net \
    --cc=passt-dev@passt.top \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://passt.top/passt

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for IMAP folder(s).