From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by passt.top (Postfix) with ESMTP id 302865A004F for ; Mon, 24 Jun 2024 21:09:45 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1719256183; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=syJhPfutcKx88M3eTcb9ZW6dXLa0tUjEfMYSYp5lNiE=; b=gqH7P41CBtjAK41yvX2HpJN9D45iDgJnZ8+slbd5QJ2NeQ6NeJajN8f9XxKD17FQzaa5NI Q7g59d8qyMFGEIMCb5GfyVpivp0oEt37/D/PCa1/rJjS7m3q8kqHDppo29LI+9Q70Q+WVT mLFhz+WPx9QPjhPQqXWpG++EWzvCOB0= Received: from mail-qk1-f198.google.com (mail-qk1-f198.google.com [209.85.222.198]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-294-6SYi859BPZuCjVBWr4j_pg-1; Mon, 24 Jun 2024 15:09:38 -0400 X-MC-Unique: 6SYi859BPZuCjVBWr4j_pg-1 Received: by mail-qk1-f198.google.com with SMTP id af79cd13be357-795552a7215so801044185a.2 for ; Mon, 24 Jun 2024 12:09:38 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1719256176; x=1719860976; h=content-transfer-encoding:mime-version:organization:references :in-reply-to:message-id:subject:cc:to:from:date:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=syJhPfutcKx88M3eTcb9ZW6dXLa0tUjEfMYSYp5lNiE=; b=ZbYuvn+bn2KqOWUqFf3dd7lMrrQiUUhC1VGf3YR3viS/9nuiCLEEjPDV10SLCpDzi6 eq+iue2Uj2dxEAWJENtoXp+69lXD34J5dAtCPzmAkoZQ0jq+hpPddBqM6O9TYokkFeaX 1VSv3MwtJcMUVKz5q4S2k/hNCw6GoIQDp826o6EN5FtcBoCxRlHPq5XKZ05DEVpDBXFR piyINFfw93Utm7NoyVsGnuyjuHzIsw4Xqmum2lW0rDbaJc8XsdwnRpJjqbBeL5p/COvc ztijkSlhmopSV6kSC8nDJW75Vo7FT2S283IKaEXtt2G6ks0msBSS6AkMB6ls0kGJGTzN AoEw== X-Gm-Message-State: AOJu0Yx6IytQt4gxTF5Wz+Z5a5ci6tLRnNTjMj2oiJGjYof46mO/byLt aoGU5SqHqCd1RMpfmpKoM6gsgyTcm7LxI4ed7b9hyeAXPsbk/+SJLt/ohXpShI6NyjlHIVA/cKG yfyBW0UKfUgoZGdyePOArUyhL/MrHhK5h+1ll5dyRGxxtCJnQHN+Ghe5HqMdB X-Received: by 2002:a05:6214:8b:b0:6b5:4573:4ac5 with SMTP id 6a1803df08f44-6b545734d10mr52054616d6.45.1719256176495; Mon, 24 Jun 2024 12:09:36 -0700 (PDT) X-Google-Smtp-Source: AGHT+IEyy+VULgpD2w7cQVP8r3bV7RitcaaKRNvnwP2VTnQa0zfMhcusLX8WDdT3ODSNAGWwRHKZmQ== X-Received: by 2002:a05:6214:8b:b0:6b5:4573:4ac5 with SMTP id 6a1803df08f44-6b545734d10mr52054366d6.45.1719256175989; Mon, 24 Jun 2024 12:09:35 -0700 (PDT) Received: from maya.cloud.tilaa.com (maya.cloud.tilaa.com. [164.138.29.33]) by smtp.gmail.com with ESMTPSA id 6a1803df08f44-6b51ef64c81sm37063116d6.123.2024.06.24.12.09.35 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Mon, 24 Jun 2024 12:09:35 -0700 (PDT) Date: Mon, 24 Jun 2024 21:08:59 +0200 From: Stefano Brivio To: David Gibson Subject: Re: [PATCH 1/2] Revert "udp: Make rport calculation more local" Message-ID: <20240624210850.2e9ade21@elisabeth> In-Reply-To: References: <20240621155323.1313483-1-sbrivio@redhat.com> <20240621155323.1313483-2-sbrivio@redhat.com> Organization: Red Hat X-Mailer: Claws Mail 4.2.0 (GTK 3.24.41; x86_64-pc-linux-gnu) MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Message-ID-Hash: 7UZXNZYG65ZMEQFTNTZYJ62FGUBKNYDF X-Message-ID-Hash: 7UZXNZYG65ZMEQFTNTZYJ62FGUBKNYDF X-MailFrom: sbrivio@redhat.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: passt-dev@passt.top, Laurent Jacquot X-Mailman-Version: 3.3.8 Precedence: list List-Id: Development discussion and patches for passt Archived-At: Archived-At: List-Archive: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On Mon, 24 Jun 2024 11:20:48 +1000 David Gibson wrote: > On Fri, Jun 21, 2024 at 05:53:22PM +0200, Stefano Brivio wrote: > > This reverts commit c80fa6a6bb4415ad48f9e11424310875d0d99bc7, as it > > reintroduces the issue fixed by commit 1e6f92b995a9 ("udp: Fix 16-bit > > overflow in udp_invert_portmap()"). > > > > Reported-by: Laurent Jacquot > > Link: https://bugs.passt.top/show_bug.cgi?id=80 > > Signed-off-by: Stefano Brivio > > Argh, dammit. So, > > Reviewed-by: David Gibson > > .. but I think we really need to put a comment on this, otherwise one > of us is likely to make the same mistake again, because that > particular promotion rule is truly arcane. Pushed with a comment (part of commit for 2/2), I hope it's clear enough now. -- Stefano