From: Stefano Brivio <sbrivio@redhat.com>
To: Danish Prakash <contact@danishpraka.sh>
Cc: passt-dev@passt.top
Subject: Re: [PATCH] pasta.c: modify hostname when detaching new namespace
Date: Wed, 26 Jun 2024 00:27:52 +0200 [thread overview]
Message-ID: <20240626002752.42cbd065@elisabeth> (raw)
In-Reply-To: <20240524193918.151fd2fc@elisabeth>
Hi Danish,
On Fri, 24 May 2024 19:39:18 +0200
Stefano Brivio <sbrivio@redhat.com> wrote:
> On Fri, 24 May 2024 18:18:53 +0530
> Danish Prakash <contact@danishpraka.sh> wrote:
>
> > When invoking pasta without any arguments, it's difficult
> > to tell whether we are in the new namespace or not leaving
> > users a bit confused. This change modifies the host namespace
> > to add a prefix "pasta-" to make it a bit more obvious.
> >
> > Signed-off-by: Danish Prakash <contact@danishpraka.sh>
> > ---
> > pasta.c | 9 +++++++++
> > 1 file changed, 9 insertions(+)
> >
> > diff --git a/pasta.c b/pasta.c
> > index 31e1e00..90afd74 100644
> > --- a/pasta.c
> > +++ b/pasta.c
> > @@ -50,6 +50,8 @@
> > #include "netlink.h"
> > #include "log.h"
> >
> > +#define HOSTNAME_PREFIX "pasta-"
> > +
> > /* PID of child, in case we created a namespace */
> > int pasta_child_pid;
> >
> > @@ -178,6 +180,7 @@ struct pasta_spawn_cmd_arg {
> > */
> > static int pasta_spawn_cmd(void *arg)
> > {
> > + char hostname[HOST_NAME_MAX + 1] = HOSTNAME_PREFIX;
> > const struct pasta_spawn_cmd_arg *a;
> > sigset_t set;
> >
> > @@ -188,6 +191,12 @@ static int pasta_spawn_cmd(void *arg)
> > if (write_file("/proc/sys/net/ipv4/ping_group_range", "0 0"))
> > warn("Cannot set ping_group_range, ICMP requests might fail");
> >
> > + if (!gethostname(hostname + sizeof(HOSTNAME_PREFIX) - 1, HOST_NAME_MAX + 1 - sizeof(HOSTNAME_PREFIX)) ||
>
> Following the Linux kernel coding style also means we try to stick into
> 80 columns where possible:
>
> https://www.kernel.org/doc/html/latest/process/coding-style.html#breaking-long-lines-and-strings
>
> ...so there was a reason why I proposed this line like I did, with the
> line splits. These subtleties, I can also fix them up on merge.
>
> > + errno == ENAMETOOLONG ) {
>
> Excess whitespace between ENAMETOOLONG and ). Same here, I would fix
> this up on merge.
>
> > + if (sethostname(hostname, strlen(hostname)))
>
> So, I mentioned before that you don't really need to set a NULL
> terminating byte for sethostname() itself, because it takes a length.
>
> But strlen() needs it. If gethostname() truncated the hostname,
> according to POSIX, it's unspecified whether we'll have a NULL byte at
> the end of 'hostname', and strlen() would read out-of-bounds, past the
> end of 'hostname'.
>
> That's not an issue with glibc, but if POSIX says it's not guaranteed,
> we shouldn't take anything for granted.
>
> I would suggest that you simply add a NULL byte at HOST_NAME_MAX,
> unconditionally, that should cover the normal case as well as the
> ENAMETOOLONG case. I haven't tested this by the way.
>
> > + warn("Unable to set pasta-prefixed hostname");
> > + }
> > +
> > /* Wait for the parent to be ready: see main() */
> > sigemptyset(&set);
> > sigaddset(&set, SIGUSR1);
>
I didn't get any follow up on this patch. Did you actually mean to
abandon it?
If you prefer, I can also pick it up from there.
--
Stefano
next prev parent reply other threads:[~2024-06-25 22:28 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-20 8:35 [PATCH] pasta.c: modify hostname when detaching new namespace Danish Prakash
[not found] ` <20240521193400.4f1b15c5@elisabeth>
2024-05-23 13:52 ` Danish Prakash
2024-05-23 14:23 ` Stefano Brivio
2024-05-24 12:45 ` Danish Prakash
2024-05-24 17:38 ` Stefano Brivio
2024-05-24 12:48 ` Danish Prakash
2024-05-24 17:39 ` Stefano Brivio
2024-06-25 22:27 ` Stefano Brivio [this message]
2024-07-29 13:56 ` Danish Prakash
2024-07-29 17:54 ` Stefano Brivio
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240626002752.42cbd065@elisabeth \
--to=sbrivio@redhat.com \
--cc=contact@danishpraka.sh \
--cc=passt-dev@passt.top \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://passt.top/passt
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for IMAP folder(s).