From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by passt.top (Postfix) with ESMTP id 5750B5A004F for ; Thu, 04 Jul 2024 23:21:32 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1720128091; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=ukukLNFN3zXlRZFSnbBVkflteAk52u/nzMxp1arTaT0=; b=MIupD8RadVXhCHBOhb+EesSHiroC6MPFY6raKsSWUP0vDITzoSy8TA8tSjT8nnDMyJIOXH eDb/DccVq21wQaU1U6901Yem6tcqSE8nRn9K5W1w8D2iytGb8mKhOUVCneAghCUXcXIkqX /jB4+CZz5GzsGM/pj6j7Jz9Q4KbXCNc= Received: from mail-qv1-f69.google.com (mail-qv1-f69.google.com [209.85.219.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-613-UR4xcxS1Nzy_px6-1tz-rw-1; Thu, 04 Jul 2024 17:21:29 -0400 X-MC-Unique: UR4xcxS1Nzy_px6-1tz-rw-1 Received: by mail-qv1-f69.google.com with SMTP id 6a1803df08f44-6b5e847d4a1so13249136d6.1 for ; Thu, 04 Jul 2024 14:21:29 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1720128088; x=1720732888; h=content-transfer-encoding:mime-version:organization:references :in-reply-to:message-id:subject:cc:to:from:date:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=ukukLNFN3zXlRZFSnbBVkflteAk52u/nzMxp1arTaT0=; b=hHMP++iDbsixfOrB/5gU/cFoIZN30goBQkxUi3I4acmuvS73EQPJlIkT/7mlVwzzjW jjTu5N6/yKUA/7B6sP7ea3/kWhmPabwVblUUGUhCwfB7l3zHZkvEADHGXIvpGJhqkVID xR/2eNzHXQ0ldLgD156UFMvbOS172cxslqxifM+CbwebHfqNJ6Q2wFk9h02uDq1mq35V AsYMcb230NINWm4AG9rHi7mXsEVUKr93TBkr4eqJSUhGSYcbB4hkpgMnuKvz7qSGkQEQ YoL1RtY5bJb0vxffcK4czGT/hUARjdwSPicpkphCAd4ad56QcFOra/tRKZmd3Ar40Ldr nFUg== X-Gm-Message-State: AOJu0YzoU4Iz5MxVs0HzoXmfSnT2eg42ljQU0MTKG7po5O2GmSe1aZIF rmpwwkfocyIfz6SVIyNRyD1C4HdThRlA2+OFNBeqn08gimTo1UEeT8XyXEh69qdU3yRZPF/aq8Y uOTkhMDYrn04jX5gtznYhsH0enowBRRu7spylbhCAvUzgREY05fw7D9Bg/hwF X-Received: by 2002:a05:6214:1bcb:b0:6b5:e06b:4025 with SMTP id 6a1803df08f44-6b5ed0061cdmr29496626d6.25.1720128088560; Thu, 04 Jul 2024 14:21:28 -0700 (PDT) X-Google-Smtp-Source: AGHT+IF9hnSA3jYPluZxxg54KALTL9KeBxiF/wPwGd1vS2QkcAUE30uzdJ5pKZ6+d/G1u01Y5tubwA== X-Received: by 2002:a05:6214:1bcb:b0:6b5:e06b:4025 with SMTP id 6a1803df08f44-6b5ed0061cdmr29496496d6.25.1720128088292; Thu, 04 Jul 2024 14:21:28 -0700 (PDT) Received: from maya.cloud.tilaa.com (maya.cloud.tilaa.com. [164.138.29.33]) by smtp.gmail.com with ESMTPSA id 6a1803df08f44-6b5f0c0809asm5627546d6.108.2024.07.04.14.21.27 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Thu, 04 Jul 2024 14:21:27 -0700 (PDT) Date: Thu, 4 Jul 2024 23:20:53 +0200 From: Stefano Brivio To: David Gibson Subject: Re: [PATCH 04/11] udp: Rename IOV and mmsghdr arrays Message-ID: <20240704232053.2e7c735d@elisabeth> In-Reply-To: <20240704045835.1149746-5-david@gibson.dropbear.id.au> References: <20240704045835.1149746-1-david@gibson.dropbear.id.au> <20240704045835.1149746-5-david@gibson.dropbear.id.au> Organization: Red Hat X-Mailer: Claws Mail 4.2.0 (GTK 3.24.41; x86_64-pc-linux-gnu) MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Message-ID-Hash: CDNVXLR2YPJCC6AV5NZMZ6USDSWKCVX7 X-Message-ID-Hash: CDNVXLR2YPJCC6AV5NZMZ6USDSWKCVX7 X-MailFrom: sbrivio@redhat.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: passt-dev@passt.top X-Mailman-Version: 3.3.8 Precedence: list List-Id: Development discussion and patches for passt Archived-At: Archived-At: List-Archive: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On Thu, 4 Jul 2024 14:58:28 +1000 David Gibson wrote: > Make the salient points about these various arrays clearer with renames: > > * udp_l2_iov_sock and udp[46]_l2_mh_sock don't really have anything to do > with L2. The original idea behind that 'l2' there was to have the type of destination in the name first, and then the source ('sock'). On the other hand, they're actually clearer this way. > They are, however, specific to receiving not sending not receiving. I failed to decrypt this one. :) > Rename to udp_iov_recv and udp[46]_mh_recv. > > * udp[46]_l2_iov_tap is redundant - "tap" implies L2 and vice versa. > Rename to udp[46]_l2_iov > > * udp[46]_localname are (for now) pre-populated with the locan address > but the more salient point is that these are the destination address for > the splice arrays. Rename to udp[46]_spliceto Very slight preference (but not worth a lot of changes, in case): udp[46]_splice_to. To me it's not immediately obvious those are two words otherwise. -- Stefano