[PATCH] doc: Trivial fix for reuseaddr-priority

[PATCH] doc: Trivial fix for reuseaddr-priority

[David Gibson]

This test program checks for particular behaviour regardless of order of
operations.  So, we step through the test with all possible orders for
a number of different of parts.  Or at least, we're supposed to, a copy
pasta error led to using the same order for two things which should be
independent.

Fixes: 299c40750 ("doc: Add program to document and test assumptions...")

Reported-by: David Taylor <davidt@yadt.co.uk>
Signed-off-by: David Gibson <david@gibson.dropbear.id.au>
---
 doc/platform-requirements/reuseaddr-priority.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/doc/platform-requirements/reuseaddr-priority.c b/doc/platform-requirements/reuseaddr-priority.c
index 644553f8..701b6fff 100644
--- a/doc/platform-requirements/reuseaddr-priority.c
+++ b/doc/platform-requirements/reuseaddr-priority.c
@@ -222,7 +222,7 @@ static void check_all_orders(void)
 			for (k = 0; k < norders; k++)
 				for (l = 0; l < norders; l++)
 					check_one_order(orders[i], orders[j],
-							orders[j], orders[l]);
+							orders[k], orders[l]);
 }
 
 int main(int argc, char *argv[])
-- 
@@ -222,7 +222,7 @@ static void check_all_orders(void)
 			for (k = 0; k < norders; k++)
 				for (l = 0; l < norders; l++)
 					check_one_order(orders[i], orders[j],
-							orders[j], orders[l]);
+							orders[k], orders[l]);
 }
 
 int main(int argc, char *argv[])
-- 
2.45.2

Re: [PATCH] doc: Trivial fix for reuseaddr-priority

[Stefano Brivio]

On Mon, 15 Jul 2024 10:43:07 +1000
David Gibson <david@gibson.dropbear.id.au> wrote:

> This test program checks for particular behaviour regardless of order of
> operations.  So, we step through the test with all possible orders for
> a number of different of parts.  Or at least, we're supposed to, a copy
> pasta error led to using the same order for two things which should be
> independent.
> 
> Fixes: 299c40750 ("doc: Add program to document and test assumptions...")

By the way, I'm using this snippet to check those (yeah I guess I should
submit it for scripts/ one day...), in case you want to recycle it:
  https://lore.kernel.org/all/20190220213729.49deb54f@redhat.com/

and to build the tag just the:
  git show -s --abbrev=12 --pretty=format:"Fixes: %h (\"%s\")" "${sha}" 2>/dev/null

part.

> Reported-by: David Taylor <davidt@yadt.co.uk>
> Signed-off-by: David Gibson <david@gibson.dropbear.id.au>

Applied.

-- 
Stefano