From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail.ozlabs.org (mail.ozlabs.org [IPv6:2404:9400:2221:ea00::3]) by passt.top (Postfix) with ESMTPS id 6C9615A031D for ; Tue, 16 Jul 2024 07:29:47 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gibson.dropbear.id.au; s=202312; t=1721107778; bh=CN9Ti1fvwNzThXce0LiHfzizWZCG9QrdB5XPW4d4mZY=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=dW2MuE9SGzltt8Kacks7p9uPLDeC9lpKbck7hpLc3kgn5Gt3MEH2jmcxOZDRCGmUs WWZ2RlrzCwAW53lOGSC6TjH/PU9LakbetsQhxWTKQHrQsJavL6OtwioI0NR2BlW2dO 1eYGP9qoPrtd3uFB6MQvxst2Cp2cP+DZoTPck5X1ESmYmB6H1v297HjHgTmZTr08V5 dp1s0FqOnZC1Ie8Et1Zj6ZLI+oNlZBK4tIVK7BjL7MpMOWwywTkgbcLIA/RVOUOhc2 aXzqkd4NlRNmBXbCK9a9oYbzFL+XDM3Xadt0C7w36x6uC9nLBbNoayBPhqO80fN+wc fY09QKGkbcXSA== Received: by gandalf.ozlabs.org (Postfix, from userid 1007) id 4WNSLV549gz4x0n; Tue, 16 Jul 2024 15:29:38 +1000 (AEST) From: David Gibson To: Stefano Brivio , passt-dev@passt.top Subject: [PATCH 4/5] util: Add AF_UNSPEC support to sockaddr_ntop() Date: Tue, 16 Jul 2024 15:29:35 +1000 Message-ID: <20240716052936.1204164-5-david@gibson.dropbear.id.au> X-Mailer: git-send-email 2.45.2 In-Reply-To: <20240716052936.1204164-1-david@gibson.dropbear.id.au> References: <20240716052936.1204164-1-david@gibson.dropbear.id.au> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Message-ID-Hash: S3RE4DH4ADP4FURFKIHJCDEKEQ7AYJYB X-Message-ID-Hash: S3RE4DH4ADP4FURFKIHJCDEKEQ7AYJYB X-MailFrom: dgibson@gandalf.ozlabs.org X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: David Gibson X-Mailman-Version: 3.3.8 Precedence: list List-Id: Development discussion and patches for passt Archived-At: Archived-At: List-Archive: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: Allow sockaddr_ntop() to format AF_UNSPEC socket addresses. There do exist a few cases where we might legitimately have either an AF_UNSPEC or a real address, such as the origin address from MSG_ERRQUEUE. Even in cases where we shouldn't get an AF_UNSPEC address, formatting it is likely to make things easier to debug if we ever somehow do. Signed-off-by: David Gibson --- util.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/util.c b/util.c index 9a73fbb9..428847d2 100644 --- a/util.c +++ b/util.c @@ -622,6 +622,10 @@ const char *sockaddr_ntop(const void *sa, char *dst, socklen_t size) } while (0) switch (family) { + case AF_UNSPEC: + IPRINTF(""); + break; + case AF_INET: { const struct sockaddr_in *sa4 = sa; -- 2.45.2