From: David Gibson <david@gibson.dropbear.id.au>
To: Stefano Brivio <sbrivio@redhat.com>, passt-dev@passt.top
Cc: David Gibson <david@gibson.dropbear.id.au>
Subject: [PATCH v2 2/5] udp: Make udp_sock_recv static
Date: Wed, 17 Jul 2024 10:36:01 +1000 [thread overview]
Message-ID: <20240717003604.1577052-3-david@gibson.dropbear.id.au> (raw)
In-Reply-To: <20240717003604.1577052-1-david@gibson.dropbear.id.au>
Through an oversight this was previously declared as a public function
although it's only used in udp.c and there is no prototype in any header.
Signed-off-by: David Gibson <david@gibson.dropbear.id.au>
---
udp.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/udp.c b/udp.c
index dee402f7..187483f0 100644
--- a/udp.c
+++ b/udp.c
@@ -737,8 +737,8 @@ static void udp_tap_prepare(const struct ctx *c, const struct mmsghdr *mmh,
*
* #syscalls recvmmsg
*/
-int udp_sock_recv(const struct ctx *c, int s, uint32_t events,
- struct mmsghdr *mmh)
+static int udp_sock_recv(const struct ctx *c, int s, uint32_t events,
+ struct mmsghdr *mmh)
{
/* For not entirely clear reasons (data locality?) pasta gets better
* throughput if we receive tap datagrams one at a atime. For small
--
@@ -737,8 +737,8 @@ static void udp_tap_prepare(const struct ctx *c, const struct mmsghdr *mmh,
*
* #syscalls recvmmsg
*/
-int udp_sock_recv(const struct ctx *c, int s, uint32_t events,
- struct mmsghdr *mmh)
+static int udp_sock_recv(const struct ctx *c, int s, uint32_t events,
+ struct mmsghdr *mmh)
{
/* For not entirely clear reasons (data locality?) pasta gets better
* throughput if we receive tap datagrams one at a atime. For small
--
2.45.2
next prev parent reply other threads:[~2024-07-17 0:36 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-17 0:35 [PATCH v2 0/5] Handle error events on UDP sockets David Gibson
2024-07-17 0:36 ` [PATCH v2 1/5] conf: Don't configure port forwarding for a disabled protocol David Gibson
2024-07-17 0:36 ` David Gibson [this message]
2024-07-17 0:36 ` [PATCH v2 3/5] udp, tcp: Tweak handling of no_udp and no_tcp flags David Gibson
2024-07-17 0:36 ` [PATCH v2 4/5] util: Add AF_UNSPEC support to sockaddr_ntop() David Gibson
2024-07-17 0:36 ` [PATCH v2 5/5] udp: Handle errors on UDP sockets David Gibson
2024-07-17 6:32 ` [PATCH v2 0/5] Handle error events " Stefano Brivio
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240717003604.1577052-3-david@gibson.dropbear.id.au \
--to=david@gibson.dropbear.id.au \
--cc=passt-dev@passt.top \
--cc=sbrivio@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://passt.top/passt
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for IMAP folder(s).