From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail.ozlabs.org (gandalf.ozlabs.org [150.107.74.76]) by passt.top (Postfix) with ESMTPS id DFB795A004F for ; Wed, 17 Jul 2024 02:36:14 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gibson.dropbear.id.au; s=202312; t=1721176566; bh=CN9Ti1fvwNzThXce0LiHfzizWZCG9QrdB5XPW4d4mZY=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=JiKSMtrG8bMhvksQxlSmWGAvSoMZfL2lFGnda7oiJYIN6Fzl1mLkcRy/X2fWG1oJf 59o2fWM4EJdWo3zjEITO7XoQhkQHhPJQTzx9qTPL850nAAOj+J0a6X92+YVJRKlb8J m3oUX1Rsy9jFRb7qduYbmJXnSy0QEngvge52OxqwRnV9bkfxNRNDqwwYZnvm1vtzlI ylSSxTOem1PWcP/u107NcVB7WhRULiDvQ7TvJ1DnA9VhhYRPKFueYlfQONYMFafeEo C9VCZ+mDovOsTXZ32CW5fLeZzhKTvO0o0kdG1eOqpsRj3aXUm6fxZPSCN4o8tI7IPV qMGozXOoJcW9g== Received: by gandalf.ozlabs.org (Postfix, from userid 1007) id 4WNxnL09N7z4x1y; Wed, 17 Jul 2024 10:36:06 +1000 (AEST) From: David Gibson To: Stefano Brivio , passt-dev@passt.top Subject: [PATCH v2 4/5] util: Add AF_UNSPEC support to sockaddr_ntop() Date: Wed, 17 Jul 2024 10:36:03 +1000 Message-ID: <20240717003604.1577052-5-david@gibson.dropbear.id.au> X-Mailer: git-send-email 2.45.2 In-Reply-To: <20240717003604.1577052-1-david@gibson.dropbear.id.au> References: <20240717003604.1577052-1-david@gibson.dropbear.id.au> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Message-ID-Hash: ZQIOC3IPNB4VU5ZDTS55CWM6ATKS6JPW X-Message-ID-Hash: ZQIOC3IPNB4VU5ZDTS55CWM6ATKS6JPW X-MailFrom: dgibson@gandalf.ozlabs.org X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: David Gibson X-Mailman-Version: 3.3.8 Precedence: list List-Id: Development discussion and patches for passt Archived-At: Archived-At: List-Archive: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: Allow sockaddr_ntop() to format AF_UNSPEC socket addresses. There do exist a few cases where we might legitimately have either an AF_UNSPEC or a real address, such as the origin address from MSG_ERRQUEUE. Even in cases where we shouldn't get an AF_UNSPEC address, formatting it is likely to make things easier to debug if we ever somehow do. Signed-off-by: David Gibson --- util.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/util.c b/util.c index 9a73fbb9..428847d2 100644 --- a/util.c +++ b/util.c @@ -622,6 +622,10 @@ const char *sockaddr_ntop(const void *sa, char *dst, socklen_t size) } while (0) switch (family) { + case AF_UNSPEC: + IPRINTF(""); + break; + case AF_INET: { const struct sockaddr_in *sa4 = sa; -- 2.45.2