From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by passt.top (Postfix) with ESMTP id C86DB5A004E for ; Wed, 17 Jul 2024 07:21:03 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1721193662; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=adYVKro8HprCCy3TiAYD8qaA/Ga6ev/9pwRlwGsNZe4=; b=hQ5xabhV79PGzZd3HjhlZQB7ZJGApwUTOe2QFLeYvlcYG/6XYEXik1D5UOZRhwUtAoQN8f 1Bju/gCtvdaQRU0LxmW19MdvXN+rxPa9xmciHuKUmKz01har1T3uq48Z/jsXUoGH+DEFXA 52NNDuxUf2LL38VghTE/eWa0wSioJn8= Received: from mail-qt1-f197.google.com (mail-qt1-f197.google.com [209.85.160.197]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-271-c8q3QA0nMu63zWEkTMNbWQ-1; Wed, 17 Jul 2024 01:20:56 -0400 X-MC-Unique: c8q3QA0nMu63zWEkTMNbWQ-1 Received: by mail-qt1-f197.google.com with SMTP id d75a77b69052e-44cde9ed81aso76845111cf.1 for ; Tue, 16 Jul 2024 22:20:55 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1721193655; x=1721798455; h=content-transfer-encoding:mime-version:organization:references :in-reply-to:message-id:subject:cc:to:from:date:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=adYVKro8HprCCy3TiAYD8qaA/Ga6ev/9pwRlwGsNZe4=; b=Bk95Ukwo0q/lrbQbE/MZt28AHM9OG79Xz3yjEB4MNXJPHxalLE9af7+bSK7R1VO7tx nE1zKzt3wM56dCn3fiqBIVslDhmZoJJCrJOnEU8qK+4iIlFmaJDl+Z9DUAMianjzf5VV Tm6dOii53G9Ut+jPaD200Q3JOFNvDHaYoleGQha8WxRlukI8GG68ZEOVu857howmMcZ8 UMKdZaf1CBEXseJXksicR4ye+VdUnNOiNOMR3VeOs/CeLZn+Nk0c97NNeKXNJBXTnyAK RT4IgNfTSt+RhjsnN5usOn+ncUWoJWeTMSFG62MiSOWEYiVRG4hy+A7UfBZEkavO0iS+ rqLA== X-Gm-Message-State: AOJu0YyREMYYT6r+k/UcetEr0+aT+HTkPwQJYelNgwZwD+54LlJ+4lP4 YR12Bx4dAg1rfGxkYUZYKYs+VUGyqiMoSD47ppIgCv8Rq5IO6RtOuEVSPMiihcYzipjMKRWqyxV t3TwM9W6XO693L+agMEWWaKlaqvn2K3TgGijPgtBOI90yEuMcX/73ZXGDJlOl X-Received: by 2002:ac8:5904:0:b0:446:3927:5a9 with SMTP id d75a77b69052e-44f8617336cmr8856911cf.10.1721193654999; Tue, 16 Jul 2024 22:20:54 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGQ4lk32BZGVwBoZbkAbPsUKgAY9veyivwQMgFSdFk+tkhspZbG/3423MZqIeZyIqw2WFQ5TQ== X-Received: by 2002:ac8:5904:0:b0:446:3927:5a9 with SMTP id d75a77b69052e-44f8617336cmr8856781cf.10.1721193654604; Tue, 16 Jul 2024 22:20:54 -0700 (PDT) Received: from maya.cloud.tilaa.com (maya.cloud.tilaa.com. [164.138.29.33]) by smtp.gmail.com with ESMTPSA id d75a77b69052e-44f5b835549sm43069121cf.75.2024.07.16.22.20.53 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Tue, 16 Jul 2024 22:20:53 -0700 (PDT) Date: Wed, 17 Jul 2024 07:20:17 +0200 From: Stefano Brivio To: David Gibson Subject: Re: [PATCH 2/6] flow, tcp_splice: Prefer 'sidei' for variables referring to side index Message-ID: <20240717072018.267421a9@elisabeth> In-Reply-To: <20240717045223.2309975-3-david@gibson.dropbear.id.au> References: <20240717045223.2309975-1-david@gibson.dropbear.id.au> <20240717045223.2309975-3-david@gibson.dropbear.id.au> Organization: Red Hat X-Mailer: Claws Mail 4.2.0 (GTK 3.24.41; x86_64-pc-linux-gnu) MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Message-ID-Hash: ORTN7L2ICTI4MCYMY5ZA5WFXKYT6IU5F X-Message-ID-Hash: ORTN7L2ICTI4MCYMY5ZA5WFXKYT6IU5F X-MailFrom: sbrivio@redhat.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: passt-dev@passt.top X-Mailman-Version: 3.3.8 Precedence: list List-Id: Development discussion and patches for passt Archived-At: Archived-At: List-Archive: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On Wed, 17 Jul 2024 14:52:19 +1000 David Gibson wrote: > @@ -164,17 +164,17 @@ struct flow_common { > > /** > * struct flow_sidx - ID for one side of a specific flow > - * @side: Side referenced (0 or 1) > + * @side: Index of side referenced (0 or 1) > * @flow: Index of flow referenced Nit (I can fix this up on merge, and I didn't finish reviewing yet): the comment to the struct should also use sidei/flowi. > */ > typedef struct flow_sidx { > - unsigned side :1; > - unsigned flow :FLOW_INDEX_BITS; > + unsigned sidei :1; > + unsigned flowi :FLOW_INDEX_BITS; > } flow_sidx_t; -- Stefano