From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by passt.top (Postfix) with ESMTP id 8BF545A004E for ; Wed, 17 Jul 2024 08:32:58 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1721197977; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=ODxHMPmFj7DbMWt7y56/OFPeAn/YmLV5PEb69XC5aio=; b=NYbLptGmh5hyVNNS9rsRl8CSV5ZKyi8oGPOpQP6xFxCucOkdMjcP32SnxsUo7LL2YzFyd2 2WxrWkMNS0n4BtpYg7rtJ8ZM4swEXSvLDySJsahYLJR/OgZNOSHw0ALcbZxx+iRf88oqkw FPkkpaddDC4+a+6GClShaHj4uVHPCc4= Received: from mail-qv1-f69.google.com (mail-qv1-f69.google.com [209.85.219.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-639-RXpVEaf3OUaV3tKXaC0dyA-1; Wed, 17 Jul 2024 02:32:55 -0400 X-MC-Unique: RXpVEaf3OUaV3tKXaC0dyA-1 Received: by mail-qv1-f69.google.com with SMTP id 6a1803df08f44-6b7917c2b69so3136646d6.1 for ; Tue, 16 Jul 2024 23:32:55 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1721197974; x=1721802774; h=content-transfer-encoding:mime-version:organization:references :in-reply-to:message-id:subject:cc:to:from:date:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=ODxHMPmFj7DbMWt7y56/OFPeAn/YmLV5PEb69XC5aio=; b=fRznwSr43nlFWL8DUAd6T1rSuDVWuzuGSrudLkxW8LaxZeYrOV4gKzc9IITh/rkIC3 RUvw8+WZNVJ7z3v6dLo6ciSNZEuxGxTxK5kW0S0fl4axC/RGLlPxl2ce/hGvIDGODszl 9QEX3UtLFt49dPKUH18z0FWYb/Ea/+zPdGmPhpRFs/MPQSVPHHTo2JpTs/SDoDMcFcF/ peRc9pECohuNMqBEcXF/Jf954kD0gRng7+ZY9ryfeZ+kZUd3aW8rK3xWoFg7ESp+pht9 Ue9Wztz5K9cHgG2Zd0fpWM8nteCgjdPYQnuFt8bJSvTCPzdJ5sFzaPzyt5DJrEJmHwPy 7PAw== X-Gm-Message-State: AOJu0Yxodm1GEsfGkhRmCBgPfVx0SKJTUZOv2zkYj6wINdWWLIWhB47w 0rR4uwCBbbDb8XHfTEQBLS9tu3Wqu9nFbffuz9jIfESPvYtxYsg3pZKW+fqrQv27NxjEaPS7wc2 jqQcLvPHoX9llGfGUeHZrN8PyV45sgjqILCdRH1nJLe3V8cREy9Id8xdyvCRF X-Received: by 2002:a05:6214:224b:b0:6b5:8e02:834b with SMTP id 6a1803df08f44-6b78e2d75b5mr13183876d6.57.1721197973880; Tue, 16 Jul 2024 23:32:53 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFrCwOWPluEZp5abLwPXdz3Xyo6j0/HmmzMxk0/tctwUzwJW82clQXZKL/HtvVYyxg+X8yxDw== X-Received: by 2002:a05:6214:224b:b0:6b5:8e02:834b with SMTP id 6a1803df08f44-6b78e2d75b5mr13183716d6.57.1721197973527; Tue, 16 Jul 2024 23:32:53 -0700 (PDT) Received: from maya.cloud.tilaa.com (maya.cloud.tilaa.com. [164.138.29.33]) by smtp.gmail.com with ESMTPSA id d75a77b69052e-44f5b837300sm43645341cf.65.2024.07.16.23.32.52 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Tue, 16 Jul 2024 23:32:52 -0700 (PDT) Date: Wed, 17 Jul 2024 08:32:17 +0200 From: Stefano Brivio To: David Gibson Subject: Re: [PATCH v2 0/5] Handle error events on UDP sockets Message-ID: <20240717083217.2340afb8@elisabeth> In-Reply-To: <20240717003604.1577052-1-david@gibson.dropbear.id.au> References: <20240717003604.1577052-1-david@gibson.dropbear.id.au> Organization: Red Hat X-Mailer: Claws Mail 4.2.0 (GTK 3.24.41; x86_64-pc-linux-gnu) MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Message-ID-Hash: QE35QDGRA7V7UYTLTIHOW4HIB6L7MWVZ X-Message-ID-Hash: QE35QDGRA7V7UYTLTIHOW4HIB6L7MWVZ X-MailFrom: sbrivio@redhat.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: passt-dev@passt.top X-Mailman-Version: 3.3.8 Precedence: list List-Id: Development discussion and patches for passt Archived-At: Archived-At: List-Archive: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On Wed, 17 Jul 2024 10:35:59 +1000 David Gibson wrote: > Add handling of the error queue for UDP sockets. We certainly need > this for the flow table: this is the cause of the epoll loop that > Stefano noticed. Even without the flow table it should improve > robustness and debugability. > > Along the way we make a few other clean ups. > > Changes from v1: > * Assorted minor changes based on Stefano's review > > David Gibson (5): > conf: Don't configure port forwarding for a disabled protocol > udp: Make udp_sock_recv static > udp, tcp: Tweak handling of no_udp and no_tcp flags > util: Add AF_UNSPEC support to sockaddr_ntop() > udp: Handle errors on UDP sockets Applied. -- Stefano