From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by passt.top (Postfix) with ESMTP id A67735A004E for ; Wed, 17 Jul 2024 09:21:24 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1721200883; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=9z/Q7TFdSEzap+QHdtKcJ2CjFiEWDwuObfuOEzJfhe4=; b=Ulnljdu6NzaP1YBnL7SLOVMO6poyqREB8vruQilmoYE3ejSapg/cW3nQBX8BO4l9gto+WK bdzsE2LUPITYXQCGgXHfSze8GkiYxfJQdgfqdgA68qBvitjtXTLJujj9I8l9Gh/MzK16Kz xxFCH5pE9ZbQwBNQP5qdYt7HQZ53Yb8= Received: from mail-qv1-f70.google.com (mail-qv1-f70.google.com [209.85.219.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-629--WDrNfYJNuK-h2K11J63DA-1; Wed, 17 Jul 2024 03:21:19 -0400 X-MC-Unique: -WDrNfYJNuK-h2K11J63DA-1 Received: by mail-qv1-f70.google.com with SMTP id 6a1803df08f44-6b5ed8fb791so99201856d6.3 for ; Wed, 17 Jul 2024 00:21:19 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1721200878; x=1721805678; h=content-transfer-encoding:mime-version:organization:references :in-reply-to:message-id:subject:cc:to:from:date:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=9z/Q7TFdSEzap+QHdtKcJ2CjFiEWDwuObfuOEzJfhe4=; b=OKCfHKitXHp83kMFI2ViFnzLgzi/EHeMjgqVQ6jMtNkJ0M+l32WQrh+pW1b+nkR7dX Ty3CGTqFRB+lPC+Z5gTVi+9CpmOWnAiDxgi7qvAWE77xVOJEwk/kp2lWcAD8wobIDk/t FR5+jRphf41FEUGd+BvwLvTMosJVc4rC9wUaB6lOE7ACFrTF0ZsNWJZozvlv0xzDzOcy 6dDYClNN4GGpmcKTNmNxect9aOxs0gXourrKfQUH0ZxC1vuYlEiBgOzQCPnQGzlYYHCO gGqP/Hbxq2pw2Du5YuIoWSIautOlmr6iNRQB6mVLQc0atSWPorpf2djrdvREAALjLWIE PACQ== X-Gm-Message-State: AOJu0YzdVk5UHJHHqrRK9EzLQjjK6BeUARU25hUOksZQtGbqE7QoCPGy WAoL82Soi6EszvKwT6CRLZiTbafedV0BMXZSnLLN6CsSPVDUAf4USnj8dugGgQF7xtEWPvszXBv 3TXercCR3znMEbi79XLXlgQuHpMH401XAzApx8XCkoaBte4PzCBR8ayjYV7TR X-Received: by 2002:a05:6214:5282:b0:6b5:460d:5477 with SMTP id 6a1803df08f44-6b78e2e6ec1mr13937016d6.51.1721200878371; Wed, 17 Jul 2024 00:21:18 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFp8Sx24kqu+BSPm2o7FCbnz9R0Jl6ZXq/riMW6NocRJte2TGiaKHSaTHoQZ4o5wWoUJ2NJ2Q== X-Received: by 2002:a05:6214:5282:b0:6b5:460d:5477 with SMTP id 6a1803df08f44-6b78e2e6ec1mr13936806d6.51.1721200877914; Wed, 17 Jul 2024 00:21:17 -0700 (PDT) Received: from maya.cloud.tilaa.com (maya.cloud.tilaa.com. [164.138.29.33]) by smtp.gmail.com with ESMTPSA id 6a1803df08f44-6b761a7f687sm39263026d6.137.2024.07.17.00.21.17 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Wed, 17 Jul 2024 00:21:17 -0700 (PDT) Date: Wed, 17 Jul 2024 09:20:42 +0200 From: Stefano Brivio To: David Gibson Subject: Re: [PATCH 2/6] flow, tcp_splice: Prefer 'sidei' for variables referring to side index Message-ID: <20240717092029.0036d1ce@elisabeth> In-Reply-To: References: <20240717045223.2309975-1-david@gibson.dropbear.id.au> <20240717045223.2309975-3-david@gibson.dropbear.id.au> <20240717072018.267421a9@elisabeth> Organization: Red Hat X-Mailer: Claws Mail 4.2.0 (GTK 3.24.41; x86_64-pc-linux-gnu) MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Message-ID-Hash: KWJ277OZJSVEK326YOZYGUFOD6AFERH2 X-Message-ID-Hash: KWJ277OZJSVEK326YOZYGUFOD6AFERH2 X-MailFrom: sbrivio@redhat.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: passt-dev@passt.top X-Mailman-Version: 3.3.8 Precedence: list List-Id: Development discussion and patches for passt Archived-At: Archived-At: List-Archive: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On Wed, 17 Jul 2024 15:50:32 +1000 David Gibson wrote: > On Wed, Jul 17, 2024 at 03:28:05PM +1000, David Gibson wrote: > > On Wed, Jul 17, 2024 at 07:20:17AM +0200, Stefano Brivio wrote: > > > On Wed, 17 Jul 2024 14:52:19 +1000 > > > David Gibson wrote: > > > > > > > @@ -164,17 +164,17 @@ struct flow_common { > > > > > > > > /** > > > > * struct flow_sidx - ID for one side of a specific flow > > > > - * @side: Side referenced (0 or 1) > > > > + * @side: Index of side referenced (0 or 1) > > > > * @flow: Index of flow referenced > > > > > > Nit (I can fix this up on merge, and I didn't finish reviewing yet): > > > the comment to the struct should also use sidei/flowi. > > > > If this is the only issue, go ahead and fix on merge. If there are > > any more nits I'll make a new spin. > > Actually, never mind. I discovered I hadn't rebased onto the latest > and there's a conflict, so I'll respin anyway. It's trivial, just a bit of fuzz on 1/6, no need as far as I'm concerned. -- Stefano