public inbox for passt-dev@passt.top
 help / color / mirror / code / Atom feed
From: Stefano Brivio <sbrivio@redhat.com>
To: David Gibson <david@gibson.dropbear.id.au>
Cc: passt-dev@passt.top
Subject: Re: [PATCH 0/2] Broaden DNS forwarding
Date: Wed, 24 Jul 2024 08:35:11 +0200	[thread overview]
Message-ID: <20240724083511.0704197d@elisabeth> (raw)
In-Reply-To: <20240724062058.1259033-1-david@gibson.dropbear.id.au>

On Wed, 24 Jul 2024 16:20:56 +1000
David Gibson <david@gibson.dropbear.id.au> wrote:

> When looking through outstanding bugs in various trackers, I noticed
> this one:
> 	https://github.com/containers/podman/issues/23239

...right, that was also pretty much the first candidate in my list of
flow table related low-hanging fruits.

The series looks good to me, except for a nit on 1/2 and one missing
bit: we should update the man page as well (for --dns-forward).

-- 
Stefano


      parent reply	other threads:[~2024-07-24  6:37 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-07-24  6:20 [PATCH 0/2] Broaden DNS forwarding David Gibson
2024-07-24  6:20 ` [PATCH 1/2] fwd: Refactor tests in fwd_nat_from_tap() for clarity David Gibson
2024-07-24  6:38   ` Stefano Brivio
2024-07-24  7:46     ` David Gibson
2024-07-24  6:20 ` [PATCH 2/2] fwd: Broaden what we consider for DNS specific forwarding rules David Gibson
2024-07-24  6:35 ` Stefano Brivio [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240724083511.0704197d@elisabeth \
    --to=sbrivio@redhat.com \
    --cc=david@gibson.dropbear.id.au \
    --cc=passt-dev@passt.top \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://passt.top/passt

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for IMAP folder(s).