From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by passt.top (Postfix) with ESMTP id 820F95A004F for ; Wed, 24 Jul 2024 09:29:58 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1721806197; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=TpEbLwg5FdzcM6roylnt3F/EpMwslgLekJM8KEBgs+I=; b=c4REoQ+a2QoeiA3cu2qYKs+Svik6J06UWCs2dp+F/CjbNazSkrNrXLVgAZYoPgg+lU02f4 v1rqB2n5+Efa95OlpMzGH2QJWCX1eScDOlbo30Odc4ntd59pmsDzBv/+egkSWJXc+foTst PFEvFEtup6Y9rZ3HCpR2DbmKFhSnvJ4= Received: from mail-qk1-f198.google.com (mail-qk1-f198.google.com [209.85.222.198]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-344-C0en-X1jNSS87V3pm0BWdA-1; Wed, 24 Jul 2024 03:29:53 -0400 X-MC-Unique: C0en-X1jNSS87V3pm0BWdA-1 Received: by mail-qk1-f198.google.com with SMTP id af79cd13be357-79f1d37915dso115751885a.1 for ; Wed, 24 Jul 2024 00:29:53 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1721806193; x=1722410993; h=content-transfer-encoding:mime-version:organization:references :in-reply-to:message-id:subject:cc:to:from:date:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=TpEbLwg5FdzcM6roylnt3F/EpMwslgLekJM8KEBgs+I=; b=cYeIs1WsLcMnnQS7c8nWGNRcIUf45evTJaMh9Z5a9gDquGCUmQSqVGP2JWuTyRxXFy 6M2L8cHK83TFvmRbvNy8j/mxtIWM5M3LMcNS6Z0CbiefvtUKnGjaVrKCEUUw0frWvx5H AMzfFRt9EmAmFLQ+XRsw5HnaYO8Am0juxXYxNA2I2H44AO+rtNjE0rYGssP/hJkWpdm8 pv3AhXjrjF4kvRwhfL2J9kmOOwD+KDqDLO+/z0Fuvkx8M8UQb4BLPBjGgtb6BW02aEQj SjfKWI4ygKSrtvNm5lbtTGdnp/kr/y7HXNy/BXamDZz10pkmcghV6J+6poTbP1khHQ7X wo8w== X-Gm-Message-State: AOJu0YwY+YIAfj5plXCJ/is4gR0yMNDUsv4y4MiQTX5Ku+8e6u/AGdbH aaYEu8SFUmWcNz1Fga0T1U8L1W1SSHhTfpHfhsdox+7nNOnNc0nVg8f/OhQxkiUd7uIxGPccyRW yff4oTCf9mmUjWpMBPR/MxJ9IdWpc0sEkpLs1G/JcWyu85+SbNg== X-Received: by 2002:a05:6214:321:b0:6b5:16f3:94a0 with SMTP id 6a1803df08f44-6b99154d556mr14603696d6.18.1721806193349; Wed, 24 Jul 2024 00:29:53 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFVPus3NoNb9b67KHPxPbfsvIYtGFqpam5fMwMJfXAKB4b3pXgHm0BVBdpH682RqOdzZak65g== X-Received: by 2002:a05:6214:321:b0:6b5:16f3:94a0 with SMTP id 6a1803df08f44-6b99154d556mr14603566d6.18.1721806193011; Wed, 24 Jul 2024 00:29:53 -0700 (PDT) Received: from maya.cloud.tilaa.com (maya.cloud.tilaa.com. [164.138.29.33]) by smtp.gmail.com with ESMTPSA id 6a1803df08f44-6b968f85975sm37554686d6.16.2024.07.24.00.29.52 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Wed, 24 Jul 2024 00:29:52 -0700 (PDT) Date: Wed, 24 Jul 2024 09:29:17 +0200 From: Stefano Brivio To: David Gibson Subject: Re: [PATCH v2] tcp: probe for SO_PEEK_OFF both in tcpv4 and tcp6 Message-ID: <20240724092910.7e448b98@elisabeth> In-Reply-To: References: <20240722220937.3663437-1-sbrivio@redhat.com> <20240723222936.1c301d30@elisabeth> Organization: Red Hat X-Mailer: Claws Mail 4.2.0 (GTK 3.24.41; x86_64-pc-linux-gnu) MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Message-ID-Hash: TVR4LMVH5KOHS2W2OKJTNPXDNQC2XTOE X-Message-ID-Hash: TVR4LMVH5KOHS2W2OKJTNPXDNQC2XTOE X-MailFrom: sbrivio@redhat.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: passt-dev@passt.top, Jon Maloy X-Mailman-Version: 3.3.8 Precedence: list List-Id: Development discussion and patches for passt Archived-At: Archived-At: List-Archive: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On Wed, 24 Jul 2024 13:31:49 +1000 David Gibson wrote: > On Wed, Jul 24, 2024 at 10:40:15AM +1000, David Gibson wrote: > > On Tue, Jul 23, 2024 at 10:29:36PM +0200, Stefano Brivio wrote: > > > On Tue, 23 Jul 2024 00:09:37 +0200 > > > Stefano Brivio wrote: > > > > > > > From: Jon Maloy > > > > > > > > Based on an original patch by Jon Maloy: > > > > > > > > > > ...so, with this, the probing issue is solved: on a 6.10 kernel, > > > SO_PEEK_OFF is not used, unless I disable IPv6 (with --ipv4-only / -4). > > > > > > However, if I disable it, for some reason, resorting to IPv4, at least > > > together with the flow table (applying just this patch to HEAD), I get > > > something that looks like one of the "old" TCP stalls. On the host: > > > > > > $ ./passt -f -t 10000 -4 > > > > > > and in the guest: > > > > > > # ip link set dev eth0 up > > > # dhclient eth0 > > > # iperf3 -s -p 10000 > > > > > > back to the host: > > > > > > $ iperf3 -c 127.0.0.1 -p 10000 > > > Connecting to host 127.0.0.1, port 10000 > > > [ 5] local 127.0.0.1 port 39046 connected to 127.0.0.1 port 10000 > > > [ ID] Interval Transfer Bitrate Retr Cwnd > > > [ 5] 0.00-1.00 sec 11.2 MBytes 94.3 Mbits/sec 0 5.50 MBytes > > > [ 5] 1.00-2.00 sec 0.00 Bytes 0.00 bits/sec 0 5.50 MBytes > > > [ 5] 2.00-3.00 sec 0.00 Bytes 0.00 bits/sec 0 5.50 MBytes > > > > > > ...the transfer never recovers. > > > > Bother. I've reproduced and am debugging now. > > Found it. Looks like one of the cases where we need to set > SO_PEEK_OFF was lost somewhere in the refactorings :(. Hah, great, thanks, it fixes the issue on my setup as well. Re-running all tests now... -- Stefano