From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail.ozlabs.org (mail.ozlabs.org [IPv6:2404:9400:2221:ea00::3]) by passt.top (Postfix) with ESMTPS id 3F9315A004F for ; Fri, 26 Jul 2024 09:20:42 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gibson.dropbear.id.au; s=202312; t=1721978433; bh=BzFjsGVVsHtRNMtMFCYdF8mRqksxzvzQDQ/d+LwRSNg=; h=From:To:Cc:Subject:Date:From; b=D4M9QJHUBkYUKASKJHlrmZ7poYpDgfOR61Rj+myOBI6NmBtu6QlbmdD391h+9yIb4 e/K8UVMzYi8XDnQW1ztTvpQJ2ui55xT2yV7vt7hnwTBt3b984fcw9GbHBlmO3Sm2AT pSJcxZbLR+yXBhPvoAmhj0RCbs9mzw25QlKn7muLpLf68RfPmAHPdQJQeo7y7Qwmgl BdC+APYu+GQVmeJxRGbyY23/h8W7cSw3bCrbGP2fLp93Ly8FgwIgVhssyk2SvJA498 Hvg0cwVP0YOTaBV3a4aHBEooriEd42PrIoKtMyrwVU4oWo/Q6r9GOPbRdlHewYtl+1 mVI0nqGOUyO4A== Received: by gandalf.ozlabs.org (Postfix, from userid 1007) id 4WVfKs0Vl9z4x3d; Fri, 26 Jul 2024 17:20:33 +1000 (AEST) From: David Gibson To: passt-dev@passt.top, Stefano Brivio Subject: [PATCH 0/5] Fix assorted errors in the Qemu socket tap receive handler Date: Fri, 26 Jul 2024 17:20:26 +1000 Message-ID: <20240726072031.3941305-1-david@gibson.dropbear.id.au> X-Mailer: git-send-email 2.45.2 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Message-ID-Hash: 5QSWOYIEIAKGFAEZXKEWNTF3V7GBV3TC X-Message-ID-Hash: 5QSWOYIEIAKGFAEZXKEWNTF3V7GBV3TC X-MailFrom: dgibson@gandalf.ozlabs.org X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: David Gibson X-Mailman-Version: 3.3.8 Precedence: list List-Id: Development discussion and patches for passt Archived-At: Archived-At: List-Archive: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: A long time ago Matej Hrica pointed out a possible buffer overrun when receiving data from the qemu socket. Stefano recently proposed a fix for this, but I don't think it's quite right. This series is a different approach to fixing that problem and a few adjacent ones. David Gibson (5): tap: Better report errors receiving from QEMU socket tap: Don't attempt to carry on if we get a bad frame length from qemu tap: Don't use EPOLLET on Qemu sockets tap: Correctly handle frames of odd length tap: Improve handling of partially received frames on qemu socket passt.h | 1 - tap.c | 72 ++++++++++++++++++++++++++++++--------------------------- util.h | 16 +++++++++++++ 3 files changed, 54 insertions(+), 35 deletions(-) -- 2.45.2