From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by passt.top (Postfix) with ESMTP id 13A1B5A004F for ; Fri, 26 Jul 2024 15:20:32 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1722000032; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=SrcEZpPoCwi3hfoj1ehcc0h4ZM8MUs+WxAc5tWWFCFU=; b=Ulz35qu8NIe+DuID4LTNhRD3hEUYpM4V/Whul/18pg0NWzeKAnjiAJwyiZaVRgD/tPH0Jv lcvPQ2pWt+Vz0xqFv1DHrCy6eV5yWGmJ6hKMnf7LUB0wljIuuSkvvxviUm51G3dW1yQ4Tx tXhkDWT5GmxCoPYVrB0AuEyYQe+Zc1g= Received: from mail-qk1-f199.google.com (mail-qk1-f199.google.com [209.85.222.199]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-653-LLXaus36PP60hDfZEcWj2w-1; Fri, 26 Jul 2024 09:20:30 -0400 X-MC-Unique: LLXaus36PP60hDfZEcWj2w-1 Received: by mail-qk1-f199.google.com with SMTP id af79cd13be357-7a1df704ef8so77561185a.2 for ; Fri, 26 Jul 2024 06:20:30 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1722000029; x=1722604829; h=content-transfer-encoding:mime-version:organization:references :in-reply-to:message-id:subject:cc:to:from:date:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=SrcEZpPoCwi3hfoj1ehcc0h4ZM8MUs+WxAc5tWWFCFU=; b=bW/gScCDaerMRknBoglHH5d6UFZ4fKYzl5hhNhc2cvysJwjOBo8uhrVwQXRKdSU6KC Up3xHPxFEzMidym7FbN/+1wezSV7wOsQMQkipdmvwIXpgR6tSm/c72OKG1+r9tsy60ee 4LriRRKY1NCh7O56aIhdIbkXJpatFr6gUvADtZXnUNrQpwbowsPjQsUiXfA0Ctc8c51Z D1aiGuhvAwa0V+A8fQQOTcHfjNpUr4CBVwhKr7b6QaUFwV7dJ2ZuzMM0h4vhs/Ob9v5o /jw4w1CMedNWhHRQQGJZV7FSOwhLL3O+n0eKawpAXq86q2A4wr46xZYiPI5TsYjSLHGl YbCA== X-Gm-Message-State: AOJu0YyHzecVEkcdhSEpBFlRYkvkeKn4vefCLHCcxxnRf9/x6j2mRai7 SU6xofR7LP608gdO3huo966IG8fKORzaH1YmlF/wWA7A61H7iilqOBwGbs9zQpLc1NP/FiFY6DZ 42ZhXM3I482EVIdfYV6oe77ijIRBPejpHdd33W3s2SXijNweNVkvarkMe3jEB X-Received: by 2002:a05:620a:2795:b0:79d:569a:699f with SMTP id af79cd13be357-7a1d44da8camr711152485a.39.1722000029282; Fri, 26 Jul 2024 06:20:29 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGH2kwMj/i+rfy6/kyEYhKNPuqkRzPRXTwmDmEUNizBA7u7a0DLpPsDh2w4iGXLuoWnxH3Q2A== X-Received: by 2002:a05:620a:2795:b0:79d:569a:699f with SMTP id af79cd13be357-7a1d44da8camr711150385a.39.1722000028784; Fri, 26 Jul 2024 06:20:28 -0700 (PDT) Received: from maya.cloud.tilaa.com (maya.cloud.tilaa.com. [164.138.29.33]) by smtp.gmail.com with ESMTPSA id af79cd13be357-7a1d745f863sm174741285a.129.2024.07.26.06.20.28 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Fri, 26 Jul 2024 06:20:28 -0700 (PDT) Date: Fri, 26 Jul 2024 15:19:53 +0200 From: Stefano Brivio To: David Gibson Subject: Re: [PATCH 0/5] Fix assorted errors in the Qemu socket tap receive handler Message-ID: <20240726151933.5babe935@elisabeth> In-Reply-To: <20240726072031.3941305-1-david@gibson.dropbear.id.au> References: <20240726072031.3941305-1-david@gibson.dropbear.id.au> Organization: Red Hat X-Mailer: Claws Mail 4.2.0 (GTK 3.24.41; x86_64-pc-linux-gnu) MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Message-ID-Hash: HZJSH7DDEDOYTBOBXKPX4XKPUJIELT7C X-Message-ID-Hash: HZJSH7DDEDOYTBOBXKPX4XKPUJIELT7C X-MailFrom: sbrivio@redhat.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: passt-dev@passt.top X-Mailman-Version: 3.3.8 Precedence: list List-Id: Development discussion and patches for passt Archived-At: Archived-At: List-Archive: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On Fri, 26 Jul 2024 17:20:26 +1000 David Gibson wrote: > A long time ago Matej Hrica pointed out a possible buffer overrun when > receiving data from the qemu socket. Stefano recently proposed a fix > for this, but I don't think it's quite right. This series is a > different approach to fixing that problem and a few adjacent ones. > > David Gibson (5): > tap: Better report errors receiving from QEMU socket > tap: Don't attempt to carry on if we get a bad frame length from qemu > tap: Don't use EPOLLET on Qemu sockets > tap: Correctly handle frames of odd length > tap: Improve handling of partially received frames on qemu socket Applied. I'm a bit nervous about 3/5 but anyway the series as a whole is clearly better than the alternative. -- Stefano