public inbox for passt-dev@passt.top
 help / color / mirror / code / Atom feed
From: Danish Prakash <contact@danishpraka.sh>
To: passt-dev@passt.top, sbrivio@redhat.com
Cc: Danish Prakash <contact@danishpraka.sh>
Subject: [PATCH v2] pasta.c: modify hostname when detaching new namespace
Date: Tue, 30 Jul 2024 11:31:23 +0530	[thread overview]
Message-ID: <20240730060132.5522-1-contact@danishpraka.sh> (raw)
In-Reply-To: <20240520083343.10973-1-contact@danishpraka.sh>

When invoking pasta without any arguments, it's difficult
to tell whether we are in the new namespace or not leaving
users a bit confused. This change modifies the host namespace
to add a prefix "pasta-" to make it a bit more obvious.

Signed-off-by: Danish Prakash <contact@danishpraka.sh>
---
 pasta.c | 10 ++++++++++
 1 file changed, 10 insertions(+)

diff --git a/pasta.c b/pasta.c
index 31e1e000ee1b..7ce502d3f299 100644
--- a/pasta.c
+++ b/pasta.c
@@ -50,6 +50,8 @@
 #include "netlink.h"
 #include "log.h"
 
+#define HOSTNAME_PREFIX		"pasta-"
+
 /* PID of child, in case we created a namespace */
 int pasta_child_pid;
 
@@ -178,6 +180,7 @@ struct pasta_spawn_cmd_arg {
  */
 static int pasta_spawn_cmd(void *arg)
 {
+	char hostname[HOST_NAME_MAX + 1] = HOSTNAME_PREFIX;
 	const struct pasta_spawn_cmd_arg *a;
 	sigset_t set;
 
@@ -188,6 +191,13 @@ static int pasta_spawn_cmd(void *arg)
 	if (write_file("/proc/sys/net/ipv4/ping_group_range", "0 0"))
 		warn("Cannot set ping_group_range, ICMP requests might fail");
 
+	if (!gethostname(hostname + sizeof(HOSTNAME_PREFIX) - 1, HOST_NAME_MAX + 1 -
+        sizeof(HOSTNAME_PREFIX)) || errno == ENAMETOOLONG) {
+        hostname[HOST_NAME_MAX] = '\0';
+		if (sethostname(hostname, strlen(hostname)))
+			warn("Unable to set pasta-prefixed hostname");
+	}
+
 	/* Wait for the parent to be ready: see main() */
 	sigemptyset(&set);
 	sigaddset(&set, SIGUSR1);
-- 
@@ -50,6 +50,8 @@
 #include "netlink.h"
 #include "log.h"
 
+#define HOSTNAME_PREFIX		"pasta-"
+
 /* PID of child, in case we created a namespace */
 int pasta_child_pid;
 
@@ -178,6 +180,7 @@ struct pasta_spawn_cmd_arg {
  */
 static int pasta_spawn_cmd(void *arg)
 {
+	char hostname[HOST_NAME_MAX + 1] = HOSTNAME_PREFIX;
 	const struct pasta_spawn_cmd_arg *a;
 	sigset_t set;
 
@@ -188,6 +191,13 @@ static int pasta_spawn_cmd(void *arg)
 	if (write_file("/proc/sys/net/ipv4/ping_group_range", "0 0"))
 		warn("Cannot set ping_group_range, ICMP requests might fail");
 
+	if (!gethostname(hostname + sizeof(HOSTNAME_PREFIX) - 1, HOST_NAME_MAX + 1 -
+        sizeof(HOSTNAME_PREFIX)) || errno == ENAMETOOLONG) {
+        hostname[HOST_NAME_MAX] = '\0';
+		if (sethostname(hostname, strlen(hostname)))
+			warn("Unable to set pasta-prefixed hostname");
+	}
+
 	/* Wait for the parent to be ready: see main() */
 	sigemptyset(&set);
 	sigaddset(&set, SIGUSR1);
-- 
2.45.2


       reply	other threads:[~2024-07-30  6:01 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20240520083343.10973-1-contact@danishpraka.sh>
2024-07-30  6:01 ` Danish Prakash [this message]
2024-07-30 17:09   ` [PATCH v2] pasta.c: modify hostname when detaching new namespace Stefano Brivio

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240730060132.5522-1-contact@danishpraka.sh \
    --to=contact@danishpraka.sh \
    --cc=passt-dev@passt.top \
    --cc=sbrivio@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://passt.top/passt

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for IMAP folder(s).