public inbox for passt-dev@passt.top
 help / color / mirror / code / Atom feed
From: David Gibson <david@gibson.dropbear.id.au>
To: Stefano Brivio <sbrivio@redhat.com>, passt-dev@passt.top
Cc: Cleber Rosa <crosa@redhat.com>,
	David Gibson <david@gibson.dropbear.id.au>
Subject: [PATCH v2 09/22] tasst: "snh" module for simulated network hosts
Date: Mon,  5 Aug 2024 22:36:48 +1000	[thread overview]
Message-ID: <20240805123701.1720730-10-david@gibson.dropbear.id.au> (raw)
In-Reply-To: <20240805123701.1720730-1-david@gibson.dropbear.id.au>

Add to the tasst library a SimNetHost class used to represent a
simulated network host of some type (e.g. namespaces, VMs). For now
all it does is lets you execute commands, either foreground or
background in the context of the simulated host.  We add some "meta"
exeter tests for it.

Signed-off-by: David Gibson <david@gibson.dropbear.id.au>
---
 test/Makefile          |   2 +-
 test/tasst/__main__.py |   6 +-
 test/tasst/snh.py      | 187 +++++++++++++++++++++++++++++++++++++++++
 3 files changed, 190 insertions(+), 5 deletions(-)
 create mode 100644 test/tasst/snh.py

diff --git a/test/Makefile b/test/Makefile
index 81f94f70..8373ae77 100644
--- a/test/Makefile
+++ b/test/Makefile
@@ -70,7 +70,7 @@ EXETER_PY = build/build.py
 EXETER_JOBS = $(EXETER_SH:%.sh=%.json) $(EXETER_PY:%.py=%.json)
 AVOCADO_JOBS = $(EXETER_JOBS) avocado/static_checkers.json
 
-TASST_SRCS = __init__.py __main__.py
+TASST_SRCS = __init__.py __main__.py snh.py
 
 EXETER_META = meta/lint.json meta/tasst.json
 META_JOBS = $(EXETER_META)
diff --git a/test/tasst/__main__.py b/test/tasst/__main__.py
index c365b986..91499128 100644
--- a/test/tasst/__main__.py
+++ b/test/tasst/__main__.py
@@ -12,10 +12,8 @@ library of test helpers for passt & pasta
 
 import exeter
 
-
-@exeter.test
-def placeholder():
-    pass
+# We import just to get the exeter tests, which flake8 can't see
+from . import snh  # noqa: F401
 
 
 if __name__ == '__main__':
diff --git a/test/tasst/snh.py b/test/tasst/snh.py
new file mode 100644
index 00000000..dfbe2c84
--- /dev/null
+++ b/test/tasst/snh.py
@@ -0,0 +1,187 @@
+#! /usr/bin/env python3
+
+# SPDX-License-Identifier: GPL-2.0-or-later
+#
+# Copyright Red Hat
+# Author: David Gibson <david@gibson.dropbear.id.au>
+
+"""
+Test A Simple Socket Transport
+
+tasst/snh.py - Simulated network hosts for testing
+"""
+
+
+import contextlib
+import subprocess
+import sys
+
+import exeter
+
+
+STDOUT = 1
+
+
+class SnhProcess(contextlib.AbstractContextManager):
+    """
+    A background process running on a SimNetHost
+    """
+
+    def __init__(self, snh, *cmd, check=True, context_timeout=1.0, **kwargs):
+        self.snh = snh
+        self.cmd = cmd
+        self.check = check
+        self.context_timeout = float(context_timeout)
+
+        self.kwargs = kwargs
+
+    def __enter__(self):
+        self.popen = subprocess.Popen(self.cmd, **self.kwargs)
+        return self
+
+    def run(self, **kwargs):
+        stdout, stderr = self.popen.communicate(**kwargs)
+        cp = subprocess.CompletedProcess(self.popen.args,
+                                         self.popen.returncode,
+                                         stdout, stderr)
+        if self.check:
+            cp.check_returncode()
+        return cp
+
+    def terminate(self):
+        self.popen.terminate()
+
+    def kill(self):
+        self.popen.kill()
+
+    def __exit__(self, *exc_details):
+        try:
+            self.popen.wait(timeout=self.context_timeout)
+        except subprocess.TimeoutExpired as e:
+            self.terminate()
+            try:
+                self.popen.wait(timeout=self.context_timeout)
+            except subprocess.TimeoutExpired:
+                self.kill()
+            raise e
+
+
+class SimNetHost(contextlib.AbstractContextManager):
+    """
+    A (usually virtual or simulated) location where we can execute
+    commands and configure networks.
+
+    """
+
+    def __init__(self, name):
+        self.name = name   # For debugging
+
+    def hostify(self, *cmd, **kwargs):
+        raise NotImplementedError
+
+    def __enter__(self):
+        return self
+
+    def __exit__(self, *exc_details):
+        pass
+
+    def output(self, *cmd, **kwargs):
+        proc = self.fg(*cmd, capture=STDOUT, **kwargs)
+        return proc.stdout
+
+    def fg(self, *cmd, timeout=None, **kwargs):
+        # We don't use subprocess.run() because it kills without
+        # attempting to terminate on timeout
+        with self.bg(*cmd, **kwargs) as proc:
+            res = proc.run(timeout=timeout)
+        return res
+
+    def bg(self, *cmd, capture=None, **kwargs):
+        if capture == STDOUT:
+            kwargs['stdout'] = subprocess.PIPE
+        hostcmd, kwargs = self.hostify(*cmd, **kwargs)
+        proc = SnhProcess(self, *hostcmd, **kwargs)
+        print(f"SimNetHost {self.name}: Started {cmd} => {proc}",
+              file=sys.stderr)
+        return proc
+
+    # Internal tests
+    def test_true(self):
+        with self as snh:
+            snh.fg('true')
+
+    def test_false(self):
+        with self as snh:
+            exeter.assert_raises(subprocess.CalledProcessError,
+                                 snh.fg, 'false')
+
+    def test_echo(self):
+        msg = 'Hello tasst'
+        with self as snh:
+            out = snh.output('echo', f'{msg}')
+            exeter.assert_eq(out, msg.encode('utf-8') + b'\n')
+
+    def test_timeout(self):
+        with self as snh:
+            exeter.assert_raises(subprocess.TimeoutExpired, snh.fg,
+                                 'sleep', 'infinity', timeout=0.1, check=False)
+
+    def test_bg_true(self):
+        with self as snh:
+            with snh.bg('true'):
+                pass
+
+    def test_bg_false(self):
+        with self as snh:
+            with snh.bg('false') as proc:
+                exeter.assert_raises(subprocess.CalledProcessError, proc.run)
+
+    def test_bg_echo(self):
+        msg = 'Hello tasst'
+        with self as snh:
+            with snh.bg('echo', f'{msg}', capture=STDOUT) as proc:
+                res = proc.run()
+            exeter.assert_eq(res.stdout, msg.encode('utf-8') + b'\n')
+
+    def test_bg_timeout(self):
+        with self as snh:
+            with snh.bg('sleep', 'infinity') as proc:
+                exeter.assert_raises(subprocess.TimeoutExpired,
+                                     proc.run, timeout=0.1)
+                proc.terminate()
+
+    def test_bg_context_timeout(self):
+        with self as snh:
+            def run_timeout():
+                with snh.bg('sleep', 'infinity', context_timeout=0.1):
+                    pass
+            exeter.assert_raises(subprocess.TimeoutExpired, run_timeout)
+
+    SELFTESTS = [test_true, test_false, test_echo, test_timeout,
+                 test_bg_true, test_bg_false, test_bg_echo, test_bg_timeout,
+                 test_bg_context_timeout]
+
+    @classmethod
+    def selftest(cls, setup):
+        "Register standard snh tests for instance returned by setup"
+        for t in cls.SELFTESTS:
+            testid = f'{setup.__qualname__}|{t.__qualname__}'
+            exeter.register_pipe(testid, setup, t)
+
+
+class RealHost(SimNetHost):
+    """Represents the host on which the tests are running (as opposed
+    to some simulated host created by the tests)
+
+    """
+
+    def __init__(self):
+        super().__init__('REAL_HOST')
+
+    def hostify(self, *cmd, capable=False, **kwargs):
+        assert not capable, \
+            "BUG: Shouldn't run commands with capabilities on host"
+        return cmd, kwargs
+
+
+SimNetHost.selftest(RealHost)
-- 
@@ -0,0 +1,187 @@
+#! /usr/bin/env python3
+
+# SPDX-License-Identifier: GPL-2.0-or-later
+#
+# Copyright Red Hat
+# Author: David Gibson <david@gibson.dropbear.id.au>
+
+"""
+Test A Simple Socket Transport
+
+tasst/snh.py - Simulated network hosts for testing
+"""
+
+
+import contextlib
+import subprocess
+import sys
+
+import exeter
+
+
+STDOUT = 1
+
+
+class SnhProcess(contextlib.AbstractContextManager):
+    """
+    A background process running on a SimNetHost
+    """
+
+    def __init__(self, snh, *cmd, check=True, context_timeout=1.0, **kwargs):
+        self.snh = snh
+        self.cmd = cmd
+        self.check = check
+        self.context_timeout = float(context_timeout)
+
+        self.kwargs = kwargs
+
+    def __enter__(self):
+        self.popen = subprocess.Popen(self.cmd, **self.kwargs)
+        return self
+
+    def run(self, **kwargs):
+        stdout, stderr = self.popen.communicate(**kwargs)
+        cp = subprocess.CompletedProcess(self.popen.args,
+                                         self.popen.returncode,
+                                         stdout, stderr)
+        if self.check:
+            cp.check_returncode()
+        return cp
+
+    def terminate(self):
+        self.popen.terminate()
+
+    def kill(self):
+        self.popen.kill()
+
+    def __exit__(self, *exc_details):
+        try:
+            self.popen.wait(timeout=self.context_timeout)
+        except subprocess.TimeoutExpired as e:
+            self.terminate()
+            try:
+                self.popen.wait(timeout=self.context_timeout)
+            except subprocess.TimeoutExpired:
+                self.kill()
+            raise e
+
+
+class SimNetHost(contextlib.AbstractContextManager):
+    """
+    A (usually virtual or simulated) location where we can execute
+    commands and configure networks.
+
+    """
+
+    def __init__(self, name):
+        self.name = name   # For debugging
+
+    def hostify(self, *cmd, **kwargs):
+        raise NotImplementedError
+
+    def __enter__(self):
+        return self
+
+    def __exit__(self, *exc_details):
+        pass
+
+    def output(self, *cmd, **kwargs):
+        proc = self.fg(*cmd, capture=STDOUT, **kwargs)
+        return proc.stdout
+
+    def fg(self, *cmd, timeout=None, **kwargs):
+        # We don't use subprocess.run() because it kills without
+        # attempting to terminate on timeout
+        with self.bg(*cmd, **kwargs) as proc:
+            res = proc.run(timeout=timeout)
+        return res
+
+    def bg(self, *cmd, capture=None, **kwargs):
+        if capture == STDOUT:
+            kwargs['stdout'] = subprocess.PIPE
+        hostcmd, kwargs = self.hostify(*cmd, **kwargs)
+        proc = SnhProcess(self, *hostcmd, **kwargs)
+        print(f"SimNetHost {self.name}: Started {cmd} => {proc}",
+              file=sys.stderr)
+        return proc
+
+    # Internal tests
+    def test_true(self):
+        with self as snh:
+            snh.fg('true')
+
+    def test_false(self):
+        with self as snh:
+            exeter.assert_raises(subprocess.CalledProcessError,
+                                 snh.fg, 'false')
+
+    def test_echo(self):
+        msg = 'Hello tasst'
+        with self as snh:
+            out = snh.output('echo', f'{msg}')
+            exeter.assert_eq(out, msg.encode('utf-8') + b'\n')
+
+    def test_timeout(self):
+        with self as snh:
+            exeter.assert_raises(subprocess.TimeoutExpired, snh.fg,
+                                 'sleep', 'infinity', timeout=0.1, check=False)
+
+    def test_bg_true(self):
+        with self as snh:
+            with snh.bg('true'):
+                pass
+
+    def test_bg_false(self):
+        with self as snh:
+            with snh.bg('false') as proc:
+                exeter.assert_raises(subprocess.CalledProcessError, proc.run)
+
+    def test_bg_echo(self):
+        msg = 'Hello tasst'
+        with self as snh:
+            with snh.bg('echo', f'{msg}', capture=STDOUT) as proc:
+                res = proc.run()
+            exeter.assert_eq(res.stdout, msg.encode('utf-8') + b'\n')
+
+    def test_bg_timeout(self):
+        with self as snh:
+            with snh.bg('sleep', 'infinity') as proc:
+                exeter.assert_raises(subprocess.TimeoutExpired,
+                                     proc.run, timeout=0.1)
+                proc.terminate()
+
+    def test_bg_context_timeout(self):
+        with self as snh:
+            def run_timeout():
+                with snh.bg('sleep', 'infinity', context_timeout=0.1):
+                    pass
+            exeter.assert_raises(subprocess.TimeoutExpired, run_timeout)
+
+    SELFTESTS = [test_true, test_false, test_echo, test_timeout,
+                 test_bg_true, test_bg_false, test_bg_echo, test_bg_timeout,
+                 test_bg_context_timeout]
+
+    @classmethod
+    def selftest(cls, setup):
+        "Register standard snh tests for instance returned by setup"
+        for t in cls.SELFTESTS:
+            testid = f'{setup.__qualname__}|{t.__qualname__}'
+            exeter.register_pipe(testid, setup, t)
+
+
+class RealHost(SimNetHost):
+    """Represents the host on which the tests are running (as opposed
+    to some simulated host created by the tests)
+
+    """
+
+    def __init__(self):
+        super().__init__('REAL_HOST')
+
+    def hostify(self, *cmd, capable=False, **kwargs):
+        assert not capable, \
+            "BUG: Shouldn't run commands with capabilities on host"
+        return cmd, kwargs
+
+
+SimNetHost.selftest(RealHost)
-- 
2.45.2


  parent reply	other threads:[~2024-08-05 12:37 UTC|newest]

Thread overview: 31+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-08-05 12:36 [PATCH v2 00/22] RFC: Proof-of-concept based exeter+Avocado tests David Gibson
2024-08-05 12:36 ` [PATCH v2 01/22] nstool: Fix some trivial typos David Gibson
2024-08-05 12:36 ` [PATCH v2 02/22] nstool: Propagate SIGTERM to processes executed in the namespace David Gibson
2024-08-07  7:23   ` Stefano Brivio
2024-08-05 12:36 ` [PATCH v2 03/22] test: run static checkers with Avocado and JSON definitions David Gibson
2024-08-05 12:36 ` [PATCH v2 04/22] test: Extend make targets to run Avocado tests David Gibson
2024-08-05 12:36 ` [PATCH v2 05/22] test: Exeter based static tests David Gibson
2024-08-05 12:36 ` [PATCH v2 06/22] test: Add exeter+Avocado based build tests David Gibson
2024-08-06 22:11   ` Stefano Brivio
2024-08-07 10:51     ` David Gibson
2024-08-07 13:06       ` Stefano Brivio
2024-08-08  1:28         ` David Gibson
2024-08-08 22:55           ` Stefano Brivio
2024-08-05 12:36 ` [PATCH v2 07/22] test: Add linters for Python code David Gibson
2024-08-05 12:36 ` [PATCH v2 08/22] tasst: Introduce library of common test helpers David Gibson
2024-08-05 12:36 ` David Gibson [this message]
2024-08-05 12:36 ` [PATCH v2 10/22] tasst: Add helper to get network interface names for a site David Gibson
2024-08-05 12:36 ` [PATCH v2 11/22] tasst: Add helpers to run commands with nstool David Gibson
2024-08-05 12:36 ` [PATCH v2 12/22] tasst: Add ifup and network address helpers to SimNetHost David Gibson
2024-08-05 12:36 ` [PATCH v2 13/22] tasst: Helper for creating veth devices between namespaces David Gibson
2024-08-05 12:36 ` [PATCH v2 14/22] tasst: Add helper for getting MTU of a network interface David Gibson
2024-08-05 12:36 ` [PATCH v2 15/22] tasst: Add helper to wait for IP address to appear David Gibson
2024-08-05 12:36 ` [PATCH v2 16/22] tasst: Add helpers for getting a SimNetHost's routes David Gibson
2024-08-05 12:36 ` [PATCH v2 17/22] tasst: Helpers to test transferring data between sites David Gibson
2024-08-05 12:36 ` [PATCH v2 18/22] tasst: IP address allocation helpers David Gibson
2024-08-05 12:36 ` [PATCH v2 19/22] tasst: Helpers for testing NDP behaviour David Gibson
2024-08-05 12:36 ` [PATCH v2 20/22] tasst: Helpers for testing DHCP & DHCPv6 behaviour David Gibson
2024-08-05 12:37 ` [PATCH v2 21/22] tasst: Helpers to construct a simple network environment for tests David Gibson
2024-08-05 12:37 ` [PATCH v2 22/22] avocado: Convert basic pasta tests David Gibson
2024-08-06 12:28 ` [PATCH v2 00/22] RFC: Proof-of-concept based exeter+Avocado tests David Gibson
2024-08-07  8:17   ` Stefano Brivio

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240805123701.1720730-10-david@gibson.dropbear.id.au \
    --to=david@gibson.dropbear.id.au \
    --cc=crosa@redhat.com \
    --cc=passt-dev@passt.top \
    --cc=sbrivio@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://passt.top/passt

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for IMAP folder(s).