From: Stefano Brivio <sbrivio@redhat.com>
To: Laurent Vivier <lvivier@redhat.com>
Cc: passt-dev@passt.top
Subject: Re: [PATCH] util: In ASSERT(), use "fprintf(stderr, ...)" rather than err(...)
Date: Mon, 5 Aug 2024 16:34:23 +0200 [thread overview]
Message-ID: <20240805163423.58f602f7@elisabeth> (raw)
In-Reply-To: <20240805141027.1502569-1-lvivier@redhat.com>
On Mon, 5 Aug 2024 16:10:27 +0200
Laurent Vivier <lvivier@redhat.com> wrote:
> We use our own implementation of assert() because the glic implementation
> uses syscalls that aren't in our seccomp filter, see 7a8ed9459dfe
> ("Make assertions actually useful"). And we replaced it by an err(),
> followed by an abort() (that is also catched by seccomp).
> We don't have a coredump or a backtrace but we have at least the
> error message... only if logging is enabled.
...wait, err() should always end up somewhere (syslog, log file, or
stderr). If you pick stderr, and we closed stderr, then the error will
not be reported anywhere (or, possibly worse, on a socket that happens
to have number 2).
In which case are you losing messages?
--
Stefano
next prev parent reply other threads:[~2024-08-05 14:34 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-05 14:10 [PATCH] util: In ASSERT(), use "fprintf(stderr, ...)" rather than err(...) Laurent Vivier
2024-08-05 14:34 ` Stefano Brivio [this message]
2024-08-05 15:52 ` Laurent Vivier
2024-08-05 16:12 ` Stefano Brivio
2024-08-06 0:27 ` David Gibson
2024-08-06 9:27 ` Laurent Vivier
2024-08-06 11:43 ` Stefano Brivio
2024-08-06 12:28 ` David Gibson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240805163423.58f602f7@elisabeth \
--to=sbrivio@redhat.com \
--cc=lvivier@redhat.com \
--cc=passt-dev@passt.top \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://passt.top/passt
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for IMAP folder(s).