From: Stefano Brivio <sbrivio@redhat.com>
To: David Gibson <david@gibson.dropbear.id.au>
Cc: passt-dev@passt.top
Subject: Re: [PATCH 1/2] log: Make logfile_write() private
Date: Mon, 5 Aug 2024 21:02:02 +0200 [thread overview]
Message-ID: <20240805210202.72f81f30@elisabeth> (raw)
In-Reply-To: <20240729042300.280684-2-david@gibson.dropbear.id.au>
On Mon, 29 Jul 2024 14:22:59 +1000
David Gibson <david@gibson.dropbear.id.au> wrote:
> logfile_write() is not used outside log.c, nor should it be. It should
> only be used externall via the general logging functions. Make it static
> in log.c. To avoid forward declarations this requires moving a bunch of
> functions earlier in the file.
>
> Signed-off-by: David Gibson <david@gibson.dropbear.id.au>
Applied (1/2 only, for the moment).
--
Stefano
next prev parent reply other threads:[~2024-08-05 19:02 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-29 4:22 [PATCH 0/2] Avoid duplicated clock_gettime() in logging David Gibson
2024-07-29 4:22 ` [PATCH 1/2] log: Make logfile_write() private David Gibson
2024-08-05 19:02 ` Stefano Brivio [this message]
2024-07-29 4:23 ` [PATCH 2/2] log: Avoid duplicate calls to clock_gettime() David Gibson
2024-07-29 17:55 ` Stefano Brivio
2024-08-03 7:53 ` David Gibson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240805210202.72f81f30@elisabeth \
--to=sbrivio@redhat.com \
--cc=david@gibson.dropbear.id.au \
--cc=passt-dev@passt.top \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://passt.top/passt
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for IMAP folder(s).