From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by passt.top (Postfix) with ESMTP id B2D155A004F for ; Mon, 05 Aug 2024 21:02:11 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1722884530; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=FlsnBjY8FI/iHZQ3E2GhEMP5d31F3E7oZ22qYIvIgwY=; b=OxG1vDEoMcUgeA2KqNhPLLe7qLQZf6TlK8vy6wU2ofF8QFXiKvzfJ598Hk1joUI8+mYvF1 xGv1Dl342L9kya6LcK2ssEM2QETSD8oDn9ACj7iRX31mCQAqb5g2w3mtGRYBJ3jcKZDyl8 Dl+2NfZZjBmgKZLUe1gBAgdelE0DJuI= Received: from mail-wm1-f69.google.com (mail-wm1-f69.google.com [209.85.128.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-266-HVJGqAv4NyWQS8NdxZBFvw-1; Mon, 05 Aug 2024 15:02:08 -0400 X-MC-Unique: HVJGqAv4NyWQS8NdxZBFvw-1 Received: by mail-wm1-f69.google.com with SMTP id 5b1f17b1804b1-4280d8e685eso74757255e9.1 for ; Mon, 05 Aug 2024 12:02:07 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1722884526; x=1723489326; h=content-transfer-encoding:mime-version:organization:references :in-reply-to:message-id:subject:cc:to:from:date:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=FlsnBjY8FI/iHZQ3E2GhEMP5d31F3E7oZ22qYIvIgwY=; b=qTo3TJ0vDk6yE3ozNBNFR+kNlH25e6IjaKlkCbfP4GdsQcMtYKcxWvMM3y8UqobHAb 9kbLjR+Q3l78m8MlKCNocIEr4xcB/SnVD3miyegrlugldY+rsO2sa2p6wqLCsMYNv3Aj 9c6dgLRbfee4rcRqvGt0Hfo8Wzzrh09c06XJA8BSyUP1mhxnFfL7DJ8Oq+nL0m1t946m pfIBluX4h6EGXLtiuRKxjWRO6Y8VBcw2FyLibNxfKFZTU5b3zhekDHn+4IpMV7gic2oe BEEV+A7LuG3fOPQUsaf8kIDTpsGSuzjy9MyVeN0FDy0EaOGMgFO0dvyF/vorzRHoYyja y0+w== X-Gm-Message-State: AOJu0YzNxwbPuD3NWC0zUubzdkvx2edNBCzX9CGoj79ASlouoJ06YMGj cIJQhkY1Z6zHZB9uZkGXKakaaocJhGl3ycH8N2ZJiFaelKrzpZSPzwJ81QPYntos52T3YTBEB2W k0TJJX4P31wYXTZ6K4M5bDHK0mQU/klf6eJ0NjOM4nABY4eom+HTxUWslg5/U X-Received: by 2002:a05:600c:4e0a:b0:421:7bed:5274 with SMTP id 5b1f17b1804b1-428e6b037e6mr93090835e9.10.1722884526041; Mon, 05 Aug 2024 12:02:06 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFt9dntqE8wE2usKXn1HCqDBsTJ/r6p3+A8V87kOBPLmOqhpYCTtdvgAbHP0CQ6omw9XnsB8g== X-Received: by 2002:a05:600c:4e0a:b0:421:7bed:5274 with SMTP id 5b1f17b1804b1-428e6b037e6mr93090585e9.10.1722884525432; Mon, 05 Aug 2024 12:02:05 -0700 (PDT) Received: from maya.myfinge.rs (ifcgrfdd.trafficplex.cloud. [176.103.220.4]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-428ebbe18c0sm129211215e9.17.2024.08.05.12.02.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 05 Aug 2024 12:02:04 -0700 (PDT) Date: Mon, 5 Aug 2024 21:02:02 +0200 From: Stefano Brivio To: David Gibson Subject: Re: [PATCH 1/2] log: Make logfile_write() private Message-ID: <20240805210202.72f81f30@elisabeth> In-Reply-To: <20240729042300.280684-2-david@gibson.dropbear.id.au> References: <20240729042300.280684-1-david@gibson.dropbear.id.au> <20240729042300.280684-2-david@gibson.dropbear.id.au> Organization: Red Hat X-Mailer: Claws Mail 4.2.0 (GTK 3.24.41; x86_64-pc-linux-gnu) MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Message-ID-Hash: UKI46K7LD24DPIFMC6IG2ZEBRDAZ7KCZ X-Message-ID-Hash: UKI46K7LD24DPIFMC6IG2ZEBRDAZ7KCZ X-MailFrom: sbrivio@redhat.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: passt-dev@passt.top X-Mailman-Version: 3.3.8 Precedence: list List-Id: Development discussion and patches for passt Archived-At: Archived-At: List-Archive: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On Mon, 29 Jul 2024 14:22:59 +1000 David Gibson wrote: > logfile_write() is not used outside log.c, nor should it be. It should > only be used externall via the general logging functions. Make it static > in log.c. To avoid forward declarations this requires moving a bunch of > functions earlier in the file. > > Signed-off-by: David Gibson Applied (1/2 only, for the moment). -- Stefano