Re: [PATCH v2 00/22] RFC: Proof-of-concept based exeter+Avocado tests

[Stefano Brivio <sbrivio@redhat.com>]

On Tue, 6 Aug 2024 22:28:19 +1000
David Gibson <david@gibson.dropbear.id.au> wrote:

> On Mon, Aug 05, 2024 at 10:36:39PM +1000, David Gibson wrote:
> > Here's a rough proof of concept showing how we could run tests for
> > passt with Avocado and the exeter library I recently created.  It
> > includes Cleber's patch adding some basic Avocado tests and builds on
> > that.
> > 
> > The current draft is pretty janky:
> >  * The build rules to download and install the necessary pieces are messy
> >  * We create the Avocado job files from the exeter sources in the
> >    Makefile.  Ideally Avocado would eventually be extended to handle
> >    this itself
> >  * The names that Avocado sees for each test are overlong
> >  * There's some hacks to make sure things are executed from the
> >    right working directory
> > 
> > But, it's a starting point.
> > 
> > Stefano,
> > 
> > If you could look particularly at 6/22 and 22/22 which add the real
> > tests for passt/pasta, that would be great.  The more specific you can
> > be about what you find ugly about how the tests are written, then
> > better I can try to address that.
> > 
> > I suspect it will be easier to actually apply the series, then look at
> > the new test files (test/build/build.py, and test/pasta/pasta.py
> > particularly).  From there you can look at as much of the support
> > library as you need to, rather than digging through the actual patches
> > to look for that.  
> 
> Forgot to mention.  Patches 1 & 2 should be good to go regardless of
> what we do with the rest of the testing stuff.

Applied up to 2/22.

-- 
Stefano