From: David Gibson <david@gibson.dropbear.id.au>
To: passt-dev@passt.top, Stefano Brivio <sbrivio@redhat.com>
Cc: David Gibson <david@gibson.dropbear.id.au>
Subject: [PATCH 1/3] Correct inaccurate comments on ip[46]_ctx::addr
Date: Mon, 12 Aug 2024 19:53:53 +1000 [thread overview]
Message-ID: <20240812095355.1721876-2-david@gibson.dropbear.id.au> (raw)
In-Reply-To: <20240812095355.1721876-1-david@gibson.dropbear.id.au>
These fields are described as being an address for an external, routable
interface. That's not necessarily the case when using -a. But, more
importantly, saying where the value comes from is not as useful as what
it's used for. The real purpose of this field is as the address which we
assign to the guest via DHCP or --config-net.
Signed-off-by: David Gibson <david@gibson.dropbear.id.au>
---
passt.h | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/passt.h b/passt.h
index 12ae1b97..ef684037 100644
--- a/passt.h
+++ b/passt.h
@@ -91,7 +91,7 @@ enum passt_modes {
/**
* struct ip4_ctx - IPv4 execution context
- * @addr: IPv4 address for external, routable interface
+ * @addr: IPv4 address assigned to guest
* @addr_seen: Latest IPv4 address seen as source from tap
* @prefixlen: IPv4 prefix length (netmask)
* @gw: Default IPv4 gateway
@@ -121,7 +121,7 @@ struct ip4_ctx {
/**
* struct ip6_ctx - IPv6 execution context
- * @addr: IPv6 address for external, routable interface
+ * @addr: IPv6 address assigned to guest
* @addr_ll: Link-local IPv6 address on external, routable interface
* @addr_seen: Latest IPv6 global/site address seen as source from tap
* @addr_ll_seen: Latest IPv6 link-local address seen as source from tap
--
@@ -91,7 +91,7 @@ enum passt_modes {
/**
* struct ip4_ctx - IPv4 execution context
- * @addr: IPv4 address for external, routable interface
+ * @addr: IPv4 address assigned to guest
* @addr_seen: Latest IPv4 address seen as source from tap
* @prefixlen: IPv4 prefix length (netmask)
* @gw: Default IPv4 gateway
@@ -121,7 +121,7 @@ struct ip4_ctx {
/**
* struct ip6_ctx - IPv6 execution context
- * @addr: IPv6 address for external, routable interface
+ * @addr: IPv6 address assigned to guest
* @addr_ll: Link-local IPv6 address on external, routable interface
* @addr_seen: Latest IPv6 global/site address seen as source from tap
* @addr_ll_seen: Latest IPv6 link-local address seen as source from tap
--
2.46.0
next prev parent reply other threads:[~2024-08-12 9:54 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-12 9:53 [PATCH 0/3] Assorted fixes related to addressing David Gibson
2024-08-12 9:53 ` David Gibson [this message]
2024-08-12 9:53 ` [PATCH 2/3] conf: Delay handling -D option until after addresses are configured David Gibson
2024-08-12 9:53 ` [PATCH 3/3] fwd: Rework inconsistencies in translation of inbound flows David Gibson
2024-08-12 21:51 ` Stefano Brivio
2024-08-15 5:01 ` David Gibson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240812095355.1721876-2-david@gibson.dropbear.id.au \
--to=david@gibson.dropbear.id.au \
--cc=passt-dev@passt.top \
--cc=sbrivio@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://passt.top/passt
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for IMAP folder(s).