From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail.ozlabs.org (mail.ozlabs.org [IPv6:2404:9400:2221:ea00::3]) by passt.top (Postfix) with ESMTPS id 222DF5A031A for ; Mon, 12 Aug 2024 11:54:05 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gibson.dropbear.id.au; s=202312; t=1723456436; bh=WZ+KQvlhWbC6j5nT6aBk6PMdRkrUdBYk963G/NmQv4k=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=A/1bxp4zXMSbFR9lVSdc3IJpvZ+vhhAkRDw0UWYXemNR4qDghlT7t31rgegCiGBdz HA7f0ZXSe5ra3IHNjIllF/UiqbeX4ic+8UKUQRNRnaL4VjFmqDliQDDfUcm0HDBIsz qRvMg3Rd4g/XYMLvcmWznNtfU4uLmDgCAS/3bnpv2a7SMCugIBywPJggeRcjQF/AQV l67Lze4YN6iUIXo7khlHaFonqR3qfhBL3/Js1HWJaz2KIBNlLS4X0yyV1RGhhmWzRZ H/NbnPrD6EhLk3wvvS7RTkBa4W2VqjL1nlyY3tW7YNcJNNXYkcJ21JWYHCbo9U5IvL fu5+rWdQ6Q5jA== Received: by gandalf.ozlabs.org (Postfix, from userid 1007) id 4Wj8x05FvJz4x9F; Mon, 12 Aug 2024 19:53:56 +1000 (AEST) From: David Gibson To: passt-dev@passt.top, Stefano Brivio Subject: [PATCH 1/3] Correct inaccurate comments on ip[46]_ctx::addr Date: Mon, 12 Aug 2024 19:53:53 +1000 Message-ID: <20240812095355.1721876-2-david@gibson.dropbear.id.au> X-Mailer: git-send-email 2.46.0 In-Reply-To: <20240812095355.1721876-1-david@gibson.dropbear.id.au> References: <20240812095355.1721876-1-david@gibson.dropbear.id.au> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Message-ID-Hash: 5SKHADT2YDXU2FABMQ3HZ6RIXWAEYZFC X-Message-ID-Hash: 5SKHADT2YDXU2FABMQ3HZ6RIXWAEYZFC X-MailFrom: dgibson@gandalf.ozlabs.org X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: David Gibson X-Mailman-Version: 3.3.8 Precedence: list List-Id: Development discussion and patches for passt Archived-At: Archived-At: List-Archive: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: These fields are described as being an address for an external, routable interface. That's not necessarily the case when using -a. But, more importantly, saying where the value comes from is not as useful as what it's used for. The real purpose of this field is as the address which we assign to the guest via DHCP or --config-net. Signed-off-by: David Gibson --- passt.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/passt.h b/passt.h index 12ae1b97..ef684037 100644 --- a/passt.h +++ b/passt.h @@ -91,7 +91,7 @@ enum passt_modes { /** * struct ip4_ctx - IPv4 execution context - * @addr: IPv4 address for external, routable interface + * @addr: IPv4 address assigned to guest * @addr_seen: Latest IPv4 address seen as source from tap * @prefixlen: IPv4 prefix length (netmask) * @gw: Default IPv4 gateway @@ -121,7 +121,7 @@ struct ip4_ctx { /** * struct ip6_ctx - IPv6 execution context - * @addr: IPv6 address for external, routable interface + * @addr: IPv6 address assigned to guest * @addr_ll: Link-local IPv6 address on external, routable interface * @addr_seen: Latest IPv6 global/site address seen as source from tap * @addr_ll_seen: Latest IPv6 link-local address seen as source from tap -- 2.46.0