Re: [PATCH v2] ndp.c: Turn NDP responder into more declarative implementation

[Stefano Brivio <sbrivio@redhat.com>]

On Mon, 12 Aug 2024 22:33:38 +0300
AbdAlRahman Gad <abdobngad@gmail.com> wrote:

> - Add structs for NA, RA, NS, MTU, prefix info, option header,
>   link-layer address, RDNSS, DNSSL and link-layer for RA message.
> 
> - Turn NA message from purely imperative, going byte by byte,
>   to declarative by filling it's struct.
> 
> - Turn part of RA message into declarative.
> 
> - Move packet_add() to be before the call of ndp() in tap6_handler()
>   if the protocol of the packet  is ICMPv6.
> 
> - Add a pool of packets as an additional parameter to ndp().
> 
> - Check the size of NS packet with packet_get() before sending an NA
>   packet.
> 
> - Add documentation for the structs.
> 
> - Add an enum for NDP option types.
> 
> Link: https://bugs.passt.top/show_bug.cgi?id=21
> 
> Signed-off-by: AbdAlRahman Gad <abdobngad@gmail.com>

Applied, thanks!

I also closed https://bugs.passt.top/show_bug.cgi?id=21 as resolved.

-- 
Stefano