public inbox for passt-dev@passt.top
 help / color / mirror / code / Atom feed
From: David Gibson <david@gibson.dropbear.id.au>
To: passt-dev@passt.top, Stefano Brivio <sbrivio@redhat.com>
Cc: David Gibson <david@gibson.dropbear.id.au>
Subject: [PATCH 00/16] Cleanups and fixes related to "our" addresses
Date: Wed, 14 Aug 2024 14:30:34 +1000	[thread overview]
Message-ID: <20240814043050.4177037-1-david@gibson.dropbear.id.au> (raw)

There are some places where we have addresses that are "ours" in the
sense that they're local to passt on at least one interface.  But in
some cases it wasn't clear which addresses those were or how to use
them.  Make a number of renames, cleanups and small fixes related to
that.

..and also an assortment of slightly related things that I encountered
along the way.

Note that 1/16 is an important fix for a bug I introduced in the last
series I sent.  For the rest, apply as many as you're happy with and
I'll respin what's left as necessary.

David Gibson (16):
  conf: Don't ignore -t and -u options after -D
  treewide: Use "our address" instead of "forwarding address"
  util: Helper for formatting MAC addresses
  treewide: Rename MAC address fields for clarity
  treewide: Use struct assignment instead of memcpy() for IP addresses
  conf: Use array indices rather than pointers for DNS array slots
  conf: More accurately count entries added in get_dns()
  conf: Move DNS array bounds checks into add_dns[46]
  conf: Move adding of a nameserver from resolv.conf into subfunction
  conf: Correct setting of dns_match address in add_dns6()
  conf: Treat --dns addresses as guest visible addresses
  conf: Remove incorrect initialisation of addr_ll_seen
  util: Correct sock_l4() binding for link local addresses
  treewide: Change misleading 'addr_ll' name
  Clarify which addresses in ip[46]_ctx are meaningful where
  Initialise our_tap_ll to ip6.gw when suitable

 arp.c          |   4 +-
 conf.c         | 181 ++++++++++++++++++++++++++++---------------------
 dhcp.c         |   5 +-
 dhcpv6.c       |  21 +++---
 flow.c         |  74 ++++++++++----------
 flow.h         |  18 ++---
 fwd.c          |  70 +++++++++----------
 icmp.c         |   4 +-
 ndp.c          |   9 +--
 passt.1        |  14 ++--
 passt.c        |   2 +-
 passt.h        |  22 +++---
 pasta.c        |   8 +--
 tap.c          |  12 ++--
 tcp.c          |  33 ++++-----
 tcp_internal.h |   2 +-
 udp.c          |  12 ++--
 util.c         |  22 +++++-
 util.h         |   3 +
 19 files changed, 285 insertions(+), 231 deletions(-)

-- 
2.46.0


             reply	other threads:[~2024-08-14  4:30 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-08-14  4:30 David Gibson [this message]
2024-08-14  4:30 ` [PATCH 01/16] conf: Don't ignore -t and -u options after -D David Gibson
2024-08-14 12:18   ` Stefano Brivio
2024-08-14  4:30 ` [PATCH 02/16] treewide: Use "our address" instead of "forwarding address" David Gibson
2024-08-14  4:30 ` [PATCH 03/16] util: Helper for formatting MAC addresses David Gibson
2024-08-14  4:30 ` [PATCH 04/16] treewide: Rename MAC address fields for clarity David Gibson
2024-08-14  4:30 ` [PATCH 05/16] treewide: Use struct assignment instead of memcpy() for IP addresses David Gibson
2024-08-14  4:30 ` [PATCH 06/16] conf: Use array indices rather than pointers for DNS array slots David Gibson
2024-08-14  4:30 ` [PATCH 07/16] conf: More accurately count entries added in get_dns() David Gibson
2024-08-14  4:30 ` [PATCH 08/16] conf: Move DNS array bounds checks into add_dns[46] David Gibson
2024-08-14  4:30 ` [PATCH 09/16] conf: Move adding of a nameserver from resolv.conf into subfunction David Gibson
2024-08-14  4:30 ` [PATCH 10/16] conf: Correct setting of dns_match address in add_dns6() David Gibson
2024-08-14  4:30 ` [PATCH 11/16] conf: Treat --dns addresses as guest visible addresses David Gibson
2024-08-14  4:30 ` [PATCH 12/16] conf: Remove incorrect initialisation of addr_ll_seen David Gibson
2024-08-14  4:30 ` [PATCH 13/16] util: Correct sock_l4() binding for link local addresses David Gibson
2024-08-14  4:30 ` [PATCH 14/16] treewide: Change misleading 'addr_ll' name David Gibson
2024-08-14  4:30 ` [PATCH 15/16] Clarify which addresses in ip[46]_ctx are meaningful where David Gibson
2024-08-14  4:30 ` [PATCH 16/16] Initialise our_tap_ll to ip6.gw when suitable David Gibson
2024-08-14  4:39   ` David Gibson
2024-08-14  5:03 ` [PATCH 00/16] Cleanups and fixes related to "our" addresses David Gibson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240814043050.4177037-1-david@gibson.dropbear.id.au \
    --to=david@gibson.dropbear.id.au \
    --cc=passt-dev@passt.top \
    --cc=sbrivio@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://passt.top/passt

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for IMAP folder(s).