From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail.ozlabs.org (gandalf.ozlabs.org [150.107.74.76]) by passt.top (Postfix) with ESMTPS id 3BE845A0319 for ; Wed, 14 Aug 2024 06:30:57 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gibson.dropbear.id.au; s=202312; t=1723609853; bh=O5kRJHClIsgRsm/2hx82xlYAJAad+2iKmAU6lyoLVSw=; h=From:To:Cc:Subject:Date:From; b=DhQKFu4ZiTkuG6qUjZkuNHbcY6fyZ9xg1/haAQ0pLcKvSO3FvTyYFifl+2BpAkGpm Eqb8wrATO2OhS5s+BeiiJ+LQaBpEyuMj+qo3GBsNaEVwRZgaxaBX5vZHxDmlHbMsjD UGpS77T6IkMCdE/zv81OgTeiYWyiSiY7VfIYNzgQZfSSeMwNMHwv535M1gRQI3Y6NG IUxv5q7W37eKepvyLkSYl7siK6IV1mZDNTMD6cWcOeFyrpNY1LBHUwMrV17Tw4vZHn mBX9QhEHrcu3zpi36Bz+3DlZyQkaPiXE1CW/XmVwMPy1f/3ZxAemK/fKEwDbr0mPlc iNuZNjyRs4aCQ== Received: by gandalf.ozlabs.org (Postfix, from userid 1007) id 4WkFgK1Phsz4x3q; Wed, 14 Aug 2024 14:30:53 +1000 (AEST) From: David Gibson To: passt-dev@passt.top, Stefano Brivio Subject: [PATCH 00/16] Cleanups and fixes related to "our" addresses Date: Wed, 14 Aug 2024 14:30:34 +1000 Message-ID: <20240814043050.4177037-1-david@gibson.dropbear.id.au> X-Mailer: git-send-email 2.46.0 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Message-ID-Hash: WWMWTWAIWX6RSTJQDSKSAVXDSWLJC2OY X-Message-ID-Hash: WWMWTWAIWX6RSTJQDSKSAVXDSWLJC2OY X-MailFrom: dgibson@gandalf.ozlabs.org X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: David Gibson X-Mailman-Version: 3.3.8 Precedence: list List-Id: Development discussion and patches for passt Archived-At: Archived-At: List-Archive: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: There are some places where we have addresses that are "ours" in the sense that they're local to passt on at least one interface. But in some cases it wasn't clear which addresses those were or how to use them. Make a number of renames, cleanups and small fixes related to that. ..and also an assortment of slightly related things that I encountered along the way. Note that 1/16 is an important fix for a bug I introduced in the last series I sent. For the rest, apply as many as you're happy with and I'll respin what's left as necessary. David Gibson (16): conf: Don't ignore -t and -u options after -D treewide: Use "our address" instead of "forwarding address" util: Helper for formatting MAC addresses treewide: Rename MAC address fields for clarity treewide: Use struct assignment instead of memcpy() for IP addresses conf: Use array indices rather than pointers for DNS array slots conf: More accurately count entries added in get_dns() conf: Move DNS array bounds checks into add_dns[46] conf: Move adding of a nameserver from resolv.conf into subfunction conf: Correct setting of dns_match address in add_dns6() conf: Treat --dns addresses as guest visible addresses conf: Remove incorrect initialisation of addr_ll_seen util: Correct sock_l4() binding for link local addresses treewide: Change misleading 'addr_ll' name Clarify which addresses in ip[46]_ctx are meaningful where Initialise our_tap_ll to ip6.gw when suitable arp.c | 4 +- conf.c | 181 ++++++++++++++++++++++++++++--------------------- dhcp.c | 5 +- dhcpv6.c | 21 +++--- flow.c | 74 ++++++++++---------- flow.h | 18 ++--- fwd.c | 70 +++++++++---------- icmp.c | 4 +- ndp.c | 9 +-- passt.1 | 14 ++-- passt.c | 2 +- passt.h | 22 +++--- pasta.c | 8 +-- tap.c | 12 ++-- tcp.c | 33 ++++----- tcp_internal.h | 2 +- udp.c | 12 ++-- util.c | 22 +++++- util.h | 3 + 19 files changed, 285 insertions(+), 231 deletions(-) -- 2.46.0