From: David Gibson <david@gibson.dropbear.id.au>
To: passt-dev@passt.top, Stefano Brivio <sbrivio@redhat.com>
Cc: David Gibson <david@gibson.dropbear.id.au>
Subject: [PATCH 10/16] conf: Correct setting of dns_match address in add_dns6()
Date: Wed, 14 Aug 2024 14:30:44 +1000 [thread overview]
Message-ID: <20240814043050.4177037-11-david@gibson.dropbear.id.au> (raw)
In-Reply-To: <20240814043050.4177037-1-david@gibson.dropbear.id.au>
add_dns6() (but not add_dns4()) has a bug setting dns_match: it sets it to
the given address, rather than the gateway address. This is doubly wrong:
- We've just established the given address is a host loopback address
the guest can't access
- We've just set ip6.dns[] to tell the guest to use the gateway address,
so it won't use the dns_match address we're setting
Correct this to use the gateway address, like IPv4.
Signed-off-by: David Gibson <david@gibson.dropbear.id.au>
---
conf.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/conf.c b/conf.c
index 1b57af71..cb462b09 100644
--- a/conf.c
+++ b/conf.c
@@ -408,7 +408,7 @@ static unsigned add_dns6(struct ctx *c, struct in6_addr *addr, unsigned idx)
added++;
if (IN6_IS_ADDR_UNSPECIFIED(&c->ip6.dns_match))
- c->ip6.dns_match = *addr;
+ c->ip6.dns_match = c->ip6.gw;
}
} else {
c->ip6.dns[idx] = *addr;
--
@@ -408,7 +408,7 @@ static unsigned add_dns6(struct ctx *c, struct in6_addr *addr, unsigned idx)
added++;
if (IN6_IS_ADDR_UNSPECIFIED(&c->ip6.dns_match))
- c->ip6.dns_match = *addr;
+ c->ip6.dns_match = c->ip6.gw;
}
} else {
c->ip6.dns[idx] = *addr;
--
2.46.0
next prev parent reply other threads:[~2024-08-14 4:31 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-14 4:30 [PATCH 00/16] Cleanups and fixes related to "our" addresses David Gibson
2024-08-14 4:30 ` [PATCH 01/16] conf: Don't ignore -t and -u options after -D David Gibson
2024-08-14 12:18 ` Stefano Brivio
2024-08-14 4:30 ` [PATCH 02/16] treewide: Use "our address" instead of "forwarding address" David Gibson
2024-08-14 4:30 ` [PATCH 03/16] util: Helper for formatting MAC addresses David Gibson
2024-08-14 4:30 ` [PATCH 04/16] treewide: Rename MAC address fields for clarity David Gibson
2024-08-14 4:30 ` [PATCH 05/16] treewide: Use struct assignment instead of memcpy() for IP addresses David Gibson
2024-08-14 4:30 ` [PATCH 06/16] conf: Use array indices rather than pointers for DNS array slots David Gibson
2024-08-14 4:30 ` [PATCH 07/16] conf: More accurately count entries added in get_dns() David Gibson
2024-08-14 4:30 ` [PATCH 08/16] conf: Move DNS array bounds checks into add_dns[46] David Gibson
2024-08-14 4:30 ` [PATCH 09/16] conf: Move adding of a nameserver from resolv.conf into subfunction David Gibson
2024-08-14 4:30 ` David Gibson [this message]
2024-08-14 4:30 ` [PATCH 11/16] conf: Treat --dns addresses as guest visible addresses David Gibson
2024-08-14 4:30 ` [PATCH 12/16] conf: Remove incorrect initialisation of addr_ll_seen David Gibson
2024-08-14 4:30 ` [PATCH 13/16] util: Correct sock_l4() binding for link local addresses David Gibson
2024-08-14 4:30 ` [PATCH 14/16] treewide: Change misleading 'addr_ll' name David Gibson
2024-08-14 4:30 ` [PATCH 15/16] Clarify which addresses in ip[46]_ctx are meaningful where David Gibson
2024-08-14 4:30 ` [PATCH 16/16] Initialise our_tap_ll to ip6.gw when suitable David Gibson
2024-08-14 4:39 ` David Gibson
2024-08-14 5:03 ` [PATCH 00/16] Cleanups and fixes related to "our" addresses David Gibson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240814043050.4177037-11-david@gibson.dropbear.id.au \
--to=david@gibson.dropbear.id.au \
--cc=passt-dev@passt.top \
--cc=sbrivio@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://passt.top/passt
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for IMAP folder(s).