From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail.ozlabs.org (mail.ozlabs.org [IPv6:2404:9400:2221:ea00::3]) by passt.top (Postfix) with ESMTPS id 4353F5A0320 for ; Wed, 14 Aug 2024 06:31:01 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gibson.dropbear.id.au; s=202312; t=1723609853; bh=ac5isedstVwZdSrkR1z9ULja2m5LDC0i3jDgdgrs5g4=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=sRYkjAx8sryBH0U1CIka3xbUOo6QKGGzNNB+4MAJ2yGUBXwRSymZ3kW4Rv7LbaKJJ PZw0nhilr1u/GIHXIQagz4DUfb1rzL8SuLrpBIXrHk0Vr5g7VFdse/4aKcTuESIxFj Cn0iHzixijaErRaeHGlG7qneA0ToO9Qo4PX1T8TkUmyLIHltzFXp68NXIH9/IYCLBg DSnlW7vRJR7SZpafNQxVe8N6qN8o5yxSgUv0bxSMAukAXlkctNkzxndBC9Ht2Zlxyp GJNho3OCjzyxcS9qrB7jwC7FIl4PXjUmfVy6HecAmgkggXWJsMKi/gE0mt482VI24M B9qLJtabFTcUA== Received: by gandalf.ozlabs.org (Postfix, from userid 1007) id 4WkFgK2LtWz4xDL; Wed, 14 Aug 2024 14:30:53 +1000 (AEST) From: David Gibson To: passt-dev@passt.top, Stefano Brivio Subject: [PATCH 12/16] conf: Remove incorrect initialisation of addr_ll_seen Date: Wed, 14 Aug 2024 14:30:46 +1000 Message-ID: <20240814043050.4177037-13-david@gibson.dropbear.id.au> X-Mailer: git-send-email 2.46.0 In-Reply-To: <20240814043050.4177037-1-david@gibson.dropbear.id.au> References: <20240814043050.4177037-1-david@gibson.dropbear.id.au> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Message-ID-Hash: USICAOW7BASUVYV3WGNX5URGWNFHK5GI X-Message-ID-Hash: USICAOW7BASUVYV3WGNX5URGWNFHK5GI X-MailFrom: dgibson@gandalf.ozlabs.org X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: David Gibson X-Mailman-Version: 3.3.8 Precedence: list List-Id: Development discussion and patches for passt Archived-At: Archived-At: List-Archive: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: Despite the names, addr_ll_seen does not relate to addr_ll the same way addr_see relates to addr. addr_ll_seen is an observed address from the guest, whereas addr_ll is *our* link-local address for use on the tap link when we can't use an external endpoint address. It's used both for passt provided services (DHCPv6, NDP) and in some cases for connections from addresses the guest can't access. Signed-off-by: David Gibson --- conf.c | 1 - 1 file changed, 1 deletion(-) diff --git a/conf.c b/conf.c index fa6d90ef..09e97744 100644 --- a/conf.c +++ b/conf.c @@ -720,7 +720,6 @@ static unsigned int conf_ip6(unsigned int ifi, } ip6->addr_seen = ip6->addr; - ip6->addr_ll_seen = ip6->addr_ll; if (MAC_IS_ZERO(mac)) { rc = nl_link_get_mac(nl_sock, ifi, mac); -- 2.46.0