From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: passt.top; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: passt.top; dkim=pass (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=S5ZngB44; dkim-atps=neutral Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by passt.top (Postfix) with ESMTP id 6AD775A0269 for ; Wed, 14 Aug 2024 14:18:18 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1723637897; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=5WeWlym4M6/1N/fFdDZE6O9GAX6NVFQ6b2sz3Bq9Z7Q=; b=S5ZngB44DoJAht2lG5u4JpiImoz0vakLdV7wx3krN5jPylO+kbA5zp96We3ZUF8vN1uHsi Qf4WPuf2gqq74jNLz3mfb4ogNMIgG/64Eg5Kq3c4YyGmYdgmHkyes5yQtY1bf2JVwKcrq9 WVt5ENFtiGcIWeClZsJC4yIAJK+jzts= Received: from mail-wr1-f70.google.com (mail-wr1-f70.google.com [209.85.221.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-224-olrj9whVNfCGvlffo8n7dA-1; Wed, 14 Aug 2024 08:18:13 -0400 X-MC-Unique: olrj9whVNfCGvlffo8n7dA-1 Received: by mail-wr1-f70.google.com with SMTP id ffacd0b85a97d-3686658856fso3426198f8f.0 for ; Wed, 14 Aug 2024 05:18:13 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1723637891; x=1724242691; h=content-transfer-encoding:mime-version:organization:references :in-reply-to:message-id:subject:cc:to:from:date:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=5WeWlym4M6/1N/fFdDZE6O9GAX6NVFQ6b2sz3Bq9Z7Q=; b=gqsSxng+Q2GfTQkEfYMV8Syx1yRAUKVmqOA06jFmptNLQCcyJ+Wmxc6KiaGffQa0r5 sbGZVKmkhplzjnMIXljP4mVBEJ17kQOEokKVFH35C/wr1kAuyOCkMP0rgtc6WMLhKFRM w7klDN9zJaP2dKr/B0I57h07JiimofaKFAuG38XD0/F9AhuuPvzI2MzY8VEPSi2IrCz+ KZzoy2yYpUxQc8zCR7nsACCPxSO3J96RuFrOmigZQjrX1eHyQzdGxfFacX+4SPvJodmQ LrTgpzuyvM/TZjVxVcgHWx3Tt+GmBNTWpUXbvXuy7byoRkBhI487oeNIBuPKgasLE0LQ 6MLg== X-Gm-Message-State: AOJu0Yy4nDzsYtMKWaH6vdz47A7lOMZsQ6ieqLJPyzGMbMH7FHsel8v/ +h6a9ezXwKEFa7/HEcX00D0gmDWZ5JOuW+u/8amTdL3wiS8fWtCFKXzxRTCIQSac4BaC/DSxzav YqvhYzVHDtoQxr2yDSBD4Cm0mcpE3SOhinUufVuBg1Rpne4H4+TpQ9KPtYA== X-Received: by 2002:adf:a3dd:0:b0:368:584c:3341 with SMTP id ffacd0b85a97d-371777b283cmr1583344f8f.35.1723637891356; Wed, 14 Aug 2024 05:18:11 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHApa+pqBT0dkl3CSm+w4vr81IUTWBlvmQtdcHTu7/rjq64JhNgZ1SKwZ+HwfnHzDLCemBy+w== X-Received: by 2002:adf:a3dd:0:b0:368:584c:3341 with SMTP id ffacd0b85a97d-371777b283cmr1583324f8f.35.1723637890676; Wed, 14 Aug 2024 05:18:10 -0700 (PDT) Received: from maya.myfinge.rs (ifcgrfdd.trafficplex.cloud. [176.103.220.4]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-36e4ebd3100sm12503639f8f.95.2024.08.14.05.18.09 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 14 Aug 2024 05:18:10 -0700 (PDT) Date: Wed, 14 Aug 2024 14:18:08 +0200 From: Stefano Brivio To: David Gibson Subject: Re: [PATCH 01/16] conf: Don't ignore -t and -u options after -D Message-ID: <20240814141808.26cc1440@elisabeth> In-Reply-To: <20240814043050.4177037-2-david@gibson.dropbear.id.au> References: <20240814043050.4177037-1-david@gibson.dropbear.id.au> <20240814043050.4177037-2-david@gibson.dropbear.id.au> Organization: Red Hat X-Mailer: Claws Mail 4.2.0 (GTK 3.24.41; x86_64-pc-linux-gnu) MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Message-ID-Hash: UC6AZTFQZ4Y4NRKWDJLDGGNMHUATC3IH X-Message-ID-Hash: UC6AZTFQZ4Y4NRKWDJLDGGNMHUATC3IH X-MailFrom: sbrivio@redhat.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: passt-dev@passt.top X-Mailman-Version: 3.3.8 Precedence: list List-Id: Development discussion and patches for passt Archived-At: Archived-At: List-Archive: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On Wed, 14 Aug 2024 14:30:35 +1000 David Gibson wrote: > f6d5a5239264 moved handling of -D into a later loop. However as a side > effect it moved this from a switch block to an if block. I left a couple > of 'break' statements that don't make sense in the new context. They > should be 'continue' so that we go onto the next option, rather than > leaving the loop entirely. > > Fixes: f6d5a5239264 ("conf: Delay handling -D option until after...") > > Signed-off-by: David Gibson Applied (just this one). -- Stefano