From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: passt.top; dmarc=none (p=none dis=none) header.from=gibson.dropbear.id.au Authentication-Results: passt.top; dkim=fail reason="key not found in DNS" header.d=gibson.dropbear.id.au header.i=@gibson.dropbear.id.au header.a=rsa-sha256 header.s=202312 header.b=XIRuWjnB; dkim-atps=neutral Received: from mail.ozlabs.org (mail.ozlabs.org [IPv6:2404:9400:2221:ea00::3]) by passt.top (Postfix) with ESMTPS id 4780E5A0275 for ; Fri, 16 Aug 2024 07:40:17 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gibson.dropbear.id.au; s=202312; t=1723786807; bh=NGRACvFXmim4Ki1WoKkbzK8KVSnKWygAUuwE8lz+jc8=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=XIRuWjnBEUVmeBFgdkomDIvVuh2rMSxl6aFEYOKhZqQiQYNI79e+kDYtVyZMtlm0r mIySepYgCd70/arooKGLQ3Y2CB7xRmrNi1b7QUcMojbttgCqX9Ol6e41Qxo2hwPobE 6Eb3eF3wxHvAxiwsmmtLRqTxltHB3ZN9RNWFDXkHtwZJ7HHc6rSnaCJRx7GELVLBzR TadlIeRQGPZRdlgA1OephSD4TAYPpNeRvPXmXP6ffDcC8aken+4L7cRDT7k0sZawNy PUyQ8CKZtYqWz0HyNPYAi4Xzo+2yyZ2L/lJT6uap+XLw+iQxoWM9ZPq6+R7BgZfx/x qHjPsclmTYTNQ== Received: by gandalf.ozlabs.org (Postfix, from userid 1007) id 4WlW6H0fhqz4x5J; Fri, 16 Aug 2024 15:40:07 +1000 (AEST) From: David Gibson To: Stefano Brivio , passt-dev@passt.top Subject: [PATCH 11/22] conf: Remove incorrect initialisation of addr_ll_seen Date: Fri, 16 Aug 2024 15:39:52 +1000 Message-ID: <20240816054004.1335006-12-david@gibson.dropbear.id.au> X-Mailer: git-send-email 2.46.0 In-Reply-To: <20240816054004.1335006-1-david@gibson.dropbear.id.au> References: <20240816054004.1335006-1-david@gibson.dropbear.id.au> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Message-ID-Hash: N2EC3NCOBWNR2LPQSSDB3OUSB6ZEIZYN X-Message-ID-Hash: N2EC3NCOBWNR2LPQSSDB3OUSB6ZEIZYN X-MailFrom: dgibson@gandalf.ozlabs.org X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: Paul Holzinger , David Gibson X-Mailman-Version: 3.3.8 Precedence: list List-Id: Development discussion and patches for passt Archived-At: Archived-At: List-Archive: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: Despite the names, addr_ll_seen does not relate to addr_ll the same way addr_see relates to addr. addr_ll_seen is an observed address from the guest, whereas addr_ll is *our* link-local address for use on the tap link when we can't use an external endpoint address. It's used both for passt provided services (DHCPv6, NDP) and in some cases for connections from addresses the guest can't access. Signed-off-by: David Gibson --- conf.c | 1 - 1 file changed, 1 deletion(-) diff --git a/conf.c b/conf.c index 3c102bcf..e5b5263f 100644 --- a/conf.c +++ b/conf.c @@ -720,7 +720,6 @@ static unsigned int conf_ip6(unsigned int ifi, } ip6->addr_seen = ip6->addr; - ip6->addr_ll_seen = ip6->addr_ll; if (MAC_IS_ZERO(mac)) { rc = nl_link_get_mac(nl_sock, ifi, mac); -- 2.46.0