Re: [PATCH 00/22] RFC: Allow configuration of special case NATs

[Stefano Brivio <sbrivio@redhat.com>]

On Fri, 16 Aug 2024 16:45:14 +0200
Paul Holzinger <pholzing@redhat.com> wrote:

> Hi,
> 
> On 16/08/2024 07:39, David Gibson wrote:
> > Based on Stefano's recent patch for faster tests.
> >
> > Allow the user to specify which addresses are translated when used by
> > the guest, rather than always being the gateway address or nothing.
> > We also allow this remapping to go to the host's global address (more
> > precisely the address assigned to the guest) rather than just host
> > loopback.
> >
> > Suggestions for better names for the new options in patches 20 & 22
> > are most welcome.
> >
> > Along the way to implementing that make many changes to clarify what
> > various addresses we track mean, fixing a number of small bugs as
> > well.
> >
> > NOTE: there is a bug in 21/22 which breaks some of the passt_tcp perf
> > tests.  I haven't managed to figure out why it's causing the problem,
> > or even what the exact triggering conditions are (running the single
> > stalling iperf alone doesn't do it).  Have to wrap up for today, so I
> > thought I'd get this out for review anyway.
> >
> > Paul, amongst other things, I think this will allow podman to
> > (finally) nicely address #19213, picking an address to remap to the
> > host's external address with --nat-guest-addr, much like it already
> > uses --dns-forward.  
> 
> Thanks this looks promising. I will try to test it out next week.
> 
> No strong feelings about the naming but how about s/--nat/--map/ for the 
> options?

Exactly the same as I suggested offline a while ago. :) I think it's
easier to understand what it does, that way.

-- 
Stefano