From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: passt.top; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: passt.top; dkim=pass (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=fJIARKTN; dkim-atps=neutral Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by passt.top (Postfix) with ESMTP id 91CA75A0275 for ; Fri, 16 Aug 2024 17:03:31 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1723820610; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=ADfWi0qgs8zYrUXSyJJD4+5TXLHj4kNTGael5sUKBrs=; b=fJIARKTNvBbzmS39Mw3FpbgempeT69C29zvBIB98CKLeoGpobjeu4sVhBbarfIDnZKGely uDDUYG0QE6zn0i51cAxPOFr4QhDFa4NO1yFnDHlstgyFWHBP+5s+v1ubUpYdt/41zSYAlR Z2nGA4A1E7+5LeeVE/jpvmCqij2fdyk= Received: from mail-pf1-f200.google.com (mail-pf1-f200.google.com [209.85.210.200]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-67-1GsdSEnvM3K13R9R7affXA-1; Fri, 16 Aug 2024 11:03:29 -0400 X-MC-Unique: 1GsdSEnvM3K13R9R7affXA-1 Received: by mail-pf1-f200.google.com with SMTP id d2e1a72fcca58-71065f49b10so2117207b3a.0 for ; Fri, 16 Aug 2024 08:03:28 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1723820608; x=1724425408; h=content-transfer-encoding:mime-version:organization:references :in-reply-to:message-id:subject:cc:to:from:date:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=ADfWi0qgs8zYrUXSyJJD4+5TXLHj4kNTGael5sUKBrs=; b=KzFZOb/7A57hLg1+ebs1BzjGi2AKaYM+6MCPYT4W9Ct9Z9tRg4Njp0i1fjlI697yjI FqAsetJiqNyiVftCWczCXD1FoEJP2CAuoRqvHzsF9cvEjfZjPx6WJjeVMPkBVdF1IeFt w9GSyNCBKME0i8fxOdwSzDbZMmvqXTLwovyb2P33J0WLed6/MHweqa70QI2Gx4PHbgjV piWvQXLytwM6Gt6lIf8UuhjNgejX26LWW/oeyOHy7+wXsMqFztrh4JAnfw/KOY7t/453 D5xltBU5utCdYynXxvvIIhwoR50islJvKIQnRjiwJsTN0Sv3dUQW3y3dgp2NLxGh5nrR BDEQ== X-Forwarded-Encrypted: i=1; AJvYcCUHDFixsRrT+5YpUMG7tEEGgTENIq6YkUsE+zf0nm2KRY0iknoYYd4OlBkdOfD0QmZhphirYBs02IntJlMpz7pGEjQt X-Gm-Message-State: AOJu0YwqREBogWQ18hi4Vk3iHZg/6MwgTrsg4Vef7UBLrX6lO5EeBXUQ mV3gm6TyprfjW6RrW7eRY0IcGbW5kkYLTAqeQ1gnrePnJOy64NJeFzmZHS0fEhB7G5HA/fgvAH+ WMww8Ntpz73iaJpW/vidhyOpD0jp+IOpK/ifbtW7sMucv2U6Hiw== X-Received: by 2002:a05:6a00:a17:b0:706:58ef:613 with SMTP id d2e1a72fcca58-713c525d5e5mr4292527b3a.27.1723820607977; Fri, 16 Aug 2024 08:03:27 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHXRu9tMLBipYieDc9BorBYoOl/cvMtpsm7qm8pzgCmRx/eWN7W8+bt+6EsZ8gN+10g+/P5Fg== X-Received: by 2002:a05:6a00:a17:b0:706:58ef:613 with SMTP id d2e1a72fcca58-713c525d5e5mr4292482b3a.27.1723820607552; Fri, 16 Aug 2024 08:03:27 -0700 (PDT) Received: from maya.myfinge.rs (ifcgrfdd.trafficplex.cloud. [176.103.220.4]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-7127add6e46sm2814537b3a.17.2024.08.16.08.03.26 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 16 Aug 2024 08:03:26 -0700 (PDT) Date: Fri, 16 Aug 2024 17:03:22 +0200 From: Stefano Brivio To: Paul Holzinger Subject: Re: [PATCH 00/22] RFC: Allow configuration of special case NATs Message-ID: <20240816170322.7b9cd85b@elisabeth> In-Reply-To: References: <20240816054004.1335006-1-david@gibson.dropbear.id.au> Organization: Red Hat X-Mailer: Claws Mail 4.2.0 (GTK 3.24.41; x86_64-pc-linux-gnu) MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Message-ID-Hash: 377WLJQIAHSEPDTTGXAD4SETORU2DVM2 X-Message-ID-Hash: 377WLJQIAHSEPDTTGXAD4SETORU2DVM2 X-MailFrom: sbrivio@redhat.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: David Gibson , passt-dev@passt.top X-Mailman-Version: 3.3.8 Precedence: list List-Id: Development discussion and patches for passt Archived-At: Archived-At: List-Archive: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On Fri, 16 Aug 2024 16:45:14 +0200 Paul Holzinger wrote: > Hi, > > On 16/08/2024 07:39, David Gibson wrote: > > Based on Stefano's recent patch for faster tests. > > > > Allow the user to specify which addresses are translated when used by > > the guest, rather than always being the gateway address or nothing. > > We also allow this remapping to go to the host's global address (more > > precisely the address assigned to the guest) rather than just host > > loopback. > > > > Suggestions for better names for the new options in patches 20 & 22 > > are most welcome. > > > > Along the way to implementing that make many changes to clarify what > > various addresses we track mean, fixing a number of small bugs as > > well. > > > > NOTE: there is a bug in 21/22 which breaks some of the passt_tcp perf > > tests. I haven't managed to figure out why it's causing the problem, > > or even what the exact triggering conditions are (running the single > > stalling iperf alone doesn't do it). Have to wrap up for today, so I > > thought I'd get this out for review anyway. > > > > Paul, amongst other things, I think this will allow podman to > > (finally) nicely address #19213, picking an address to remap to the > > host's external address with --nat-guest-addr, much like it already > > uses --dns-forward. > > Thanks this looks promising. I will try to test it out next week. > > No strong feelings about the naming but how about s/--nat/--map/ for the > options? Exactly the same as I suggested offline a while ago. :) I think it's easier to understand what it does, that way. -- Stefano