From: Stefano Brivio <sbrivio@redhat.com>
To: David Gibson <david@gibson.dropbear.id.au>
Cc: passt-dev@passt.top, Paul Holzinger <pholzing@redhat.com>
Subject: Re: [PATCH 03/22] treewide: Rename MAC address fields for clarity
Date: Sun, 18 Aug 2024 17:45:00 +0200 [thread overview]
Message-ID: <20240818174500.1f7c5c50@elisabeth> (raw)
In-Reply-To: <20240816054004.1335006-4-david@gibson.dropbear.id.au>
On Fri, 16 Aug 2024 15:39:44 +1000
David Gibson <david@gibson.dropbear.id.au> wrote:
> c->mac isn't a great name, because it doesn't say whose mac address it is
> and it's not necessarily obvious in all the contexts we use it. Since this
> is specifically the address that we (passt/pasta) use on the tap interface,
> rename it to "our_tap_mac". Rename the "mac_guest" field to "guest_mac"
> to be grammatically consistent.
Wouldn't "our_mac" suffice?
Even the day we get to support other types of link (well, "tap" for a
guest is already not a tap, I know...), or especially multiple links at
the same time, I guess we will still want to use a single MAC address.
--
Stefano
next prev parent reply other threads:[~2024-08-18 15:45 UTC|newest]
Thread overview: 55+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-16 5:39 [PATCH 00/22] RFC: Allow configuration of special case NATs David Gibson
2024-08-16 5:39 ` [PATCH 01/22] treewide: Use "our address" instead of "forwarding address" David Gibson
2024-08-18 15:44 ` Stefano Brivio
2024-08-19 1:28 ` David Gibson
2024-08-16 5:39 ` [PATCH 02/22] util: Helper for formatting MAC addresses David Gibson
2024-08-18 15:44 ` Stefano Brivio
2024-08-19 1:29 ` David Gibson
2024-08-16 5:39 ` [PATCH 03/22] treewide: Rename MAC address fields for clarity David Gibson
2024-08-18 15:45 ` Stefano Brivio [this message]
2024-08-19 1:36 ` David Gibson
2024-08-16 5:39 ` [PATCH 04/22] treewide: Use struct assignment instead of memcpy() for IP addresses David Gibson
2024-08-18 15:45 ` Stefano Brivio
2024-08-19 1:38 ` David Gibson
2024-08-16 5:39 ` [PATCH 05/22] conf: Use array indices rather than pointers for DNS array slots David Gibson
2024-08-16 5:39 ` [PATCH 06/22] conf: More accurately count entries added in get_dns() David Gibson
2024-08-16 5:39 ` [PATCH 07/22] conf: Move DNS array bounds checks into add_dns[46] David Gibson
2024-08-16 5:39 ` [PATCH 08/22] conf: Move adding of a nameserver from resolv.conf into subfunction David Gibson
2024-08-16 5:39 ` [PATCH 09/22] conf: Correct setting of dns_match address in add_dns6() David Gibson
2024-08-16 5:39 ` [PATCH 10/22] conf: Treat --dns addresses as guest visible addresses David Gibson
2024-08-16 5:39 ` [PATCH 11/22] conf: Remove incorrect initialisation of addr_ll_seen David Gibson
2024-08-16 5:39 ` [PATCH 12/22] util: Correct sock_l4() binding for link local addresses David Gibson
2024-08-20 0:14 ` Stefano Brivio
2024-08-20 1:29 ` David Gibson
2024-08-16 5:39 ` [PATCH 13/22] treewide: Change misleading 'addr_ll' name David Gibson
2024-08-20 0:15 ` Stefano Brivio
2024-08-20 1:30 ` David Gibson
2024-08-16 5:39 ` [PATCH 14/22] Clarify which addresses in ip[46]_ctx are meaningful where David Gibson
2024-08-16 5:39 ` [PATCH 15/22] Initialise our_tap_ll to ip6.gw when suitable David Gibson
2024-08-16 5:39 ` [PATCH 16/22] fwd: Helpers to clarify what host addresses aren't guest accessible David Gibson
2024-08-20 19:56 ` Stefano Brivio
2024-08-21 1:40 ` David Gibson
2024-08-16 5:39 ` [PATCH 17/22] fwd: Split notion of "our tap address" from gateway for IPv4 David Gibson
2024-08-20 19:56 ` Stefano Brivio
2024-08-21 1:56 ` David Gibson
2024-08-16 5:39 ` [PATCH 18/22] Don't take "our" MAC address from the host David Gibson
2024-08-16 5:40 ` [PATCH 19/22] conf, fwd: Split notion of gateway/router from guest-visible host address David Gibson
2024-08-20 19:56 ` Stefano Brivio
2024-08-21 1:59 ` David Gibson
2024-08-16 5:40 ` [PATCH 20/22] conf: Allow address remapped to host to be configured David Gibson
2024-08-20 19:56 ` Stefano Brivio
2024-08-21 2:23 ` David Gibson
2024-08-16 5:40 ` [PATCH 21/22] fwd: Distinguish translatable from untranslatable addresses on inbound David Gibson
2024-08-16 5:40 ` [PATCH 22/22] fwd, conf: Allow NAT of the guest's assigned address David Gibson
2024-08-20 19:56 ` Stefano Brivio
2024-08-21 2:28 ` David Gibson
2024-08-16 14:45 ` [PATCH 00/22] RFC: Allow configuration of special case NATs Paul Holzinger
2024-08-16 15:03 ` Stefano Brivio
2024-08-17 8:01 ` David Gibson
2024-08-19 8:46 ` David Gibson
2024-08-19 9:27 ` Stefano Brivio
2024-08-19 9:52 ` David Gibson
2024-08-19 13:01 ` Stefano Brivio
2024-08-20 0:42 ` David Gibson
2024-08-20 20:39 ` Stefano Brivio
2024-08-21 2:51 ` David Gibson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240818174500.1f7c5c50@elisabeth \
--to=sbrivio@redhat.com \
--cc=david@gibson.dropbear.id.au \
--cc=passt-dev@passt.top \
--cc=pholzing@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://passt.top/passt
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for IMAP folder(s).