From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: passt.top; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: passt.top; dkim=pass (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=HCI8bChs; dkim-atps=neutral Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by passt.top (Postfix) with ESMTP id C08235A0275 for ; Sun, 18 Aug 2024 17:45:07 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1723995906; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=gNXsb3M2FFQzWhbxbMO+NMvnw5VfbKRn/yaijRNS7/0=; b=HCI8bChs3VlwHyRUhwSEczZOO1TVu7Wosdm5W74RFDwbCAKbQrMEYBHpmDLvuhGvACDec0 Vzju6kgZj79nu+h+/tpIw4aF0XbHEGEbmZdtgaZuIvRbfCZCjjQsWBjD/65whxX/QzMp/F Wf211S6zKcNyFQt7oCYnK3ppiH9RMt4= Received: from mail-pg1-f200.google.com (mail-pg1-f200.google.com [209.85.215.200]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-677-OIZrAe6tPkGmuV7x--oMgQ-1; Sun, 18 Aug 2024 11:45:04 -0400 X-MC-Unique: OIZrAe6tPkGmuV7x--oMgQ-1 Received: by mail-pg1-f200.google.com with SMTP id 41be03b00d2f7-7bbe0ab18caso3302822a12.0 for ; Sun, 18 Aug 2024 08:45:04 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1723995903; x=1724600703; h=content-transfer-encoding:mime-version:organization:references :in-reply-to:message-id:subject:cc:to:from:date:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=gNXsb3M2FFQzWhbxbMO+NMvnw5VfbKRn/yaijRNS7/0=; b=oBBDjRSE/OAen6nL9tyippUV+FXBiqa+HMKHyf5Kiz35SoBsHPt3r6A4FHq4kb8wm5 K5Ks66R95WFFGv5TXEPt1PaUNmji3GXicLJ4CJx5klUVKCJRqZu6idT2srk5CxUlYd5Z 9O7cELALHjTjujsBk2axsBJyKH88e6KwwRH6otGcLw6UZhTcwuNbNQoEogS+87Hk5v4f MColPXWk0W4ymr7x2yei0TFOLXtXIQ/QGhNakajJrNl9w8yNxe0uwyeqCL2CitoEggeo QEMewFDjVjzRpWZ5cpdfJ1pGOxrqVN8EwQxXkGp6g3iUpyZMz4xMosIb+qRw7hTfImYM WHiQ== X-Gm-Message-State: AOJu0Yx5KiceichQfR/UYixzh1SbNK+je8TFTWxbOCWd22g0+Fk+lyqq euMThOxsWfBcOR0Hf/U2fdC48wvCOwHtH+b3SnF+Sk3bF7JLaA1ZKbEeJ0C74RMkkZjpUgbNFio WUkX8R6uCq/KdIVYyYXW4m7X23xqY4apYpMFe3YKqPCMeCZBXqQ== X-Received: by 2002:a05:6a20:cf8b:b0:1c0:e1ed:1e9 with SMTP id adf61e73a8af0-1c904f6d712mr10831991637.6.1723995903464; Sun, 18 Aug 2024 08:45:03 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHxaRIWWZlWtUbjVKeFIbdpMlFoV+Ii5v+343w1caWeqkZCM8XrJu45u93H3cRXJoi/cgqgTg== X-Received: by 2002:a05:6a20:cf8b:b0:1c0:e1ed:1e9 with SMTP id adf61e73a8af0-1c904f6d712mr10831973637.6.1723995903088; Sun, 18 Aug 2024 08:45:03 -0700 (PDT) Received: from maya.myfinge.rs (ifcgrfdd.trafficplex.cloud. [2a10:fc81:a806:d6a9::1]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-7c6b6365998sm6235397a12.80.2024.08.18.08.45.02 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 18 Aug 2024 08:45:02 -0700 (PDT) Date: Sun, 18 Aug 2024 17:45:00 +0200 From: Stefano Brivio To: David Gibson Subject: Re: [PATCH 03/22] treewide: Rename MAC address fields for clarity Message-ID: <20240818174500.1f7c5c50@elisabeth> In-Reply-To: <20240816054004.1335006-4-david@gibson.dropbear.id.au> References: <20240816054004.1335006-1-david@gibson.dropbear.id.au> <20240816054004.1335006-4-david@gibson.dropbear.id.au> Organization: Red Hat X-Mailer: Claws Mail 4.2.0 (GTK 3.24.41; x86_64-pc-linux-gnu) MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Message-ID-Hash: 62WXMOVUDRFIGNVQ2KTTQI546AQ335VJ X-Message-ID-Hash: 62WXMOVUDRFIGNVQ2KTTQI546AQ335VJ X-MailFrom: sbrivio@redhat.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: passt-dev@passt.top, Paul Holzinger X-Mailman-Version: 3.3.8 Precedence: list List-Id: Development discussion and patches for passt Archived-At: Archived-At: List-Archive: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On Fri, 16 Aug 2024 15:39:44 +1000 David Gibson wrote: > c->mac isn't a great name, because it doesn't say whose mac address it is > and it's not necessarily obvious in all the contexts we use it. Since this > is specifically the address that we (passt/pasta) use on the tap interface, > rename it to "our_tap_mac". Rename the "mac_guest" field to "guest_mac" > to be grammatically consistent. Wouldn't "our_mac" suffice? Even the day we get to support other types of link (well, "tap" for a guest is already not a tap, I know...), or especially multiple links at the same time, I guess we will still want to use a single MAC address. -- Stefano