public inbox for passt-dev@passt.top
 help / color / mirror / code / Atom feed
From: Stefano Brivio <sbrivio@redhat.com>
To: passt-dev@passt.top
Cc: David Gibson <david@gibson.dropbear.id.au>
Subject: [PATCH 4/4] test: Duplicate existing recvfrom() valgrind suppression for recv()
Date: Tue, 20 Aug 2024 01:14:34 +0200	[thread overview]
Message-ID: <20240819231434.1481576-5-sbrivio@redhat.com> (raw)
In-Reply-To: <20240819231434.1481576-1-sbrivio@redhat.com>

Some architectures, including i686, actually have a recv() system
call, not just a recvfrom(), and we need to cover the recv() with
MSG_TRUNC into a NULL buffer for them as well.

Signed-off-by: Stefano Brivio <sbrivio@redhat.com>
---
 test/valgrind.supp | 9 +++++++++
 1 file changed, 9 insertions(+)

diff --git a/test/valgrind.supp b/test/valgrind.supp
index a158394..735b5f6 100644
--- a/test/valgrind.supp
+++ b/test/valgrind.supp
@@ -6,3 +6,12 @@
    ...
    fun:tcp_sock_consume
 }
+
+# same as above, for architectures with the recv() system call (at least i686):
+{
+   passt_recv_MSG_TRUNC_into_NULL_buffer
+   Memcheck:Param
+   socketcall.recv(buf)
+   ...
+   fun:tcp_sock_consume
+}
-- 
@@ -6,3 +6,12 @@
    ...
    fun:tcp_sock_consume
 }
+
+# same as above, for architectures with the recv() system call (at least i686):
+{
+   passt_recv_MSG_TRUNC_into_NULL_buffer
+   Memcheck:Param
+   socketcall.recv(buf)
+   ...
+   fun:tcp_sock_consume
+}
-- 
2.43.0


  parent reply	other threads:[~2024-08-19 23:14 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-08-19 23:14 [PATCH 0/4] Assorted test fixes for i386/i686 and OpenSSH 9.8 Stefano Brivio
2024-08-19 23:14 ` [PATCH 1/4] test/lib/setup: Transform i686 kernel architecture name into QEMU name (i386) Stefano Brivio
2024-08-20  0:45   ` David Gibson
2024-08-19 23:14 ` [PATCH 2/4] test/passt.mbuto: Run sshd from vsock proxy with absolute path Stefano Brivio
2024-08-20  0:45   ` David Gibson
2024-08-19 23:14 ` [PATCH 3/4] test/passt.mbuto: Install sshd-session OpenSSH's split process Stefano Brivio
2024-08-20  0:46   ` David Gibson
2024-08-26  6:41   ` David Gibson
2024-08-26  7:55     ` Stefano Brivio
2024-08-26  8:21       ` David Gibson
2024-08-19 23:14 ` Stefano Brivio [this message]
2024-08-20  0:46   ` [PATCH 4/4] test: Duplicate existing recvfrom() valgrind suppression for recv() David Gibson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240819231434.1481576-5-sbrivio@redhat.com \
    --to=sbrivio@redhat.com \
    --cc=david@gibson.dropbear.id.au \
    --cc=passt-dev@passt.top \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://passt.top/passt

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for IMAP folder(s).