From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: passt.top; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: passt.top; dkim=pass (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=aQvt/rjl; dkim-atps=neutral Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by passt.top (Postfix) with ESMTP id 340985A004C for ; Tue, 20 Aug 2024 02:15:06 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1724112905; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=1L+jp9FJXxUv0+J9lSq1Bd2xySWcm1XA+RTMNo2jVKk=; b=aQvt/rjloZsrVoo+5sTP4q42hQ1650LMT4h96Rp6EZj9ipmTdcg4/bSdWfs1zGVBJ/rBGm PDQgmV0OrQ171nxFi9kmLCByKZKC1dKcpeWZfT219aDljAXuMZ+KIrKfyCqFcinnCOzscR Fns5vHfyMH3V/rxuGM8kWV/MMHKuu5M= Received: from mail-wr1-f70.google.com (mail-wr1-f70.google.com [209.85.221.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-502-AQuXWFXGOMKawYNcfYpmAw-1; Mon, 19 Aug 2024 20:15:03 -0400 X-MC-Unique: AQuXWFXGOMKawYNcfYpmAw-1 Received: by mail-wr1-f70.google.com with SMTP id ffacd0b85a97d-371afcaab22so1444531f8f.3 for ; Mon, 19 Aug 2024 17:15:02 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1724112902; x=1724717702; h=content-transfer-encoding:mime-version:organization:references :in-reply-to:message-id:subject:cc:to:from:date:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=1L+jp9FJXxUv0+J9lSq1Bd2xySWcm1XA+RTMNo2jVKk=; b=WVMs95rnP+Pl6h3K9LZi6FrN98qIrvuT4FRdCFRkv/WiwnbCXv7XiPdiWgDwJW4j6k JTVj9bYlIpCq87eptdijfchr/9mrErzqJJpJ8bfo8DmTXnVlv9zpZmdHYa3cTpTkAlp3 c9WwBEiUFTWIgThtGRtaK+LB/9pdhtBbsfBLp7h/s+6NrM+zUNF+RG2LG42gs3fzJ0XM XJc0zYQn6AuZrAhsRNa5ocWVAi/b1+VmQ9sKJxRy0h5uSXFs8EkC95Wao7EH4hROuB5S O7WJqtm80eDF5kFa/UM4T/cW5D/z98G1UjfgOcBdtbB6K8ws+GpDd5HNV5PEZJWVaB3F M5Iw== X-Gm-Message-State: AOJu0YyURSimBSrJl2cdtBr5TnZTIVFraq9QnuNB4E7D0McOUf0O+O80 OjdODezFNXChQ65yUFH5wopRWeqaXASoPb2CuLGqmt+1oekBCBsVYzWgOXbbSa9LqfRK/CnpDXg j1pg+JnYJwvs+ATcveXzY8/lTHJ3mSGDkGoSfERBo21jq4BBA/Q== X-Received: by 2002:adf:a1d2:0:b0:371:a802:1d84 with SMTP id ffacd0b85a97d-371c606f4edmr172588f8f.63.1724112901784; Mon, 19 Aug 2024 17:15:01 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGH3vtGEqDCgvf2o7VvxY9NJo5nq7hpHI/fgxN2BRyTmCsWqYJrGH+SS2JlaRG/FaI1HTndaQ== X-Received: by 2002:adf:a1d2:0:b0:371:a802:1d84 with SMTP id ffacd0b85a97d-371c606f4edmr172579f8f.63.1724112901245; Mon, 19 Aug 2024 17:15:01 -0700 (PDT) Received: from maya.myfinge.rs (ifcgrfdd.trafficplex.cloud. [2a10:fc81:a806:d6a9::1]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-371898aa8casm11823729f8f.93.2024.08.19.17.15.00 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 19 Aug 2024 17:15:00 -0700 (PDT) Date: Tue, 20 Aug 2024 02:14:59 +0200 From: Stefano Brivio To: David Gibson Subject: Re: [PATCH 12/22] util: Correct sock_l4() binding for link local addresses Message-ID: <20240820021459.6a9b8f28@elisabeth> In-Reply-To: <20240816054004.1335006-13-david@gibson.dropbear.id.au> References: <20240816054004.1335006-1-david@gibson.dropbear.id.au> <20240816054004.1335006-13-david@gibson.dropbear.id.au> Organization: Red Hat X-Mailer: Claws Mail 4.2.0 (GTK 3.24.41; x86_64-pc-linux-gnu) MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Message-ID-Hash: VM7EV6IW44QAUVN22J5N7SF7LUOE4T37 X-Message-ID-Hash: VM7EV6IW44QAUVN22J5N7SF7LUOE4T37 X-MailFrom: sbrivio@redhat.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: passt-dev@passt.top, Paul Holzinger X-Mailman-Version: 3.3.8 Precedence: list List-Id: Development discussion and patches for passt Archived-At: Archived-At: List-Archive: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On Fri, 16 Aug 2024 15:39:53 +1000 David Gibson wrote: > When binding an IPv6 socket in sock_l4() we need to supply a scope id if > the address is link-local. We check for this by comparing the given > address to c->ip6.addr_ll. This is correct only by accident: while > c->ip6.addr_ll is typically set to the hsot interface's link local > address, the actually purpose of it is to provide a link local address Nits: host, actual -- Stefano