From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: passt.top; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: passt.top; dkim=pass (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=aaK24Fma; dkim-atps=neutral Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by passt.top (Postfix) with ESMTP id 3638F5A0276 for ; Tue, 20 Aug 2024 02:15:10 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1724112909; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=tH6XXjZHz2Ttlu1y1RJKS0GiK+6H9bxPOFdwEOw+Mw8=; b=aaK24Fmab+D4jP1ChWGRB90qbYIuvPQpPQCaf2UeHv+zYDRKTjoaYNwbQnery5LdpClHv9 4ydkyEIYBnnsg9ILheUQ2sagkezLl90NWc9Z97ju2q2HurPW0DgrUcezLJf3Zy9dHFPcLd BlHTl5xemE31SWS2ExGMYzVtWjz0vUw= Received: from mail-wr1-f69.google.com (mail-wr1-f69.google.com [209.85.221.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-561-gTJ8YbWkOYyqCuJ7Xo1g7g-1; Mon, 19 Aug 2024 20:15:07 -0400 X-MC-Unique: gTJ8YbWkOYyqCuJ7Xo1g7g-1 Received: by mail-wr1-f69.google.com with SMTP id ffacd0b85a97d-371afcaab22so1444570f8f.3 for ; Mon, 19 Aug 2024 17:15:07 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1724112906; x=1724717706; h=content-transfer-encoding:mime-version:organization:references :in-reply-to:message-id:subject:cc:to:from:date:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=tH6XXjZHz2Ttlu1y1RJKS0GiK+6H9bxPOFdwEOw+Mw8=; b=foqXy1SIMDKM1551uAEYD6IaYu4nc7OpYicf4BtHMMazkgRhBl+HsuU7+RcH+SO9Vc kb/JO2ilp409gb70nK3bKdp8RyUxHVn0fW+bJr3T+hTTjTGzJZrh6+Nr/6m0CYrlJzdg 3wj/c1B/Mqj8bu6Abh40kFGkm0xvWpoSrLCsKOWflHBzj2MkpGfcvpYxwWmgWz8WVSKk yl1q7PfXF7Mdx53Rbn3BZBfpcmiaC7kfoOVbmqMaHj1Sqpxjo2Xcb2KRmjTg1kwZXVzb MKAZylZxPjPZlxr6L7OEj8xoDdq0ppZ7apdNC+0QxrEvzag0rMSrzcOhJ1As86haC0ri 9xfw== X-Gm-Message-State: AOJu0YyBHuAd/Xk1hDBcg/ViYXVUh8qDXypx7gyYTlu49QBP6f8MOdpT KxYTTxbooFMX0ahvxc0jbkxQ8vpHO1TJHiAYxl9wyljlYVUm1K06jX7U/DHPTgG5qs39Iq6AZxw KMZ1zX8/fjEJAZD9thgxdq1TS6mGU5Tw9dOENOgxZdEU8TFkmNA== X-Received: by 2002:a5d:6d05:0:b0:371:c51a:3b2a with SMTP id ffacd0b85a97d-371c5fa669cmr309165f8f.4.1724112906205; Mon, 19 Aug 2024 17:15:06 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFNRsJ0qSNZAk32tL4TghlQFgZaNQuB//Pe1PFXkDiCX8choYT8rS9oZMEcu+AI4Um01qwnyA== X-Received: by 2002:a5d:6d05:0:b0:371:c51a:3b2a with SMTP id ffacd0b85a97d-371c5fa669cmr309154f8f.4.1724112905750; Mon, 19 Aug 2024 17:15:05 -0700 (PDT) Received: from maya.myfinge.rs (ifcgrfdd.trafficplex.cloud. [2a10:fc81:a806:d6a9::1]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-42aa96d5ac7sm92001465e9.44.2024.08.19.17.15.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 19 Aug 2024 17:15:05 -0700 (PDT) Date: Tue, 20 Aug 2024 02:15:03 +0200 From: Stefano Brivio To: David Gibson Subject: Re: [PATCH 13/22] treewide: Change misleading 'addr_ll' name Message-ID: <20240820021503.35cc29ed@elisabeth> In-Reply-To: <20240816054004.1335006-14-david@gibson.dropbear.id.au> References: <20240816054004.1335006-1-david@gibson.dropbear.id.au> <20240816054004.1335006-14-david@gibson.dropbear.id.au> Organization: Red Hat X-Mailer: Claws Mail 4.2.0 (GTK 3.24.41; x86_64-pc-linux-gnu) MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Message-ID-Hash: PAMGFJTBLDJWMZFEZUOAFT2WXA5NVFIX X-Message-ID-Hash: PAMGFJTBLDJWMZFEZUOAFT2WXA5NVFIX X-MailFrom: sbrivio@redhat.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: passt-dev@passt.top, Paul Holzinger X-Mailman-Version: 3.3.8 Precedence: list List-Id: Development discussion and patches for passt Archived-At: Archived-At: List-Archive: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On Fri, 16 Aug 2024 15:39:54 +1000 David Gibson wrote: > c->ip6.addr_ll is not like c->ip6.addr. The latter is an address for the > guest, but the former is an address for our use on the tap link. Rename it > accordingly, to 'our_tap_ll'. Same as 3/22: could this be "our_ll"? Same here, not a strong preference. I reviewed only up to 16/22 so far. -- Stefano